mirror/protobuf-go
1
0
Fork 0
mirror of https://github.com/protocolbuffers/protobuf-go.git synced 2024-12-29 12:17:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

proto: bench_test fixes

Browse Source 
Don't fail on test cases with partial messages.

Create a new message on each decode cycle.

Change-Id: I7c1d91a2853e340fc0bae05a238bb28eb682e6ce
Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/185377
Reviewed-by: Joe Tsai <thebrokentoaster@gmail.com>
This commit is contained in:
Damien Neil 2019-07-08 15:19:51 -07:00
parent 5455ef5ca4
commit dd380ab64d
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
proto/bench_test.go
View File

@ -38,7 +38,7 @@ func BenchmarkEncode(b *testing.B) {
} else {
_, err = opts.Marshal(want)
}
if err != nil {
if err != nil && !test.partial {
b.Fatal(err)
}
}
@ -55,16 +55,16 @@ func BenchmarkDecode(b *testing.B) {
opts := proto.UnmarshalOptions{AllowPartial: *allowPartial}
b.Run(fmt.Sprintf("%s (%T)", test.desc, want), func(b *testing.B) {
b.RunParallel(func(pb *testing.PB) {
for pb.Next() {
m := reflect.New(reflect.TypeOf(want).Elem()).Interface().(proto.Message)
v1 := m.(protoV1.Message)
for pb.Next() {
var err error
if *benchV1 {
err = protoV1.Unmarshal(test.wire, v1)
} else {
err = opts.Unmarshal(test.wire, m)
}
if err != nil {
if err != nil && !test.partial {
b.Fatal(err)
}
}