From 9492118ab180bb63f9f5d70ebb6522cac1f8854f Mon Sep 17 00:00:00 2001 From: Michael Stapelberg Date: Wed, 1 Nov 2023 11:53:48 +0100 Subject: [PATCH] internal/benchmarks: make download_benchdata print an error Currently, the script fails, and not with a good error message. related to https://github.com/golang/protobuf/issues/1524 Change-Id: Ia27a895a7ae2f6349bb1262936e4428fa485bb92 Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/538955 Reviewed-by: Damien Neil Reviewed-by: Lasse Folger --- internal/benchmarks/download_benchdata.bash | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/internal/benchmarks/download_benchdata.bash b/internal/benchmarks/download_benchdata.bash index 30399e7f..17f542a2 100755 --- a/internal/benchmarks/download_benchdata.bash +++ b/internal/benchmarks/download_benchdata.bash @@ -7,11 +7,6 @@ cd "$(git rev-parse --show-toplevel)" mkdir -p .cache/benchdata cd .cache/benchdata -# Download small benchmark datasets. -PROTOBUF_VERSION=v3.11.4 -curl -s -O https://raw.githubusercontent.com/protocolbuffers/protobuf/$PROTOBUF_VERSION/benchmarks/datasets/google_message1/proto2/dataset.google_message1_proto2.pb -curl -s -O https://raw.githubusercontent.com/protocolbuffers/protobuf/$PROTOBUF_VERSION/benchmarks/datasets/google_message1/proto3/dataset.google_message1_proto3.pb -curl -s -O https://raw.githubusercontent.com/protocolbuffers/protobuf/$PROTOBUF_VERSION/benchmarks/datasets/google_message2/dataset.google_message2.pb - -# Download large benchmark datasets. -curl -s https://storage.googleapis.com/protobuf_opensource_benchmark_data/datasets.tar.gz | tar zx +echo "This script needs to be updated to work with https://github.com/google/fleetbench" >&2 +echo "See https://github.com/golang/protobuf/issues/1570" >&2 +exit 1