diff --git a/internal/encoding/json/string.go b/internal/encoding/json/string.go index fbfb09fa..7f70cff0 100644 --- a/internal/encoding/json/string.go +++ b/internal/encoding/json/string.go @@ -18,7 +18,7 @@ import ( func appendString(out []byte, in string) ([]byte, error) { var nerr errors.NonFatal out = append(out, '"') - i := indexNeedEscape(in) + i := indexNeedEscapeInString(in) in, out = in[i:], append(out, in[:i]...) for len(in) > 0 { switch r, n := utf8.DecodeRuneInString(in); { @@ -47,7 +47,7 @@ func appendString(out []byte, in string) ([]byte, error) { } in = in[n:] default: - i := indexNeedEscape(in[n:]) + i := indexNeedEscapeInString(in[n:]) in, out = in[n+i:], append(out, in[:n+i]...) } } @@ -65,7 +65,7 @@ func (d *Decoder) parseString(in []byte) (string, int, error) { return "", 0, d.newSyntaxError("invalid character %q at start of string", in[0]) } in = in[1:] - i := indexNeedEscape(string(in)) + i := indexNeedEscapeInBytes(in) in, out := in[i:], in[:i:i] // set cap to prevent mutations for len(in) > 0 { switch r, n := utf8.DecodeRune(in); { @@ -123,16 +123,16 @@ func (d *Decoder) parseString(in []byte) (string, int, error) { return "", 0, d.newSyntaxError("invalid escape code %q in string", in[:2]) } default: - i := indexNeedEscape(string(in[n:])) + i := indexNeedEscapeInBytes(in[n:]) in, out = in[n+i:], append(out, in[:n+i]...) } } return "", 0, io.ErrUnexpectedEOF } -// indexNeedEscape returns the index of the next character that needs escaping. -// If no characters need escaping, this returns the input length. -func indexNeedEscape(s string) int { +// indexNeedEscapeInString returns the index of the character that needs +// escaping. If no characters need escaping, this returns the input length. +func indexNeedEscapeInString(s string) int { for i, r := range s { if r < ' ' || r == '\\' || r == '"' || r == utf8.RuneError { return i @@ -140,3 +140,18 @@ func indexNeedEscape(s string) int { } return len(s) } + +// indexNeedEscapeInBytes returns the index of the character that needs +// escaping. If no characters need escaping, this returns the input length. +// TODO: Remove this duplicate function when https://golang.org/issue/31506 gets +// resolved. +func indexNeedEscapeInBytes(b []byte) int { + for i := 0; i < len(b); { + r, n := utf8.DecodeRune(b[i:]) + if r < ' ' || r == '\\' || r == '"' || r == utf8.RuneError { + return i + } + i += n + } + return len(b) +} diff --git a/internal/encoding/text/string.go b/internal/encoding/text/string.go index 0274295c..6a0b730d 100644 --- a/internal/encoding/text/string.go +++ b/internal/encoding/text/string.go @@ -33,7 +33,7 @@ func appendString(out []byte, v Value, outputASCII bool) ([]byte, error) { in := v.String() out = append(out, '"') - i := indexNeedEscape(in) + i := indexNeedEscapeInString(in) in, out = in[i:], append(out, in[:i]...) for len(in) > 0 { switch r, n := utf8.DecodeRuneInString(in); { @@ -72,7 +72,7 @@ func appendString(out []byte, v Value, outputASCII bool) ([]byte, error) { } in = in[n:] default: - i := indexNeedEscape(in[n:]) + i := indexNeedEscapeInString(in[n:]) in, out = in[n+i:], append(out, in[:n+i]...) } } @@ -96,7 +96,7 @@ func consumeString(in []byte) (Value, int, error) { return Value{}, 0, newSyntaxError("invalid character %q at start of string", in[0]) } in = in[1:] - i := indexNeedEscape(string(in)) + i := indexNeedEscapeInBytes(in) in, out := in[i:], in[:i:i] // set cap to prevent mutations for len(in) > 0 { switch r, n := utf8.DecodeRune(in); { @@ -185,7 +185,7 @@ func consumeString(in []byte) (Value, int, error) { return Value{}, 0, newSyntaxError("invalid escape code %q in string", in[:2]) } default: - i := indexNeedEscape(string(in[n:])) + i := indexNeedEscapeInBytes(in[n:]) in, out = in[n+i:], append(out, in[:n+i]...) } } @@ -217,9 +217,9 @@ func (p *decoder) unmarshalStrings() (Value, error) { return rawValueOf(strings.Join(ss, ""), b[:len(b):len(b)]), nil } -// indexNeedEscape returns the index of the next character that needs escaping. -// If no characters need escaping, this returns the input length. -func indexNeedEscape(s string) int { +// indexNeedEscapeInString returns the index of the character that needs +// escaping. If no characters need escaping, this returns the input length. +func indexNeedEscapeInString(s string) int { for i := 0; i < len(s); i++ { if c := s[i]; c < ' ' || c == '"' || c == '\'' || c == '\\' || c >= utf8.RuneSelf { return i @@ -227,3 +227,18 @@ func indexNeedEscape(s string) int { } return len(s) } + +// indexNeedEscapeInBytes returns the index of the character that needs +// escaping. If no characters need escaping, this returns the input length. +// TODO: Remove this duplicate function when https://golang.org/issue/31506 gets +// resolved. +func indexNeedEscapeInBytes(b []byte) int { + for i := 0; i < len(b); { + c, size := utf8.DecodeRune(b[i:]) + if c < ' ' || c == '"' || c == '\'' || c == '\\' || c >= utf8.RuneSelf { + return i + } + i += size + } + return len(b) +}