Commit Graph

65 Commits

Author SHA1 Message Date
Weijia Wang
4a817d2083 24.05 is Vicuña 2024-05-22 18:15:34 +02:00
Kenichi Kamiya
5f46d07e14
PULL_REQUEST_TEMPLATE.md: Update link to package tests 2024-04-04 03:28:06 +09:00
Sandro
0e990c0e9a
PULL_REQUEST_TEMPLATE: update link to reviewing contribution 2024-03-23 12:25:37 +01:00
Silvan Mosberger
f10b752da5
Merge pull request #269030 from alyssais/github-priorities
.github: fix "Priorities" heading level
2023-12-03 13:07:36 +01:00
Alyssa Ross
192d953bc2
.github: removing "Priorities" heading
Where this was a markdown heading, it sometimes had the wrong weight
so it appeared as if it was a subheading of the previous section, and
some people feel the word "Priorities" creates misleading
expectations.

Link: https://github.com/NixOS/nixpkgs/pull/203969/files#r1037761779
2023-12-03 12:23:22 +01:00
figsoda
43a3d2d90e {CONTRIBUTING,PULL_REQUEST_TEMPLATE}.md: update NixOS release 2023-11-27 17:33:01 -05:00
Silvan Mosberger
7ae0729ae5 Encourage +1's for prioritisation
Adds a small text to each issue and the PR template to encourage people to use
👍's for issues they're also interested in. See
https://github.com/NixOS/nix.dev/issues/359 for more information

Co-Authored-By: Valentin Gagarin <valentin.gagarin@tweag.io>
2023-11-21 07:00:18 +01:00
Artturi
e0cca29f4b
Merge pull request #238575 from toonn/pr-template-sandboxing 2023-10-20 12:25:59 +03:00
toonn
c05019d716
PULL_REQUEST_TEMPLATE.md: Update sandboxing check
Update the sandboxing check to include the `relaxed` setting for
sandboxing. Previously there was no obvious and correct way to convey
this intermediate setting between sandboxing being completely disabled
and being enforced strictly.
2023-06-19 14:53:59 +02:00
Victor Engmark
2bf38f5fab pr-template: Use semantic H2 level headings
The original Markdown ended up being rendered as `<H6>` HTML elements,
which is not semantically valid immediately after an `<H1>` element (the
PR title).
2023-06-19 14:18:52 +12:00
nikstur
9a1f50a588 .github/PULL_REQUEST_TEMPLATE.md: directly link to release notes 2023-06-16 23:51:35 +02:00
Raito Bezarius
2c6ae7132c
Release NixOS 23.05 2023-05-31 22:52:52 +02:00
pennae
d041641b1a nixos/manual: remove md-to-db
with manual chapters no longer needing pandoc for their conversion to
xml we can get rid of this source of confusion, and its huge cache of
xml files.
2023-02-10 06:40:15 +01:00
Martin Weinelt
f1b9cc23aa Release NixOS 22.11 2022-11-30 11:52:38 +01:00
Markus Wamser
2c74606664
.github/PULL_REQUEST_TEMPLATE.md: 21.11 -> 22.05 2022-05-31 19:14:32 +08:00
Janne Heß
cbaacfb8df
Release 22.05 2022-05-30 20:50:07 +02:00
Martin Weinelt
d06e5ddb33
PULL_REQUEST_TEMPLATE: move call-for-review to the end
This improves URL previews like the ones on Discourse, where currently
the boilerplate comment is printed for every PR link instead of parts of
the motivation.
2022-03-07 19:56:13 +01:00
Emery Hemingway
d63249ac27 PULL_REQUEST_TEMPLATE.md: Request PRs describe themselves
There are a lot of PRs for updates that don't make it easy to find
out what changes might be breaking and lots of PRs for new packages
that don't describe what the new packages is or does.
2022-03-07 12:29:00 -06:00
Bobby Rong
af21d41260
.github/PULL_REQUEST_TEMPLATE.md, CONTRIBUTING.md: 21.11 -> 22.05 (#147977)
* .github/PULL_REQUEST_TEMPLATE.md: 21.11 -> 22.05

* CONTRIBUTING.md: 21.11 -> 22.05
2021-11-30 00:20:21 -05:00
Sebastián Mancilla
997d559bb3 PULL_REQUEST_TEMPLATE.md: fix link to nix.conf documentation 2021-11-19 22:09:17 -03:00
Alexander Bantyev
e644da4d99
Merge pull request #141820 from cab404/patch-1
.github/PULL_REQUEST_TEMPLATE: added md-to-db reminder
2021-11-20 00:17:56 +03:00
Artturin
a60634790a PULL_REQUEST_TEMPLATE.md: change nixpkgs-review wip to rev HEAD 2021-11-13 01:28:46 +02:00
Robert Hensing
c7043de51d PULL_REQUEST_TEMPLATE.md: ticks to bullets
As suggested by 06kellyjac.
2021-11-03 18:16:41 +01:00
Robert Hensing
883051e1a1 PULL_REQUEST_TEMPLATE.md: execution -> basic functionality
As suggested by Artturin.
2021-11-01 00:15:21 +01:00
Robert Hensing
93c54e06bc
PULL_REQUEST_TEMPLATE.md: Elaborate on testing
We've recently seen VM tests being added that could have been simple package tests instead.
2021-10-31 20:56:30 +01:00
Vladimir Serov
de211a38e2
.github/PULL_REQUEST_TEMPLATE: added md-to-db reminder 2021-10-17 03:05:08 +03:00
Las Safin
629f88f3af
PULL_REQUEST_TEMPLATE.md: Improve platform checkboxes
1) Building with the sandbox enabled is the standard on Linux,
   so it is of little relevance with distribution they are using.
   Because of this, we now specify "Linux" instead of "NixOS",
   and the sandbox checkbox specifies "non-Linux".
2) aarch64 is a much more common platform, so we add two separate
   checkboxes for both aarch64-linux and aarch64-darwin.
3) The platform names now match what is actually used by Nix.
2021-08-19 13:01:59 +00:00
Kid
af74d97e9b
doc: fix typo and wording in pull request template 2021-08-05 22:45:09 +08:00
Niklas Hambüchen
3c29ced243 CONTRIBUTING.md: Move to repo root, where it is more visible.
We found that many users found it difficult to locate this document.

Github supports it in the root, see:
https://docs.github.com/en/communities/setting-up-your-project-for-healthy-contributions/setting-guidelines-for-repository-contributors
2021-06-26 04:51:38 +02:00
Ryan Mulligan
f91d7910ea doc: cleanup documentation relating to release notes
Also delete empty release notes file.
2021-06-23 11:04:22 -07:00
Pavol Rusnak
576c2f555e pull_request_template: fix link to CONTRIBUTING.md 2021-06-05 08:27:10 -07:00
Jonathan Ringer
291dcac830
pull_request_template: Add release note criteria 2021-06-02 13:37:14 -07:00
Léo Gaspard
211fee9c43
pull request template: cleanup (#117537)
Remove elements of the PR template that have a low signal/noise ratio,
and add one that I think would have a good signal/noise ratio.

-----
Remove:
Determined the impact on package closure size (by running `nix path-info
-S` before and after)
-----
Rationale:
This is rarely done in practice, and apart from for specific packages
this is usually not a good indicator of anything useful

It might make sense to re-introduce it with two holes to fill, but then
we would have to make a serious decision to never land without these two
numbers filled in or with too big a regression, because in practice this
box has been a no-op in many cases.

Maybe just integrating this check in nixpkgs-review would bring the most
benefit here?
-----

-----
Remove:
Ensured that relevant documentation is up to date
-----
Rationale:
This is fuzzy, “relevant documentation” is way too often hard to find
-----

-----
Add:
Added a release notes entry if the change is major or breaking
-----
Rationale:
This is way too often forgotten, and is also a self-contained easy task
-----
2021-05-21 03:06:21 +02:00
Jonathan Ringer
698c471340
PULL_REQUEST_TEMPLATE.md: use rendered docs 2020-11-13 16:18:19 -08:00
Pavol Rusnak
7b0167204d treewide: use https for nixos.org and hydra.nixos.org
tarballs.nixos.org is omitted from the change because urls from there
are always hashed and checked
2020-05-03 22:14:21 -07:00
Jörg Thalheim
93862d05f7
PULL_REQUEST_TEMPLATE: try to simplify call-for-review
The text is quite long and hard to read in hub (because it is one whole line
with no line breaks). Also simplified the language/sentence structure a bit for
non-native speakers.
2020-04-27 22:07:19 +01:00
Ingolf Wagner
d9bbc22cef
.github: remove cc from pull-request template 2020-01-03 15:58:31 +13:00
Jörg Thalheim
8a57552c18
nixpkgs-review: 2.1.0 -> 2.1.1
changelog: https://github.com/Mic92/nixpkgs-review/releases/tag/2.1.1
2019-12-22 09:26:57 +00:00
Americo
5c59da48e4
.github: clarify things done re: sandboxing
Per https://github.com/NixOS/nixpkgs/pull/58147#issuecomment-478234495
sandboxing is not fully functional on macOS.

.github: specify where sandboxing can be run

Co-Authored-By: Jon <jonringer@users.noreply.github.com>

.github: remove macOS note
2019-10-30 11:32:29 -07:00
Vladimír Čunát
3c5f5b1cde Fix link in PULL_REQUEST_TEMPLATE.md (the same link) 2019-10-28 19:25:05 +01:00
Steven Shaw
e2a28e8dd2 PULL_REQUEST_TEMPLATE: Add "Notify maintainers" section 2019-07-30 08:36:16 +02:00
Craig Hall
d096030d07
PULL_REQUEST_TEMPLATE: "Assured whether" -> "Ensured that" 2019-07-01 11:22:48 +01:00
worldofpeace
1d38a2f5c3
Merge pull request #58098 from Infinisil/encouraging_reviews
PULL_REQUEST_TEMPLATE: Add encouragement to review PRs
2019-04-04 17:14:18 -04:00
Silvan Mosberger
4e398a325e
PULL_REQUEST_TEMPLATE: Add encouragement to review PRs 2019-03-28 21:18:46 +01:00
Jörg Thalheim
22d083e659
doc/reviewing-contributions: nix-review instead of nox-review
It is faster, handles more edge cases and allows to test/review the built
packages interactively.
2019-03-20 11:28:00 +00:00
Niklas Hambüchen
f2816e47ab PULL_REQUEST_TEMPLATE: Ask for docs 2018-11-22 19:57:19 +01:00
Eelco Dolstra
bf1c28e978
PULL_REQUEST_TEMPLATE.md: Ask for closure size impact 2018-06-21 18:52:26 +02:00
Bob van der Linden
b503e76ee0
use sandbox instead of build-use-sandbox 2018-05-30 21:48:07 +02:00
Maxime Dénès
9ca1b56683
pr template: make values of platform field less ambiguous 2017-10-09 12:53:09 +02:00
Piotr Bogdan
e221d945ad pr template: make formatting consistent 2017-09-03 19:57:18 +01:00