From 293c17926d47fb66e8a01267c2e698ab40dc53a6 Mon Sep 17 00:00:00 2001 From: Adam Stephens Date: Sat, 10 Aug 2024 12:08:33 -0400 Subject: [PATCH 1/4] nixos/incus-agent: init --- nixos/modules/module-list.nix | 1 + nixos/modules/virtualisation/incus-agent.nix | 41 ++++++++++++++++++++ pkgs/by-name/in/incus/generic.nix | 15 ++++++- 3 files changed, 55 insertions(+), 2 deletions(-) create mode 100644 nixos/modules/virtualisation/incus-agent.nix diff --git a/nixos/modules/module-list.nix b/nixos/modules/module-list.nix index 28a58249e798..077dafdf3990 100644 --- a/nixos/modules/module-list.nix +++ b/nixos/modules/module-list.nix @@ -1679,6 +1679,7 @@ ./virtualisation/ecs-agent.nix ./virtualisation/hyperv-guest.nix ./virtualisation/incus.nix + ./virtualisation/incus-agent.nix ./virtualisation/kvmgt.nix ./virtualisation/libvirtd.nix ./virtualisation/lxc.nix diff --git a/nixos/modules/virtualisation/incus-agent.nix b/nixos/modules/virtualisation/incus-agent.nix new file mode 100644 index 000000000000..bfb9eeb75d33 --- /dev/null +++ b/nixos/modules/virtualisation/incus-agent.nix @@ -0,0 +1,41 @@ +{ + config, + lib, + pkgs, + ... +}: + +let + cfg = config.virtualisation.incus.agent; +in +{ + meta = { + maintainers = lib.teams.lxc.members; + }; + + options = { + virtualisation.incus.agent.enable = lib.mkEnableOption "Incus agent"; + }; + + config = lib.mkIf cfg.enable { + services.udev.packages = [ config.virtualisation.incus.package.agent_loader ]; + systemd.packages = [ config.virtualisation.incus.package.agent_loader ]; + + systemd.services.incus-agent = { + enable = true; + wantedBy = [ "multi-user.target" ]; + + path = [ + pkgs.kmod + pkgs.util-linux + + # allow `incus exec` to find system binaries + "/run/current-system/sw" + ]; + + # avoid killing nixos-rebuild switch when executed through incus exec + restartIfChanged = false; + stopIfChanged = false; + }; + }; +} diff --git a/pkgs/by-name/in/incus/generic.nix b/pkgs/by-name/in/incus/generic.nix index 56b10804079b..7ffdc1c83ec4 100644 --- a/pkgs/by-name/in/incus/generic.nix +++ b/pkgs/by-name/in/incus/generic.nix @@ -13,10 +13,8 @@ buildGoModule, fetchFromGitHub, writeScript, - writeShellScript, acl, cowsql, - hwdata, libcap, lxc, pkg-config, @@ -38,6 +36,11 @@ buildGoModule rec { version ; + outputs = [ + "out" + "agent_loader" + ]; + src = fetchFromGitHub { owner = "lxc"; repo = "incus"; @@ -99,6 +102,14 @@ buildGoModule rec { --bash <($out/bin/incus completion bash) \ --fish <($out/bin/incus completion fish) \ --zsh <($out/bin/incus completion zsh) + + mkdir -p $agent_loader/bin $agent_loader/etc/systemd/system $agent_loader/lib/udev/rules.d + cp internal/server/instance/drivers/agent-loader/incus-agent-setup $agent_loader/bin/ + chmod +x $agent_loader/bin/incus-agent-setup + patchShebangs $agent_loader/bin/incus-agent-setup + cp internal/server/instance/drivers/agent-loader/systemd/incus-agent.service $agent_loader/etc/systemd/system/ + cp internal/server/instance/drivers/agent-loader/systemd/incus-agent.rules $agent_loader/lib/udev/rules.d/99-incus-agent.rules + substituteInPlace $agent_loader/etc/systemd/system/incus-agent.service --replace-fail 'TARGET/systemd' "$agent_loader/bin" ''; passthru = { From 094f2b6c9d87da6348e2517936a3ad907c82d1cf Mon Sep 17 00:00:00 2001 From: Adam Stephens Date: Sat, 10 Aug 2024 12:40:16 -0400 Subject: [PATCH 2/4] nixos/incus: add incus-only vm and container images --- .../incus/incus-container-image-inner.nix | 34 +++++++ .../scripts/incus/incus-container-image.nix | 47 +++++++++ .../incus-virtual-machine-image-inner.nix | 34 +++++++ .../incus/incus-virtual-machine-image.nix | 48 ++++++++++ nixos/maintainers/scripts/incus/nix.tpl | 12 +++ .../virtualisation/incus-virtual-machine.nix | 61 ++++++++++++ .../modules/virtualisation/lxc-container.nix | 2 +- nixos/release.nix | 95 +++++++++++++++++++ nixos/tests/incus/container.nix | 6 +- nixos/tests/incus/incusd-options.nix | 6 +- nixos/tests/incus/virtual-machine.nix | 10 +- 11 files changed, 343 insertions(+), 12 deletions(-) create mode 100644 nixos/maintainers/scripts/incus/incus-container-image-inner.nix create mode 100644 nixos/maintainers/scripts/incus/incus-container-image.nix create mode 100644 nixos/maintainers/scripts/incus/incus-virtual-machine-image-inner.nix create mode 100644 nixos/maintainers/scripts/incus/incus-virtual-machine-image.nix create mode 100644 nixos/maintainers/scripts/incus/nix.tpl create mode 100644 nixos/modules/virtualisation/incus-virtual-machine.nix diff --git a/nixos/maintainers/scripts/incus/incus-container-image-inner.nix b/nixos/maintainers/scripts/incus/incus-container-image-inner.nix new file mode 100644 index 000000000000..68979306a610 --- /dev/null +++ b/nixos/maintainers/scripts/incus/incus-container-image-inner.nix @@ -0,0 +1,34 @@ +# Edit this configuration file to define what should be installed on +# your system. Help is available in the configuration.nix(5) man page +# and in the NixOS manual (accessible by running ‘nixos-help’). + +{ modulesPath, ... }: + +{ + imports = [ + # Include the default incus configuration. + "${modulesPath}/virtualisation/lxc-container.nix" + # Include the container-specific autogenerated configuration. + ./incus.nix + ]; + + networking = { + dhcpcd.enable = false; + useDHCP = false; + useHostResolvConf = false; + }; + + systemd.network = { + enable = true; + networks."50-eth0" = { + matchConfig.Name = "eth0"; + networkConfig = { + DHCP = "ipv4"; + IPv6AcceptRA = true; + }; + linkConfig.RequiredForOnline = "routable"; + }; + }; + + system.stateVersion = "@stateVersion@"; # Did you read the comment? +} diff --git a/nixos/maintainers/scripts/incus/incus-container-image.nix b/nixos/maintainers/scripts/incus/incus-container-image.nix new file mode 100644 index 000000000000..63b9353f7ee3 --- /dev/null +++ b/nixos/maintainers/scripts/incus/incus-container-image.nix @@ -0,0 +1,47 @@ +{ lib, pkgs, ... }: + +{ + imports = [ ../../../modules/virtualisation/lxc-container.nix ]; + + virtualisation.lxc.templates.nix = { + enable = true; + target = "/etc/nixos/incus.nix"; + template = ./nix.tpl; + when = [ + "create" + "copy" + ]; + }; + + # copy the config for nixos-rebuild + system.activationScripts.config = + let + config = pkgs.substituteAll { + src = ./incus-container-image-inner.nix; + stateVersion = lib.trivial.release; + }; + in + '' + if [ ! -e /etc/nixos/configuration.nix ]; then + install -m 0644 -D ${config} /etc/nixos/configuration.nix + fi + ''; + + networking = { + dhcpcd.enable = false; + useDHCP = false; + useHostResolvConf = false; + }; + + systemd.network = { + enable = true; + networks."50-eth0" = { + matchConfig.Name = "eth0"; + networkConfig = { + DHCP = "ipv4"; + IPv6AcceptRA = true; + }; + linkConfig.RequiredForOnline = "routable"; + }; + }; +} diff --git a/nixos/maintainers/scripts/incus/incus-virtual-machine-image-inner.nix b/nixos/maintainers/scripts/incus/incus-virtual-machine-image-inner.nix new file mode 100644 index 000000000000..cd176a38988f --- /dev/null +++ b/nixos/maintainers/scripts/incus/incus-virtual-machine-image-inner.nix @@ -0,0 +1,34 @@ +# Edit this configuration file to define what should be installed on +# your system. Help is available in the configuration.nix(5) man page +# and in the NixOS manual (accessible by running ‘nixos-help’). + +{ modulesPath, ... }: + +{ + imports = [ + # Include the default incus configuration. + "${modulesPath}/virtualisation/incus-virtual-machine.nix" + # Include the container-specific autogenerated configuration. + ./incus.nix + ]; + + networking = { + dhcpcd.enable = false; + useDHCP = false; + useHostResolvConf = false; + }; + + systemd.network = { + enable = true; + networks."50-enp5s0" = { + matchConfig.Name = "enp5s0"; + networkConfig = { + DHCP = "ipv4"; + IPv6AcceptRA = true; + }; + linkConfig.RequiredForOnline = "routable"; + }; + }; + + system.stateVersion = "@stateVersion@"; # Did you read the comment? +} diff --git a/nixos/maintainers/scripts/incus/incus-virtual-machine-image.nix b/nixos/maintainers/scripts/incus/incus-virtual-machine-image.nix new file mode 100644 index 000000000000..0742e7d75ac9 --- /dev/null +++ b/nixos/maintainers/scripts/incus/incus-virtual-machine-image.nix @@ -0,0 +1,48 @@ +{ lib, pkgs, ... }: + +{ + imports = [ ../../../modules/virtualisation/incus-virtual-machine.nix ]; + + virtualisation.lxc.templates.nix = { + enable = true; + target = "/etc/nixos/incus.nix"; + template = ./nix.tpl; + when = [ + "create" + "copy" + ]; + }; + + # copy the config for nixos-rebuild + system.activationScripts.config = + let + config = pkgs.substituteAll { + src = ./incus-virtual-machine-image-inner.nix; + stateVersion = lib.trivial.release; + }; + in + '' + if [ ! -e /etc/nixos/configuration.nix ]; then + install -m 0644 -D ${config} /etc/nixos/configuration.nix + fi + ''; + + # Network + networking = { + dhcpcd.enable = false; + useDHCP = false; + useHostResolvConf = false; + }; + + systemd.network = { + enable = true; + networks."50-enp5s0" = { + matchConfig.Name = "enp5s0"; + networkConfig = { + DHCP = "ipv4"; + IPv6AcceptRA = true; + }; + linkConfig.RequiredForOnline = "routable"; + }; + }; +} diff --git a/nixos/maintainers/scripts/incus/nix.tpl b/nixos/maintainers/scripts/incus/nix.tpl new file mode 100644 index 000000000000..38c2fc1ebffb --- /dev/null +++ b/nixos/maintainers/scripts/incus/nix.tpl @@ -0,0 +1,12 @@ +{ + lib, + config, + pkgs, + ... +}: + +# WARNING: THIS CONFIGURATION IS AUTOGENERATED AND WILL BE OVERWRITTEN AUTOMATICALLY + +{ + networking.hostName = "{{ container.name }}"; +} diff --git a/nixos/modules/virtualisation/incus-virtual-machine.nix b/nixos/modules/virtualisation/incus-virtual-machine.nix new file mode 100644 index 000000000000..d51e251aaba9 --- /dev/null +++ b/nixos/modules/virtualisation/incus-virtual-machine.nix @@ -0,0 +1,61 @@ +{ + config, + lib, + pkgs, + ... +}: + +let + serialDevice = if pkgs.stdenv.hostPlatform.isx86 then "ttyS0" else "ttyAMA0"; +in +{ + meta = { + maintainers = lib.teams.lxc.members; + }; + + imports = [ + ./lxc-instance-common.nix + + ../profiles/qemu-guest.nix + ]; + + config = { + system.build.qemuImage = import ../../lib/make-disk-image.nix { + inherit pkgs lib config; + + partitionTableType = "efi"; + format = "qcow2-compressed"; + copyChannel = true; + }; + + fileSystems = { + "/" = { + device = "/dev/disk/by-label/nixos"; + autoResize = true; + fsType = "ext4"; + }; + "/boot" = { + device = "/dev/disk/by-label/ESP"; + fsType = "vfat"; + }; + }; + + boot.growPartition = true; + boot.loader.systemd-boot.enable = true; + + # image building needs to know what device to install bootloader on + boot.loader.grub.device = "/dev/vda"; + + boot.kernelParams = [ + "console=tty1" + "console=${serialDevice}" + ]; + + # CPU hotplug + services.udev.extraRules = '' + SUBSYSTEM=="cpu", CONST{arch}=="x86-64", TEST=="online", ATTR{online}=="0", ATTR{online}="1" + ''; + + virtualisation.incus.agent.enable = lib.mkDefault true; + }; +} diff --git a/nixos/modules/virtualisation/lxc-container.nix b/nixos/modules/virtualisation/lxc-container.nix index 95e3083ff9ed..0b528496bb33 100644 --- a/nixos/modules/virtualisation/lxc-container.nix +++ b/nixos/modules/virtualisation/lxc-container.nix @@ -74,7 +74,7 @@ ]; }; - system.build.installBootLoader = pkgs.writeScript "install-lxd-sbin-init.sh" '' + system.build.installBootLoader = pkgs.writeScript "install-lxc-sbin-init.sh" '' #!${pkgs.runtimeShell} ${pkgs.coreutils}/bin/ln -fs "$1/${initScript}" /sbin/init ''; diff --git a/nixos/release.nix b/nixos/release.nix index 2f31973569bf..eeca73ea4c55 100644 --- a/nixos/release.nix +++ b/nixos/release.nix @@ -318,6 +318,101 @@ in rec { ); + # An image that can be imported into incus and used for container creation + incusContainerImage = + forMatchingSystems + [ + "x86_64-linux" + "aarch64-linux" + ] + ( + system: + with import ./.. { inherit system; }; + + hydraJob ( + (import lib/eval-config.nix { + inherit system; + modules = [ + configuration + versionModule + ./maintainers/scripts/incus/incus-container-image.nix + ]; + }).config.system.build.squashfs + ) + ); + + # Metadata for the incus image + incusContainerMeta = + forMatchingSystems + [ + "x86_64-linux" + "aarch64-linux" + ] + ( + system: + + with import ./.. { inherit system; }; + + hydraJob ( + (import lib/eval-config.nix { + inherit system; + modules = [ + configuration + versionModule + ./maintainers/scripts/incus/incus-container-image.nix + ]; + }).config.system.build.metadata + ) + ); + + # An image that can be imported into incus and used for container creation + incusVirtualMachineImage = + forMatchingSystems + [ + "x86_64-linux" + "aarch64-linux" + ] + ( + system: + + with import ./.. { inherit system; }; + + hydraJob ( + (import lib/eval-config.nix { + inherit system; + modules = [ + configuration + versionModule + ./maintainers/scripts/incus/incus-virtual-machine-image.nix + ]; + }).config.system.build.qemuImage + ) + ); + + # Metadata for the incus image + incusVirtualMachineImageMeta = + forMatchingSystems + [ + "x86_64-linux" + "aarch64-linux" + ] + ( + system: + + with import ./.. { inherit system; }; + + hydraJob ( + (import lib/eval-config.nix { + inherit system; + modules = [ + configuration + versionModule + ./maintainers/scripts/incus/incus-virtual-machine-image.nix + ]; + }).config.system.build.metadata + ) + ); + # An image that can be imported into lxd and used for container creation lxdContainerImage = forMatchingSystems [ "x86_64-linux" "aarch64-linux" ] (system: diff --git a/nixos/tests/incus/container.nix b/nixos/tests/incus/container.nix index 10262cf2132b..d2b8037cae70 100644 --- a/nixos/tests/incus/container.nix +++ b/nixos/tests/incus/container.nix @@ -11,8 +11,8 @@ let extra; }; - container-image-metadata = releases.lxdContainerMeta.${pkgs.stdenv.hostPlatform.system}; - container-image-rootfs = releases.lxdContainerImage.${pkgs.stdenv.hostPlatform.system}; + container-image-metadata = releases.incusContainerMeta.${pkgs.stdenv.hostPlatform.system}; + container-image-rootfs = releases.incusContainerImage.${pkgs.stdenv.hostPlatform.system}; in { inherit name; @@ -61,7 +61,7 @@ in machine.succeed("incus admin init --minimal") with subtest("Container image can be imported"): - machine.succeed("incus image import ${container-image-metadata}/*/*.tar.xz ${container-image-rootfs}/*/*.tar.xz --alias nixos") + machine.succeed("incus image import ${container-image-metadata}/*/*.tar.xz ${container-image-rootfs} --alias nixos") with subtest("Container can be launched and managed"): machine.succeed("incus launch nixos container") diff --git a/nixos/tests/incus/incusd-options.nix b/nixos/tests/incus/incusd-options.nix index 7b3a4d726e38..afa1805b9d19 100644 --- a/nixos/tests/incus/incusd-options.nix +++ b/nixos/tests/incus/incusd-options.nix @@ -16,8 +16,8 @@ import ../make-test-python.nix ( }; }; - container-image-metadata = releases.lxdContainerMeta.${pkgs.stdenv.hostPlatform.system}; - container-image-rootfs = releases.lxdContainerImage.${pkgs.stdenv.hostPlatform.system}; + container-image-metadata = releases.incusContainerMeta.${pkgs.stdenv.hostPlatform.system}; + container-image-rootfs = releases.incusContainerImage.${pkgs.stdenv.hostPlatform.system}; in { name = "incusd-options"; @@ -87,7 +87,7 @@ import ../make-test-python.nix ( machine.wait_for_unit("incus-preseed.service") with subtest("Container image can be imported"): - machine.succeed("incus image import ${container-image-metadata}/*/*.tar.xz ${container-image-rootfs}/*/*.tar.xz --alias nixos") + machine.succeed("incus image import ${container-image-metadata}/*/*.tar.xz ${container-image-rootfs} --alias nixos") with subtest("Container can be launched and managed"): machine.succeed("incus launch nixos container") diff --git a/nixos/tests/incus/virtual-machine.nix b/nixos/tests/incus/virtual-machine.nix index 70e54191d330..f5ac4c8eee1f 100644 --- a/nixos/tests/incus/virtual-machine.nix +++ b/nixos/tests/incus/virtual-machine.nix @@ -11,8 +11,8 @@ let }; }; - vm-image-metadata = releases.lxdVirtualMachineImageMeta.${pkgs.stdenv.hostPlatform.system}; - vm-image-disk = releases.lxdVirtualMachineImage.${pkgs.stdenv.hostPlatform.system}; + vm-image-metadata = releases.incusVirtualMachineImageMeta.${pkgs.stdenv.hostPlatform.system}; + vm-image-disk = releases.incusVirtualMachineImage.${pkgs.stdenv.hostPlatform.system}; instance-name = "instance1"; in @@ -64,10 +64,10 @@ in with machine.nested("Waiting for instance to start and be usable"): retry(instance_is_up) - with subtest("lxd-agent is started"): - machine.succeed("incus exec ${instance-name} systemctl is-active lxd-agent") + with subtest("incus-agent is started"): + machine.succeed("incus exec ${instance-name} systemctl is-active incus-agent") - with subtest("lxd-agent has a valid path"): + with subtest("incus-agent has a valid path"): machine.succeed("incus exec ${instance-name} -- bash -c 'true'") with subtest("guest supports cpu hotplug"): From ac18c4d1e99f7308345ea5f5b9a0584331c30362 Mon Sep 17 00:00:00 2001 From: Adam Stephens Date: Sat, 10 Aug 2024 13:03:28 -0400 Subject: [PATCH 3/4] treewide: remove lxc team from lxd packages and modules LXD is not under the LXC project any longer --- nixos/modules/virtualisation/lxc-image-metadata.nix | 4 ++++ nixos/modules/virtualisation/lxc-instance-common.nix | 4 ++++ nixos/modules/virtualisation/lxd-agent.nix | 4 ---- nixos/modules/virtualisation/lxd-virtual-machine.nix | 4 ---- nixos/modules/virtualisation/lxd.nix | 4 ---- nixos/tests/lxd/container.nix | 4 ---- nixos/tests/lxd/nftables.nix | 4 ---- nixos/tests/lxd/preseed.nix | 4 ---- nixos/tests/lxd/ui.nix | 6 +----- nixos/tests/lxd/virtual-machine.nix | 4 ---- pkgs/by-name/lx/lxd-ui/package.nix | 2 +- pkgs/by-name/lx/lxd-unwrapped-lts/package.nix | 2 +- pkgs/development/libraries/dqlite/default.nix | 2 +- pkgs/development/libraries/raft-canonical/default.nix | 2 +- 14 files changed, 13 insertions(+), 37 deletions(-) diff --git a/nixos/modules/virtualisation/lxc-image-metadata.nix b/nixos/modules/virtualisation/lxc-image-metadata.nix index 38d955798f3e..eb14f9dc5fc1 100644 --- a/nixos/modules/virtualisation/lxc-image-metadata.nix +++ b/nixos/modules/virtualisation/lxc-image-metadata.nix @@ -46,6 +46,10 @@ let else { files = []; properties = {}; }; in { + meta = { + maintainers = lib.teams.lxc.members; + }; + options = { virtualisation.lxc = { templates = lib.mkOption { diff --git a/nixos/modules/virtualisation/lxc-instance-common.nix b/nixos/modules/virtualisation/lxc-instance-common.nix index d6a0e05fb1c9..77285e529726 100644 --- a/nixos/modules/virtualisation/lxc-instance-common.nix +++ b/nixos/modules/virtualisation/lxc-instance-common.nix @@ -1,6 +1,10 @@ {lib, ...}: { + meta = { + maintainers = lib.teams.lxc.members; + }; + imports = [ ./lxc-image-metadata.nix diff --git a/nixos/modules/virtualisation/lxd-agent.nix b/nixos/modules/virtualisation/lxd-agent.nix index d31937147848..4bcec117aba9 100644 --- a/nixos/modules/virtualisation/lxd-agent.nix +++ b/nixos/modules/virtualisation/lxd-agent.nix @@ -45,10 +45,6 @@ let chown -R root:root "$PREFIX" ''; in { - meta = { - maintainers = lib.teams.lxc.members; - }; - options = { virtualisation.lxd.agent.enable = lib.mkEnableOption "LXD agent"; }; diff --git a/nixos/modules/virtualisation/lxd-virtual-machine.nix b/nixos/modules/virtualisation/lxd-virtual-machine.nix index 2768e7c25966..138a85899718 100644 --- a/nixos/modules/virtualisation/lxd-virtual-machine.nix +++ b/nixos/modules/virtualisation/lxd-virtual-machine.nix @@ -6,10 +6,6 @@ let then "ttyS0" else "ttyAMA0"; # aarch64 in { - meta = { - maintainers = lib.teams.lxc.members; - }; - imports = [ ./lxc-instance-common.nix diff --git a/nixos/modules/virtualisation/lxd.nix b/nixos/modules/virtualisation/lxd.nix index 277c09eb0170..bdcd60a0560f 100644 --- a/nixos/modules/virtualisation/lxd.nix +++ b/nixos/modules/virtualisation/lxd.nix @@ -6,10 +6,6 @@ let cfg = config.virtualisation.lxd; preseedFormat = pkgs.formats.yaml {}; in { - meta = { - maintainers = lib.teams.lxc.members; - }; - imports = [ (lib.mkRemovedOptionModule [ "virtualisation" "lxd" "zfsPackage" ] "Override zfs in an overlay instead to override it globally") ]; diff --git a/nixos/tests/lxd/container.nix b/nixos/tests/lxd/container.nix index ef9c3f4bbee7..26dcad2f97a7 100644 --- a/nixos/tests/lxd/container.nix +++ b/nixos/tests/lxd/container.nix @@ -18,10 +18,6 @@ let in { name = "lxd-container"; - meta = { - maintainers = lib.teams.lxc.members; - }; - nodes.machine = { lib, ... }: { virtualisation = { diskSize = 6144; diff --git a/nixos/tests/lxd/nftables.nix b/nixos/tests/lxd/nftables.nix index e6ce4089d719..d419f9b66af1 100644 --- a/nixos/tests/lxd/nftables.nix +++ b/nixos/tests/lxd/nftables.nix @@ -8,10 +8,6 @@ import ../make-test-python.nix ({ pkgs, lib, ...} : { name = "lxd-nftables"; - meta = { - maintainers = lib.teams.lxc.members; - }; - nodes.machine = { lib, ... }: { virtualisation = { lxd.enable = true; diff --git a/nixos/tests/lxd/preseed.nix b/nixos/tests/lxd/preseed.nix index fb80dcf3893e..2e0ff33d521f 100644 --- a/nixos/tests/lxd/preseed.nix +++ b/nixos/tests/lxd/preseed.nix @@ -3,10 +3,6 @@ import ../make-test-python.nix ({ pkgs, lib, ... } : { name = "lxd-preseed"; - meta = { - maintainers = lib.teams.lxc.members; - }; - nodes.machine = { lib, ... }: { virtualisation = { diskSize = 4096; diff --git a/nixos/tests/lxd/ui.nix b/nixos/tests/lxd/ui.nix index c442f44ab81c..f96c3d74d93c 100644 --- a/nixos/tests/lxd/ui.nix +++ b/nixos/tests/lxd/ui.nix @@ -1,10 +1,6 @@ -import ../make-test-python.nix ({ pkgs, lib, ... }: { +import ../make-test-python.nix ({ pkgs, ... }: { name = "lxd-ui"; - meta = { - maintainers = lib.teams.lxc.members; - }; - nodes.machine = { lib, ... }: { virtualisation = { lxd.enable = true; diff --git a/nixos/tests/lxd/virtual-machine.nix b/nixos/tests/lxd/virtual-machine.nix index 2a9dd8fcdbf6..14c5e8a82aa8 100644 --- a/nixos/tests/lxd/virtual-machine.nix +++ b/nixos/tests/lxd/virtual-machine.nix @@ -18,10 +18,6 @@ let in { name = "lxd-virtual-machine"; - meta = { - maintainers = lib.teams.lxc.members; - }; - nodes.machine = {lib, ...}: { virtualisation = { diskSize = 4096; diff --git a/pkgs/by-name/lx/lxd-ui/package.nix b/pkgs/by-name/lx/lxd-ui/package.nix index 70b85e236488..9b613325c328 100644 --- a/pkgs/by-name/lx/lxd-ui/package.nix +++ b/pkgs/by-name/lx/lxd-ui/package.nix @@ -68,7 +68,7 @@ stdenv.mkDerivation rec { homepage = "https://github.com/canonical/lxd-ui"; changelog = "https://github.com/canonical/lxd-ui/releases/tag/${version}"; license = lib.licenses.gpl3; - maintainers = lib.teams.lxc.members; + maintainers = [ ]; platforms = lib.platforms.linux; }; } diff --git a/pkgs/by-name/lx/lxd-unwrapped-lts/package.nix b/pkgs/by-name/lx/lxd-unwrapped-lts/package.nix index 6b812bb752ba..5b3f229d2fe0 100644 --- a/pkgs/by-name/lx/lxd-unwrapped-lts/package.nix +++ b/pkgs/by-name/lx/lxd-unwrapped-lts/package.nix @@ -108,7 +108,7 @@ buildGoModule rec { asl20 agpl3Plus ]; - maintainers = teams.lxc.members; + maintainers = [ ]; platforms = platforms.linux; }; } diff --git a/pkgs/development/libraries/dqlite/default.nix b/pkgs/development/libraries/dqlite/default.nix index 79226377bac3..4ef75a9ee469 100644 --- a/pkgs/development/libraries/dqlite/default.nix +++ b/pkgs/development/libraries/dqlite/default.nix @@ -37,7 +37,7 @@ stdenv.mkDerivation rec { ''; homepage = "https://dqlite.io/"; license = licenses.asl20; - maintainers = teams.lxc.members; + maintainers = [ ]; platforms = platforms.linux; }; } diff --git a/pkgs/development/libraries/raft-canonical/default.nix b/pkgs/development/libraries/raft-canonical/default.nix index 65f4b899d747..4d60456d8ab2 100644 --- a/pkgs/development/libraries/raft-canonical/default.nix +++ b/pkgs/development/libraries/raft-canonical/default.nix @@ -50,6 +50,6 @@ stdenv.mkDerivation rec { homepage = "https://github.com/canonical/raft"; license = licenses.asl20; platforms = platforms.linux; - maintainers = teams.lxc.members; + maintainers = [ ]; }; } From e68a336a3182687173328b54d73cd08f92f60301 Mon Sep 17 00:00:00 2001 From: Adam Stephens Date: Sat, 10 Aug 2024 13:05:24 -0400 Subject: [PATCH 4/4] CODEOWNERS: remove lxd paths for adamcstephens --- .github/CODEOWNERS | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 4c00f81d7a3d..5122e40e62e6 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -369,16 +369,13 @@ nixos/modules/services/web-apps/pretalx.nix @mweinelt nixos/tests/web-apps/pretix.nix @mweinelt nixos/tests/web-apps/pretalx.nix @mweinelt -# incus/lxc/lxd -nixos/maintainers/scripts/lxd/ @adamcstephens +# incus/lxc +nixos/maintainers/scripts/incus/ @adamcstephens nixos/modules/virtualisation/incus.nix @adamcstephens nixos/modules/virtualisation/lxc* @adamcstephens -nixos/modules/virtualisation/lxd* @adamcstephens nixos/tests/incus/ @adamcstephens -nixos/tests/lxd/ @adamcstephens pkgs/by-name/in/incus/ @adamcstephens pkgs/by-name/lx/lxc* @adamcstephens -pkgs/by-name/lx/lxd* @adamcstephens # ExpidusOS, Flutter /pkgs/development/compilers/flutter @RossComputerGuy