Python docs: remove name attribute

The `name` attribute is filled in when `pname` and `version` are specified.
See https://github.com/NixOS/nixpkgs/pull/31173
This commit is contained in:
Frederik Rietdijk 2018-01-16 17:59:30 +01:00
parent f6ee29dda2
commit 2ea3db2830

View File

@ -191,7 +191,6 @@ building Python libraries is `buildPythonPackage`. Let's see how we can build th
toolz = buildPythonPackage rec { toolz = buildPythonPackage rec {
pname = "toolz"; pname = "toolz";
version = "0.7.4"; version = "0.7.4";
name = "${pname}-${version}";
src = fetchPypi { src = fetchPypi {
inherit pname version; inherit pname version;
@ -237,7 +236,6 @@ with import <nixpkgs> {};
my_toolz = python35.pkgs.buildPythonPackage rec { my_toolz = python35.pkgs.buildPythonPackage rec {
pname = "toolz"; pname = "toolz";
version = "0.7.4"; version = "0.7.4";
name = "${pname}-${version}";
src = python35.pkgs.fetchPypi { src = python35.pkgs.fetchPypi {
inherit pname version; inherit pname version;
@ -283,15 +281,15 @@ order to build [`datashape`](https://github.com/blaze/datashape).
{ # ... { # ...
datashape = buildPythonPackage rec { datashape = buildPythonPackage rec {
name = "datashape-${version}"; pname = "datashape";
version = "0.4.7"; version = "0.4.7";
src = pkgs.fetchurl { src = fetchPypi {
url = "mirror://pypi/D/DataShape/${name}.tar.gz"; inherit pname version;
sha256 = "14b2ef766d4c9652ab813182e866f493475e65e558bed0822e38bf07bba1a278"; sha256 = "14b2ef766d4c9652ab813182e866f493475e65e558bed0822e38bf07bba1a278";
}; };
buildInputs = with self; [ pytest ]; checkInputs = with self; [ pytest ];
propagatedBuildInputs = with self; [ numpy multipledispatch dateutil ]; propagatedBuildInputs = with self; [ numpy multipledispatch dateutil ];
meta = { meta = {
@ -318,10 +316,11 @@ when building the bindings and are therefore added as `buildInputs`.
{ # ... { # ...
lxml = buildPythonPackage rec { lxml = buildPythonPackage rec {
name = "lxml-3.4.4"; pname = "lxml";
version = "3.4.4";
src = pkgs.fetchurl { src = fetchPypi {
url = "mirror://pypi/l/lxml/${name}.tar.gz"; inherit pname version;
sha256 = "16a0fa97hym9ysdk3rmqz32xdjqmy4w34ld3rm3jf5viqjx65lxk"; sha256 = "16a0fa97hym9ysdk3rmqz32xdjqmy4w34ld3rm3jf5viqjx65lxk";
}; };
@ -351,11 +350,11 @@ and `CFLAGS`.
{ # ... { # ...
pyfftw = buildPythonPackage rec { pyfftw = buildPythonPackage rec {
name = "pyfftw-${version}"; pname = "pyFFTW";
version = "0.9.2"; version = "0.9.2";
src = pkgs.fetchurl { src = fetchPypi {
url = "mirror://pypi/p/pyFFTW/pyFFTW-${version}.tar.gz"; inherit pname version;
sha256 = "f6bbb6afa93085409ab24885a1a3cdb8909f095a142f4d49e346f2bd1b789074"; sha256 = "f6bbb6afa93085409ab24885a1a3cdb8909f095a142f4d49e346f2bd1b789074";
}; };
@ -440,11 +439,11 @@ We first create a function that builds `toolz` in `~/path/to/toolz/release.nix`
{ pkgs, buildPythonPackage }: { pkgs, buildPythonPackage }:
buildPythonPackage rec { buildPythonPackage rec {
name = "toolz-${version}"; pname = "toolz";
version = "0.7.4"; version = "0.7.4";
src = pkgs.fetchurl { src = fetchPypi {
url = "mirror://pypi/t/toolz/toolz-${version}.tar.gz"; inherit pname version;
sha256 = "43c2c9e5e7a16b6c88ba3088a9bfc82f7db8e13378be7c78d6c14a5f8ed05afd"; sha256 = "43c2c9e5e7a16b6c88ba3088a9bfc82f7db8e13378be7c78d6c14a5f8ed05afd";
}; };
@ -549,25 +548,31 @@ The `buildPythonPackage` function is implemented in
The following is an example: The following is an example:
```nix ```nix
{ # ...
twisted = buildPythonPackage { buildPythonPackage rec {
name = "twisted-8.1.0"; version = "3.3.1";
pname = "pytest";
src = pkgs.fetchurl { preCheck = ''
url = http://tmrc.mit.edu/mirror/twisted/Twisted/8.1/Twisted-8.1.0.tar.bz2; # don't test bash builtins
sha256 = "0q25zbr4xzknaghha72mq57kh53qw1bf8csgp63pm9sfi72qhirl"; rm testing/test_argcomplete.py
}; '';
propagatedBuildInputs = [ self.ZopeInterface ]; src = fetchPypi {
inherit pname version;
sha256 = "cf8436dc59d8695346fcd3ab296de46425ecab00d64096cebe79fb51ecb2eb93";
};
meta = { checkInputs = [ hypothesis ];
homepage = http://twistedmatrix.com/; buildInputs = [ setuptools_scm ];
description = "Twisted, an event-driven networking engine written in Python"; propagatedBuildInputs = [ attrs py setuptools six pluggy ];
license = stdenv.lib.licenses.mit;
}; meta = with stdenv.lib; {
maintainers = with maintainers; [ domenkozar lovek323 madjar lsix ];
description = "Framework for writing tests";
}; };
} }
``` ```
The `buildPythonPackage` mainly does four things: The `buildPythonPackage` mainly does four things:
@ -623,7 +628,6 @@ with import <nixpkgs> {};
packageOverrides = self: super: { packageOverrides = self: super: {
pandas = super.pandas.overridePythonAttrs(old: rec { pandas = super.pandas.overridePythonAttrs(old: rec {
version = "0.19.1"; version = "0.19.1";
name = "pandas-${version}";
src = super.fetchPypi { src = super.fetchPypi {
pname = "pandas"; pname = "pandas";
inherit version; inherit version;