Always use bundled taglib for now.

This commit is contained in:
casey langen 2020-06-27 13:34:52 -07:00
parent 1fe0c38b84
commit a34ef22040

View File

@ -125,31 +125,31 @@ else()
add_dependencies(musikcube ffmpegdecoder) add_dependencies(musikcube ffmpegdecoder)
endif() endif()
# some versions of Ubuntu ship with a taglib binary that is missing some # we use a bundled version of taglib because the latest release is from 2016,
# symbols we depend on. for these distros, we compile taglib ourselves # and the upstream git repo is hundreds of commits ahead and has a number of
# and link against it statically. # important bugfixes.
set(USE_BUNDLED_TAGLIB "false") set(USE_BUNDLED_TAGLIB "true")
if (CMAKE_SYSTEM_NAME MATCHES "FreeBSD" OR CMAKE_SYSTEM_NAME MATCHES "Darwin") #if (CMAKE_SYSTEM_NAME MATCHES "FreeBSD" OR CMAKE_SYSTEM_NAME MATCHES "Darwin")
set(USE_BUNDLED_TAGLIB "false") # set(USE_BUNDLED_TAGLIB "false")
elseif (CMAKE_SYSTEM_NAME MATCHES "Linux") #elseif (CMAKE_SYSTEM_NAME MATCHES "Linux")
find_program(LSB_RELEASE lsb_release) # find_program(LSB_RELEASE lsb_release)
#
if(NOT ${LSB_RELEASE} MATCHES "LSB_RELEASE-NOTFOUND") # if(NOT ${LSB_RELEASE} MATCHES "LSB_RELEASE-NOTFOUND")
execute_process( # execute_process(
COMMAND ${LSB_RELEASE} -cs # COMMAND ${LSB_RELEASE} -cs
OUTPUT_VARIABLE DISTRO # OUTPUT_VARIABLE DISTRO
OUTPUT_STRIP_TRAILING_WHITESPACE # OUTPUT_STRIP_TRAILING_WHITESPACE
) # )
#
message(STATUS "[taglib] detected distro = ${DISTRO}") # message(STATUS "[taglib] detected distro = ${DISTRO}")
#
if (DISTRO MATCHES "xenial" OR DISTRO MATCHES "zesty" OR DISTRO MATCHES "artful") # if (DISTRO MATCHES "xenial" OR DISTRO MATCHES "zesty" OR DISTRO MATCHES "artful")
set(USE_BUNDLED_TAGLIB "true") # set(USE_BUNDLED_TAGLIB "true")
endif() # endif()
endif() # endif()
endif() #endif()
message(STATUS "[taglib] using bundled taglib = ${USE_BUNDLED_TAGLIB}") message(STATUS "[taglib] using bundled taglib = ${USE_BUNDLED_TAGLIB}")