From ee30b53d4a10034b2ff398b05964e7cae66a71d8 Mon Sep 17 00:00:00 2001 From: casey langen Date: Wed, 3 May 2023 16:08:24 -0700 Subject: [PATCH 1/2] Update CHANGELOG --- CHANGELOG.txt | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/CHANGELOG.txt b/CHANGELOG.txt index 683f3fba7..6478d2670 100644 --- a/CHANGELOG.txt +++ b/CHANGELOG.txt @@ -1,3 +1,9 @@ +3.0.1 + +* fixed a bug where re-arranging the play queue may cause unnecessary i/o + +-------------------------------------------------------------------------------- + 3.0.0 * fixed non-latin character parsing in Windows builds From d81f82559abd9209f247e1e23826a597333bd586 Mon Sep 17 00:00:00 2001 From: casey langen Date: Wed, 3 May 2023 21:51:08 -0700 Subject: [PATCH 2/2] Fixed issue where we were double-utf8-encoding album artist (and potentially other metadata) values in some cases. --- CHANGELOG.txt | 4 +++- src/plugins/taglib_plugin/TaglibMetadataReader.cpp | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.txt b/CHANGELOG.txt index 6478d2670..d99e0b220 100644 --- a/CHANGELOG.txt +++ b/CHANGELOG.txt @@ -1,6 +1,8 @@ 3.0.1 -* fixed a bug where re-arranging the play queue may cause unnecessary i/o +* fixed a bug where album artist (and potentially other) metadata values were + being double encoded. +* fixed a bug where re-arranging the play queue may cause unnecessary i/o. -------------------------------------------------------------------------------- diff --git a/src/plugins/taglib_plugin/TaglibMetadataReader.cpp b/src/plugins/taglib_plugin/TaglibMetadataReader.cpp index a59ad8a0a..d77dd985e 100644 --- a/src/plugins/taglib_plugin/TaglibMetadataReader.cpp +++ b/src/plugins/taglib_plugin/TaglibMetadataReader.cpp @@ -375,7 +375,7 @@ void TaglibMetadataReader::ExtractValueForKey( if (map.contains(inputKey.c_str())) { TagLib::StringList value = map[inputKey.c_str()]; if (value.size()) { - this->SetTagValue(outputKey.c_str(), value[0].to8Bit(true), target); + this->SetTagValue(outputKey.c_str(), value[0], target); } } }