From 6520e082c1fc04b8ddf7a0e20c55f4eb3356a14a Mon Sep 17 00:00:00 2001 From: casey langen Date: Sun, 1 Nov 2020 10:53:28 -0800 Subject: [PATCH] Fixed bug where DirectoryLayout wasn't properly consuming keys, leading to the callback firing multiple times. --- CHANGELOG.txt | 2 ++ src/musikcube/app/layout/DirectoryLayout.cpp | 2 ++ 2 files changed, 4 insertions(+) diff --git a/CHANGELOG.txt b/CHANGELOG.txt index 1984fee31..158b3a2e1 100644 --- a/CHANGELOG.txt +++ b/CHANGELOG.txt @@ -40,6 +40,8 @@ * fixed some weird edge-casey command bar focus issues. * finally renamed `src/core` to `src/musikcore` * added a ja_JP locale (trackiss) +* fixed a bug where on-demand mp3 transcoding wasn't working properly. (other + formats were fine) * rearranged the settings window to ensure everything fits properly in an 80x24 terminal * fixed some bugs in `MessageQueue` by now requiring explicit `IMessageTarget` diff --git a/src/musikcube/app/layout/DirectoryLayout.cpp b/src/musikcube/app/layout/DirectoryLayout.cpp index f8fc54993..cbdb6e7fa 100644 --- a/src/musikcube/app/layout/DirectoryLayout.cpp +++ b/src/musikcube/app/layout/DirectoryLayout.cpp @@ -247,6 +247,7 @@ bool DirectoryLayout::KeyPress(const std::string& key) { this->Requery(); } + return true; } else if (Hotkeys::Is(Hotkeys::ContextMenu, key)) { if (this->GetFocus() == this->directoryList) { @@ -265,6 +266,7 @@ bool DirectoryLayout::KeyPress(const std::string& key) { index = (index == ListWindow::NO_SELECTION) ? 0 : index; this->playback.Play(*tracks.get(), index); } + return true; } else if (Hotkeys::Is(Hotkeys::ViewRefresh, key)) { this->queryHash = 0;