A couple cross-compiler compatibility fixes: (1) no virtual destructor

in SDK interfaces, and (2) no method overloading.
This commit is contained in:
casey langen 2017-04-01 12:16:15 -07:00
parent 68b2d5c1d1
commit 6241774454
5 changed files with 4 additions and 8 deletions

View File

@ -155,7 +155,7 @@ void CddaIndexerSource::Scan(musik::core::sdk::IIndexerWriter* indexer) {
discIds.clear();
}
void CddaIndexerSource::Scan(
void CddaIndexerSource::ScanTrack(
IIndexerWriter* indexer,
IRetainedTrackWriter* track,
const char* externalId)

View File

@ -54,7 +54,7 @@ class CddaIndexerSource :
virtual void Scan(musik::core::sdk::IIndexerWriter* indexer);
virtual void Scan(
virtual void ScanTrack(
musik::core::sdk::IIndexerWriter* indexer,
musik::core::sdk::IRetainedTrackWriter* track,
const char* externalId);

View File

@ -446,7 +446,7 @@ void Indexer::SyncSource(IIndexerSource* source) {
while (tracks.Step() == db::Row) {
TrackPtr track(new IndexerTrack(tracks.ColumnInt(0)));
track->SetValue(constants::Track::FILENAME, tracks.ColumnText(1));
source->Scan(this, new RetainedTrackWriter(track), tracks.ColumnText(2));
source->ScanTrack(this, new RetainedTrackWriter(track), tracks.ColumnText(2));
}
}

View File

@ -40,10 +40,6 @@ namespace musik { namespace core { namespace sdk {
class IBufferProvider {
public:
virtual ~IBufferProvider() { }
/* the output calls this interface to let the provider know
it's done with the Buffer, so it can be recycled or released */
virtual void OnBufferProcessed(IBuffer *buffer) = 0;
};

View File

@ -49,7 +49,7 @@ namespace musik { namespace core { namespace sdk {
virtual void Scan(IIndexerWriter* indexer) = 0;
virtual void Scan(
virtual void ScanTrack(
IIndexerWriter* indexer,
IRetainedTrackWriter* track,
const char* externalId) = 0;