From 20241045c476fa372216df379c2a6fc90fb4b7e6 Mon Sep 17 00:00:00 2001 From: casey langen Date: Sat, 8 Jul 2017 00:54:01 -0700 Subject: [PATCH] Update README.md --- src/musikdroid/README.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/musikdroid/README.md b/src/musikdroid/README.md index 47119e264..be37de8c6 100644 --- a/src/musikdroid/README.md +++ b/src/musikdroid/README.md @@ -2,18 +2,18 @@ `musikdroid` is an android app that is used to stream music from, or remote control, existing `musikbox` installations (windows, macos, or linux clients). -*disclaimer*: although `musikdroid` is generally very stable and performant, it does **not** employ best practices as prescribed by the android community at large. there is no `model-view-presenter`, and no `dependency injection`. it does not use `architecture compoments` (except for `Room`). it uses `RxJava`, but sparingly; only where it makes sense. instead, in general, it makes heavy use of lower-level android apis. +*disclaimer*: although `musikdroid` is generally stable and performant, it does **not** employ best practices as prescribed by the android community at large. no model-view-presenter, dependency injection, or architecture compoments (except for `Room`). it uses `RxJava`, but sparingly. -`musikdroid` has, however, recently been converted to `kotlin`. +`musikdroid` is written in `kotlin` # building -because `musikdroid` is not available in the Google Play store, it currently uses [fabric.io](https://fabric.io) for crash reporting. this makes it slightly difficult to build out of the box, because the project's API keys are not checked in. if you are not a member of the dev team, but still want to play around with the code, you can do the following: +because `musikdroid` is not available in the Google Play store, it uses [fabric.io](https://fabric.io) for crash reporting. this makes it slightly difficult to build out of the box, because the project's API keys are not checked in. if you are not a member of the dev team, but still want to play around with the code, you can do the following: 1. remove `Fabric.with(this, Crashlytics())` from `Application.kt` 2. remove `apply plugin: 'io.fabric'` from `app/build.gradle` -this should allow you to build and test locally without special keys. in the future this will be simplified, and fabric will only be included in release build flavors. +this should allow you to build and test locally without special keys. TODO: simplify # attribution