Hanno Becker f6d6e30820 Fix incomplete assertion in ssl_write_handshake_msg()
ssl_write_handshake_msg() includes the assertion that
`ssl->handshake != NULL` when handling a record which is
(a) a handshake message, and NOT
(b) a HelloRequest.
However, it later calls `ssl_append_flight()` for any
record different from a HelloRequest handshake record,
that is, records satisfying !(a) || !(b), instead of
(a) && !(b) as covered by the assertion (specifically,
CCS or Alert records).

Since `ssl_append_flight()` assumes that `ssl->handshake != NULL`,
this rightfully triggers static analyzer warnings.

This commit expands the scope of the assertion to check
that `ssl->handshake != NULL` for any record which is not
a HelloRequest.
2018-11-07 11:57:51 +00:00
..
2018-08-13 13:49:52 +03:00
2018-05-25 14:54:14 +01:00
2017-07-27 21:44:33 +01:00
2018-06-18 10:30:30 +02:00
2018-07-23 18:18:32 +01:00
2018-07-23 18:18:35 +01:00
2017-09-06 17:51:14 +03:00
2018-10-16 10:41:31 +02:00
2018-05-15 09:21:57 +01:00
2018-07-24 16:43:20 +01:00
2015-09-04 14:21:07 +02:00
2018-10-16 10:41:31 +02:00
2018-05-25 14:54:14 +01:00
2015-09-04 14:21:07 +02:00
2017-10-29 17:53:52 +02:00
2018-10-16 11:27:23 +02:00