Hanno Becker
f6d6e30820
Fix incomplete assertion in ssl_write_handshake_msg()
...
ssl_write_handshake_msg() includes the assertion that
`ssl->handshake != NULL` when handling a record which is
(a) a handshake message, and NOT
(b) a HelloRequest.
However, it later calls `ssl_append_flight()` for any
record different from a HelloRequest handshake record,
that is, records satisfying !(a) || !(b), instead of
(a) && !(b) as covered by the assertion (specifically,
CCS or Alert records).
Since `ssl_append_flight()` assumes that `ssl->handshake != NULL`,
this rightfully triggers static analyzer warnings.
This commit expands the scope of the assertion to check
that `ssl->handshake != NULL` for any record which is not
a HelloRequest.
2018-11-07 11:57:51 +00:00
..
2015-06-25 10:59:56 +02:00
2018-06-17 17:34:55 +01:00
2018-04-05 15:37:38 +02:00
2018-04-17 10:00:21 -05:00
2018-08-13 13:49:52 +03:00
2018-04-17 10:00:21 -05:00
2018-05-25 14:54:14 +01:00
2017-02-15 23:31:07 +02:00
2018-05-04 14:39:24 +01:00
2018-04-17 10:00:21 -05:00
2018-04-17 10:00:21 -05:00
2018-07-30 11:29:26 +03:00
2017-07-27 21:44:33 +01:00
2018-06-07 11:54:17 +02:00
2018-06-18 10:30:30 +02:00
2018-07-23 18:18:32 +01:00
2018-07-23 18:18:35 +01:00
2018-06-27 10:51:47 +01:00
2018-09-06 19:10:26 +01:00
2018-08-21 17:55:46 +03:00
2017-09-06 17:51:14 +03:00
2018-04-17 10:00:21 -05:00
2018-04-17 10:00:21 -05:00
2018-10-22 09:56:53 +02:00
2018-10-16 10:41:31 +02:00
2018-05-15 09:21:57 +01:00
2018-04-04 09:18:27 +02:00
2018-10-26 15:09:35 +01:00
2018-07-24 17:20:17 +01:00
2018-04-17 10:00:21 -05:00
2018-10-27 18:36:28 +01:00
2018-04-17 10:00:21 -05:00
2018-04-17 10:00:21 -05:00
2018-07-23 10:34:47 -07:00
2018-04-17 10:00:21 -05:00
2018-08-31 15:59:10 +01:00
2018-04-17 10:00:21 -05:00
2018-04-17 10:00:21 -05:00
2018-07-05 10:47:00 +02:00
2018-01-22 11:54:42 +01:00
2018-04-17 10:00:21 -05:00
2018-06-12 16:56:04 +01:00
2018-07-24 17:20:17 +01:00
2018-07-24 16:43:20 +01:00
2018-02-08 17:18:15 +08:00
2015-09-04 14:21:07 +02:00
2018-04-17 10:00:21 -05:00
2018-10-15 15:27:49 +02:00
2018-10-16 10:41:31 +02:00
2018-05-25 14:54:14 +01:00
2015-09-04 14:21:07 +02:00
2018-04-17 10:00:21 -05:00
2018-07-11 15:16:53 +02:00
2017-08-23 16:17:27 +01:00
2018-09-06 12:09:56 +01:00
2018-06-13 09:17:59 +01:00
2018-06-07 11:54:17 +02:00
2018-04-17 10:00:21 -05:00
2018-01-03 09:27:40 +00:00
2018-09-27 18:23:08 +01:00
2018-07-05 10:47:00 +02:00
2018-07-05 10:47:00 +02:00
2018-07-05 10:47:00 +02:00
2017-10-29 17:53:52 +02:00
2018-08-10 10:59:53 +01:00
2018-10-16 10:28:17 +02:00
2018-04-17 10:00:21 -05:00
2018-08-28 10:13:29 +01:00
2018-08-21 17:48:52 +01:00
2018-11-07 11:57:51 +00:00
2018-09-06 12:09:56 +01:00
2018-11-04 18:51:36 +00:00
2018-09-11 12:39:14 +02:00
2016-11-04 23:05:56 +01:00
2015-10-21 12:50:45 +02:00
2018-04-17 10:00:21 -05:00
2018-10-16 11:27:23 +02:00
2018-06-28 12:09:15 +01:00
2018-09-05 15:06:19 +01:00
2018-04-17 10:00:21 -05:00
2018-04-17 10:00:21 -05:00
2018-04-17 10:00:21 -05:00