mirror/mbedtls
1
0
Fork 0
mirror of https://github.com/Mbed-TLS/mbedtls.git synced 2025-02-11 00:40:05 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
mbedtls/library
History
Andre Goddard Rosa 3711734a0a Add invalid padding_len check in get_pkcs_padding 
When trying to decrypt data with an invalid key, we found that `mbedtls`
returned `0x6200` (`-25088`), which means "_CIPHER - Input data contains
invalid padding and is rejected_" from `mbedtls_cipher_finish`, but it also
set the output len as `18446744073709551516`.

In case we detect an error with padding, we leave the output len zero'ed
and return `MBEDTLS_ERR_CIPHER_INVALID_PADDING`.

Here's a reference for the way `openssl` checks the padding length:
  - 1848c561ec/crypto/evp/evp_enc.c (L1023)
  - b554eef43b

So add a check ensuring output is set to the least-harmful value in the
error cases.

With the robustness fix:
`PASSED (125 suites, 26644 tests run)`

Without the robustness fix:
`FAILED (125 suites, 26644 tests run)`

Signed-off-by: Andre Goddard Rosa <andre.goddard@gmail.com>
Signed-off-by: Andre Goddard Rosa <agoddardrosa@roku.com>
2024-05-13 09:27:57 -05:00
..
.gitignore
Revert "Autogenerated files for 3.6.0"
2024-03-27 17:36:15 +00:00
aes.c
Use optimised counter increment in AES-CTR and CTR-DRBG
2024-01-15 11:45:01 +00:00
aesce.c
Fix remaining warnings from -Wshorten-64-to-32
2024-02-13 13:41:16 +00:00
aesce.h
Merge remote-tracking branch 'origin/development' into msft-aarch64
2023-11-30 11:01:50 +00:00
aesni.c
Disable automatic setting of clang target flags on old clang
2023-12-19 13:11:47 +00:00
aesni.h
Merge pull request #8124 from yanrayw/support_cipher_encrypt_only
2023-11-23 17:43:00 +00:00
alignment.h
Pacify check-names
2024-02-06 15:00:58 +00:00
aria.c
aria: remove leftover in comments
2024-01-30 16:28:09 +01:00
asn1parse.c
pem: do not parse ASN1 data after decryption (removes ASN1 dependency)
2024-02-16 15:26:12 +01:00
asn1write.c
asn1: use the new symbol to guard dependencies of ECDSA conversion functions
2024-01-24 16:26:35 +01:00
base64_internal.h
Header updates
2023-11-03 12:21:36 +00:00
base64.c
Use size_t cast for pointer subtractions
2023-11-21 17:09:46 +00:00
bignum_core.c
Fix code style
2024-03-11 10:39:57 +00:00
bignum_core.h
Remove volatile from declaration
2024-03-11 10:03:05 +00:00
bignum_mod_raw_invasive.h
Header updates
2023-11-03 12:21:36 +00:00
bignum_mod_raw.c
Header updates
2023-11-03 12:21:36 +00:00
bignum_mod_raw.h
Header updates
2023-11-03 12:21:36 +00:00
bignum_mod.c
Header updates
2023-11-03 12:21:36 +00:00
bignum_mod.h
Header updates
2023-11-03 12:21:36 +00:00
bignum.c
Fix IAR warning
2024-03-11 15:28:48 +00:00
block_cipher_internal.h
block_cipher: add encrypt()
2023-11-10 12:14:53 +01:00
block_cipher.c
psa: add key_type as input parameter of psa_can_do_cipher()
2023-12-28 18:33:17 +01:00
bn_mul.h
Header updates
2023-11-03 12:21:36 +00:00
camellia.c
Merge remote-tracking branch 'origin/development' into support_cipher_encrypt_only
2023-11-23 10:31:26 +08:00
ccm.c
Merge pull request #8632 from valeriosetti/issue8598
2024-01-08 08:07:53 +00:00
chacha20.c
Header updates
2023-11-03 12:21:36 +00:00
chachapoly.c
Header updates
2023-11-03 12:21:36 +00:00
check_crypto_config.h
Header updates
2023-11-03 12:21:36 +00:00
cipher_wrap.c
cipher_wrap: fix guards for some CCM/GCM functions
2024-01-02 17:20:58 +01:00
cipher_wrap.h
Merge remote-tracking branch 'origin/development' into support_cipher_encrypt_only
2023-11-23 10:31:26 +08:00
cipher.c
Add invalid padding_len check in get_pkcs_padding
2024-05-13 09:27:57 -05:00
cmac.c
Merge branch 'development' into 'development-restricted'
2024-03-19 22:24:40 +00:00
CMakeLists.txt
Merge pull request #8874 from stevenwdv/development
2024-03-29 13:59:36 +00:00
common.h
Fix comment typo
2024-01-23 10:05:08 +00:00
constant_time_impl.h
Merge pull request #8515 from mschulz-at-hilscher/fixes/pragma-error-gcc452
2023-11-27 11:28:30 +00:00
constant_time_internal.h
Header updates
2023-11-03 12:21:36 +00:00
constant_time.c
Remove unused code
2023-12-01 13:53:45 +00:00
ctr_drbg.c
Fix error in ctr_drbg
2024-01-16 17:28:25 +00:00
ctr.h
Add header guards
2024-01-17 11:06:31 +00:00
debug_internal.h
debug: move internal functions declarations to an internal header file
2024-01-18 15:30:46 +01:00
debug.c
debug: move internal functions declarations to an internal header file
2024-01-18 15:30:46 +01:00
des.c
Header updates
2023-11-03 12:21:36 +00:00
dhm.c
Use MBEDTLS_GET_UINTxx_BE macro
2023-11-21 17:09:46 +00:00
ecdh.c
echd: Added mbedtls_ecdh_get_grp_id getter.
2024-02-29 13:31:34 +00:00
ecdsa.c
Header updates
2023-11-03 12:21:36 +00:00
ecjpake.c
Use size_t cast for pointer subtractions
2023-11-21 17:09:46 +00:00
ecp_curves_new.c
lib: remove NULL pointer checks performed with MBEDTLS_INTERNAL_VALIDATE[_RET]
2024-01-29 12:00:15 +01:00
ecp_curves.c
Merge pull request #8665 from ivq/reduce_static_mem
2024-02-07 23:26:27 +00:00
ecp_internal_alt.h
Header updates
2023-11-03 12:21:36 +00:00
ecp_invasive.h
Header updates
2023-11-03 12:21:36 +00:00
ecp.c
mbedtls_ecp_write_key_ext(): make key const
2024-02-28 14:18:28 +01:00
entropy_poll.c
Fixed issue of redefinition warning messages for _GNU_SOURCE
2024-05-02 14:27:44 +05:30
entropy_poll.h
Header updates
2023-11-03 12:21:36 +00:00
entropy.c
Header updates
2023-11-03 12:21:36 +00:00
gcm.c
Check gcc version
2024-03-13 09:55:33 +00:00
hkdf.c
Header updates
2023-11-03 12:21:36 +00:00
hmac_drbg.c
Header updates
2023-11-03 12:21:36 +00:00
lmots.c
Use standard byte conversion fns in lms
2023-11-21 17:09:46 +00:00
lmots.h
Use standard byte conversion fns in lms
2023-11-21 17:09:46 +00:00
lms.c
Fix remaining warnings from -Wshorten-64-to-32
2024-02-13 13:41:16 +00:00
Makefile
Revert "Autogenerated files for 3.6.0"
2024-03-27 17:36:15 +00:00
md5.c
Header updates
2023-11-03 12:21:36 +00:00
md_psa.h
md: move PSA conversion functions from md_psa.h to psa_util.h
2024-01-02 13:26:04 +01:00
md_wrap.h
Header updates
2023-11-03 12:21:36 +00:00
md.c
md: fix guards for mbedtls_md_error_from_psa()
2024-05-02 18:18:45 +02:00
memory_buffer_alloc.c
Header updates
2023-11-03 12:21:36 +00:00
mps_common.h
Fix some non-standard headers
2023-11-03 12:24:58 +00:00
mps_error.h
Fix some non-standard headers
2023-11-03 12:24:58 +00:00
mps_reader.c
Fix some non-standard headers
2023-11-03 12:24:58 +00:00
mps_reader.h
Fix some non-standard headers
2023-11-03 12:24:58 +00:00
mps_trace.c
Fix some non-standard headers
2023-11-03 12:24:58 +00:00
mps_trace.h
Fix some non-standard headers
2023-11-03 12:24:58 +00:00
net_sockets.c
Avoid use of ip_len as it clashes with a macro in AIX system headers
2023-12-08 21:51:15 +00:00
nist_kw.c
Header updates
2023-11-03 12:21:36 +00:00
oid.c
Merge remote-tracking branch 'upstream/development' into pkcs5_aes_new
2024-02-08 14:26:29 +00:00
padlock.c
Merge remote-tracking branch 'origin/development' into support_cipher_encrypt_only
2023-11-23 10:31:26 +08:00
padlock.h
Header updates
2023-11-03 12:21:36 +00:00
pem.c
pem: zeroize the entire buffer in case of errors in mbedtls_pem_read_buffer()
2024-02-20 10:22:36 +01:00
pk_ecc.c
pk_ecc: fix documentation
2024-03-11 09:48:40 +01:00
pk_internal.h
pk_ecc: fix documentation
2024-03-11 09:48:40 +01:00
pk_wrap.c
pk_wrap: fix algorithm selection in rsa_opaque_decrypt()
2024-03-20 15:42:55 +01:00
pk_wrap.h
pk_wrap: remove last references to MBEDTLS_PSA_CRYPTO_C
2023-12-20 12:59:57 +02:00
pk.c
pk: fix unused variable in copy_from_psa()
2024-04-17 05:28:36 +02:00
pkcs5.c
pkcs[5/12]: add CIPHER_C for [en/de]crypting functions
2023-12-21 16:39:04 +01:00
pkcs7.c
x509: move internal functions declarations to a private header
2024-01-19 09:07:35 +01:00
pkcs12.c
pkcs[5/12]: add CIPHER_C for [en/de]crypting functions
2023-12-21 16:39:04 +01:00
pkparse.c
pk: move ECC setters to a separate file
2024-03-11 09:48:40 +01:00
pkwrite.c
mbedtls_ecp_write_key_ext(): migrate internally
2024-02-28 13:19:42 +01:00
pkwrite.h
pkwrite: add new internal symbol for the max supported public key DER length
2024-03-20 17:10:35 +01:00
platform_util.c
Merge pull request #8761 from valeriosetti/issue4681
2024-02-06 17:29:38 +00:00
platform.c
Header updates
2023-11-03 12:21:36 +00:00
poly1305.c
Header updates
2023-11-03 12:21:36 +00:00
psa_crypto_aead.c
Don't access psa_key_attributes_t.core
2024-02-28 01:30:24 +01:00
psa_crypto_aead.h
Header updates
2023-11-03 12:21:36 +00:00
psa_crypto_cipher.c
Merge branch 'development' into buffer-sharing-merge
2024-03-12 15:05:06 +00:00
psa_crypto_cipher.h
Header updates
2023-11-03 12:21:36 +00:00
psa_crypto_client.c
Remove domain parameters from psa_key_attributes_t
2024-02-26 16:57:30 +01:00
psa_crypto_core_common.h
Header updates
2023-11-03 12:21:36 +00:00
psa_crypto_core.h
Merge pull request #1196 from davidhorstmann-arm/buffer-sharing-merge
2024-03-14 13:28:35 +01:00
psa_crypto_driver_wrappers_no_static.h
Header updates
2023-11-03 12:21:36 +00:00
psa_crypto_ecp.c
Merge pull request #8867 from gilles-peskine-arm/psa_key_attributes-remove_core
2024-03-05 09:59:24 +00:00
psa_crypto_ecp.h
Header updates
2023-11-03 12:21:36 +00:00
psa_crypto_ffdh.c
Don't access psa_key_attributes_t.core
2024-02-28 01:30:24 +01:00
psa_crypto_ffdh.h
psa_crypto_ffdh: move dhm.h inclusion to c file
2024-01-26 09:35:18 +01:00
psa_crypto_hash.c
Header updates
2023-11-03 12:21:36 +00:00
psa_crypto_hash.h
Header updates
2023-11-03 12:21:36 +00:00
psa_crypto_invasive.h
Change to use test-hook-based approach
2023-12-11 17:58:56 +00:00
psa_crypto_its.h
Header updates
2023-11-03 12:21:36 +00:00
psa_crypto_mac.c
Header updates
2023-11-03 12:21:36 +00:00
psa_crypto_mac.h
Header updates
2023-11-03 12:21:36 +00:00
psa_crypto_pake.c
Header updates
2023-11-03 12:21:36 +00:00
psa_crypto_pake.h
Header updates
2023-11-03 12:21:36 +00:00
psa_crypto_random_impl.h
psa_crypto_random_impl: minor fixes
2024-02-28 06:48:49 +01:00
psa_crypto_rsa.c
Don't access psa_key_attributes_t.core
2024-02-28 01:30:24 +01:00
psa_crypto_rsa.h
Ignore domain parameters in RSA key generation
2024-02-26 08:50:38 +01:00
psa_crypto_se.c
Header updates
2023-11-03 12:21:36 +00:00
psa_crypto_se.h
Header updates
2023-11-03 12:21:36 +00:00
psa_crypto_slot_management.c
Clarify psa_get_and_lock_key_slot return behaviour
2024-04-30 14:09:43 +01:00
psa_crypto_slot_management.h
Explicitly document return behaviour
2024-04-30 14:09:43 +01:00
psa_crypto_storage.c
Switch key slots to psa_key_attributes_t
2024-02-28 01:30:24 +01:00
psa_crypto_storage.h
Document deprecated transaction system as non thread safe
2024-03-05 14:06:02 +00:00
psa_crypto.c
Merge pull request #9074 from Ryan-Everett-arm/8357-fix-3.6
2024-05-02 16:06:09 +00:00
psa_its_file.c
Use MBEDTLS_GET_UINTxx_BE macro
2023-11-21 17:09:46 +00:00
psa_util_internal.h
psa_util: change guard for mbedtls_psa_get_random() to CRYPTO_CLIENT
2024-02-29 16:14:29 +01:00
psa_util.c
psa_util: change guard for mbedtls_psa_get_random() to CRYPTO_CLIENT
2024-02-29 16:14:29 +01:00
ripemd160.c
Header updates
2023-11-03 12:21:36 +00:00
rsa_alt_helpers.c
Header updates
2023-11-03 12:21:36 +00:00
rsa_alt_helpers.h
rsa: introduce rsa_internal_rsassa_pss_sign_no_mode_check()
2023-12-20 12:59:57 +02:00
rsa_internal.h
rsa_internal: fix documentation for mbedtls_rsa_parse_key()
2024-02-05 08:48:39 +01:00
rsa.c
rsa: rsa_rsassa_pss_sign() to check MD alg both in parameters and RSA context
2024-03-11 11:34:58 +01:00
sha1.c
Header updates
2023-11-03 12:21:36 +00:00
sha3.c
Merge pull request #8822 from daverodgman/sha3-perf
2024-03-12 13:14:40 +00:00
sha256.c
Fixed issue of redefinition warning messages for _GNU_SOURCE
2024-05-02 14:27:44 +05:30
sha512.c
Support SHA-512 hwcap detection on old libc
2024-01-30 15:31:42 +00:00
ssl_cache.c
Header updates
2023-11-03 12:21:36 +00:00
ssl_ciphersuites_internal.h
ssl_ciphersuites: move internal functions declarations to a private header
2024-01-18 15:08:28 +01:00
ssl_ciphersuites.c
library/tests: replace md_psa.h with psa_util.h as include file for MD conversion
2024-01-02 13:27:32 +01:00
ssl_client.c
tls13: Use a flag not a counter for CCS and HRR handling
2024-03-14 15:05:09 +01:00
ssl_client.h
Header updates
2023-11-03 12:21:36 +00:00
ssl_cookie.c
library/tests: replace md_psa.h with psa_util.h as include file for MD conversion
2024-01-02 13:27:32 +01:00
ssl_debug_helpers.h
tls13: cli: Split early data user status and internal state
2024-03-12 17:48:15 +01:00
ssl_misc.h
Add code improvments and refactoring in dealing with ALPN
2024-03-13 16:50:01 +00:00
ssl_msg.c
ssl_msg.c: Rename _check_new_session_ticket to _is_new_session_ticket
2024-04-05 14:16:32 +02:00
ssl_ticket.c
ssl_ticket.c: Fix ticket lifetime when parsing
2024-03-08 16:35:04 +01:00
ssl_tls12_client.c
Merge pull request #8574 from ronald-cron-arm/ssl-tickets
2024-02-21 09:38:46 +00:00
ssl_tls12_server.c
Merge pull request #8587 from yanrayw/issue/4911/ssl_setup-check-RNG-configuration
2024-03-08 07:38:39 +00:00
ssl_tls13_client.c
Enable ssl_tls13_get_ciphersuite_hash_alg only if macro is active
2024-04-05 14:16:31 +02:00
ssl_tls13_generic.c
Fix compilation of ssl_tls13_generic.c when memcpy() is a function-like macro
2024-04-02 14:52:29 +01:00
ssl_tls13_invasive.h
Header updates
2023-11-03 12:21:36 +00:00
ssl_tls13_keys.c
Merge pull request #8715 from valeriosetti/issue7964
2024-02-05 15:09:15 +00:00
ssl_tls13_keys.h
Fix some non-standard headers
2023-11-03 12:24:58 +00:00
ssl_tls13_server.c
Unconditionally define session variable
2024-04-05 14:16:31 +02:00
ssl_tls.c
tls13: Do not initiate at all resumption if tickets not supported
2024-04-05 14:16:32 +02:00
threading.c
Add new mutex for PSA global rng data
2024-03-12 15:36:57 +00:00
timing.c
Header updates
2023-11-03 12:21:36 +00:00
version.c
Header updates
2023-11-03 12:21:36 +00:00
x509_create.c
Update fix to be more platform-independent
2024-01-22 15:31:05 +00:00
x509_crl.c
x509: move internal functions declarations to a private header
2024-01-19 09:07:35 +01:00
x509_crt.c
x509: Added mbedtls_x509_crt_get_ca_istrue() API accessor.
2024-03-04 02:22:01 +00:00
x509_csr.c
x509: move internal functions declarations to a private header
2024-01-19 09:07:35 +01:00
x509_internal.h
Un-unrestore mbedtls_x509_string_to_names()
2024-02-26 13:59:43 +00:00
x509.c
x509: move internal functions declarations to a private header
2024-01-19 09:07:35 +01:00
x509write_crt.c
Merge pull request #8715 from valeriosetti/issue7964
2024-02-05 15:09:15 +00:00
x509write_csr.c
Merge pull request #8715 from valeriosetti/issue7964
2024-02-05 15:09:15 +00:00
x509write.c
x509: move internal functions declarations to a private header
2024-01-19 09:07:35 +01:00