30995 Commits

Author SHA1 Message Date
Gilles Peskine
f13fdf8a80 Expand on performance
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
2024-07-31 15:37:39 +02:00
Gilles Peskine
1a0107bf1b Discuss why we have so many variants
Explain that the hybrid key store is the historical implementation and
neither alternative is a drop-in replacement. Discuss how we could
potentially reduce the number of variants after the next major release.

Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
2024-07-31 15:36:13 +02:00
Manuel Pégourié-Gonnard
7fb50072f9
Merge pull request #1259 from gilles-peskine-arm/ecdsa-conversion-overflow-3.6
Backport 3.6: Fix stack buffer overflow in ECDSA signature format conversions
2024-07-31 12:39:35 +02:00
Gilles Peskine
dbd726bb45 Link to issue about freeing empty slices
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
2024-07-31 00:21:42 +02:00
Gilles Peskine
ac6b61077a Improve and fix explanation of next_free
In particular, fix an off-by-one error right after I explain how the number
is off by one from what you'd expect. State explicitly that the number can
be negative.

Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
2024-07-31 00:12:46 +02:00
Gilles Peskine
7d8ababd0c Update macro name about the static key store
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
2024-07-31 00:12:30 +02:00
Gilles Peskine
47f3fcd0f3 Typos and minor clarifications
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
2024-07-31 00:12:21 +02:00
Gilles Peskine
79d1cadbcb Improve description of who is affected
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
2024-07-25 18:39:53 +02:00
Gilles Peskine
6907e6ceec More diversified sizes in tests
Test the minimum size that caused an overflow in all configurations,
and also a mostly arbitrary larger size.

Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
2024-07-25 18:39:53 +02:00
Gilles Peskine
4269ee6f2d Fix stack buffer overflow in ECDSA signature format conversions
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
2024-07-25 18:39:53 +02:00
Gilles Peskine
5d660396ec Force MBEDTLS_PSA_HMAC_DRBG_MD_TYPE based on CTR_DRBG
If MBEDTLS_CTR_DRBG_C is enabled, force MBEDTLS_PSA_HMAC_DRBG_MD_TYPE to be
disabled. This resolves the former inconsistency in builds where
MBEDTLS_PSA_HMAC_DRBG_MD_TYPE is explicitly defined but MBEDTLS_CTR_DRBG_C
remains enabled, where PSA called the CTR_DRBG functions but other parts of
the code based assumed that HMAC was in use, in particular error code
conversions (leading to a test failure in test_suite_psa_crypto_init).

Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
2024-07-25 18:24:59 +02:00
Gilles Peskine
3f21ca7f16 Document that MBEDTLS_PSA_HMAC_DRBG_MD_TYPE does not force HMAC
MBEDTLS_PSA_HMAC_DRBG_MD_TYPE was documented and announced as causing the
PSA DRBG to be HMAC_DRBG. However, that was never actually implemented:
CTR_DRBG is prioritized if enabled.

Since there is a simple workaround of disabling MBEDTLS_CTR_DRBG_C if you
want to use HMAC_DRBG, we have decided to accept the actual behavior and fix
the documentation.

Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
2024-07-25 18:24:59 +02:00
Ronald Cron
b38e960f24
Merge pull request #9419 from ronald-cron-arm/move-crypto-test-suites-3.6
[Backport 3.6] PR 9394 backport of fixes and framework submodule update
2024-07-24 09:24:18 +00:00
Ronald Cron
1640bd3154 Update auto-generated psa_test_wrappers.
Signed-off-by: Ronald Cron <ronald.cron@arm.com>
2024-07-23 18:16:57 +02:00
Ronald Cron
e5bbb2f79f Update the framework submodule to the merge of PR38
Signed-off-by: Ronald Cron <ronald.cron@arm.com>
2024-07-23 18:15:03 +02:00
Ronald Cron
62b0976c68 Update framework as in PR 9394
Signed-off-by: Ronald Cron <ronald.cron@arm.com>
2024-07-23 07:53:12 +02:00
Ronald Cron
467775ef26 programs: fuzz: Fix comment
Signed-off-by: Ronald Cron <ronald.cron@arm.com>
2024-07-23 07:51:33 +02:00
Ronald Cron
c025f31399 tests: CMake: Align/fix config test suite generation
Signed-off-by: Ronald Cron <ronald.cron@arm.com>
2024-07-23 07:51:10 +02:00
Ronald Cron
977766c59f CMake: Include CMakePrintHelpers
Signed-off-by: Ronald Cron <ronald.cron@arm.com>
2024-07-23 07:50:39 +02:00
Gilles Peskine
33218d2b30
Merge pull request #9329 from sezrab/replace_MBEDTLS_MD_CAN_MD5_with_PSA_WANT-3.6
Backport 3.6: Add MD5 support for requires_hash_alg
2024-07-18 09:41:05 +00:00
Gilles Peskine
7d3451df4f
Merge pull request #9388 from eleuzi01/backport-9285
[Backport 3.6] Fix typo in platform_util.c
2024-07-17 13:50:19 +00:00
Paul Elliott
ab26f5cdd4
Merge pull request #9386 from eleuzi01/backport-9287
[Backport 3.6] Fix some typo for include folder
2024-07-17 13:11:32 +00:00
Sam Berry
602550162c Add TLS: password protected... to ignored_tests list
Signed-off-by: Sam Berry <sam.berry@arm.com>
2024-07-17 10:03:40 +01:00
Sam Berry
e2720447b6 Reverted requires_cipher_enabled AES
Signed-off-by: Sam Berry <sam.berry@arm.com>
2024-07-17 10:02:34 +01:00
Sam Berry
e7e5c7e4c1 Changed some tests to use requires_cipher_enabled
I expect some will still skip due to `MBEDTLS_CIPHER_MODE_CBC` being unset.

Signed-off-by: Sam Berry <sam.berry@arm.com>
2024-07-17 10:02:34 +01:00
Sam Berry
06b91be210 Added support for MD5 in requires_hash_alg
Signed-off-by: Sam Berry <sam.berry@arm.com>
2024-07-17 10:02:34 +01:00
Gilles Peskine
71a0e8c2cd
Merge pull request #9398 from davidhorstmann-arm/upgrade-python-dependencies-3.6
[Backport 3.6] Upgrade python dependencies in requirements file
2024-07-15 18:16:11 +00:00
David Horstmann
4e7ca644ce Upgrade python dependencies in requirements file
Signed-off-by: David Horstmann <david.horstmann@arm.com>
2024-07-15 16:35:50 +01:00
Gilles Peskine
89a48ce267
Merge pull request #9392 from valeriosetti/backport-fix-psa_key_derivation_verify_bytes
[Backport 3.6] psa: fix parameters' names of psa_key_derivation_verify_bytes()
2024-07-15 11:01:01 +00:00
Tomás González
1fb69a9e91 tests/ssl_helpers: Check that message queue is popped
mbedtls_test_mock_tcp_recv_msg is currently popping a message
queue and does not check if this was done correctly.

This extra check makes the test more complete/robust.

Signed-off-by: Tomás González <tomasagustin.gonzalezorlando@arm.com>
2024-07-15 11:07:38 +01:00
Valerio Setti
d30cc09bc7 psa: fix parameters' names of psa_key_derivation_verify_bytes()
PSA buffers and their length should follow a pattern for which
the latter is named after the former as <buffer_name>_length,
but this was not the case for psa_key_derivation_verify_bytes().

This makes life of crypto.h parsers (for automatic code generation)
harder. This commit aims at solving this problem.

Signed-off-by: Valerio Setti <valerio.setti@nordicsemi.no>
2024-07-15 07:23:09 +02:00
Wenxing Hou
848bccf1ce Fix some typo for include folder
Signed-off-by: Wenxing Hou <wenxing.hou@intel.com>
2024-07-12 11:38:53 +03:00
Michael Grand (TrustnGo)
83da5abdd6 Fix typo in platform_util.c
Fix a typo in a conditional include.

Signed-off-by: Michael Grand (TrustnGo) <m.grand@trustngo.tech>
2024-07-11 17:31:22 +03:00
Ronald Cron
71ff969ca2
Merge pull request #9383 from ronald-cron-arm/move-mbedtls-crypto-modules-3.6
[Backport 3.6] Backport of the framework submodule update in PR 9340
2024-07-10 15:09:48 +00:00
Ronald Cron
eebe477c3f Update framework submodule
Update framework submodule as
in PR 9340 against development.

Signed-off-by: Ronald Cron <ronald.cron@arm.com>
2024-07-10 12:18:22 +02:00
Gilles Peskine
3e419b06da
Merge pull request #9375 from davidhorstmann-arm/move-test-data-files-to-framework-3.6
[Backport 3.6] Move test data files to framework
2024-07-09 12:47:05 +00:00
Ronald Cron
dda4382f22 Update the framework submodule to the merge of PR18
Signed-off-by: Ronald Cron <ronald.cron@arm.com>
2024-07-09 09:04:31 +02:00
David Horstmann
55e4c36f55 Update framework submodule
Signed-off-by: David Horstmann <david.horstmann@arm.com>
2024-07-08 15:36:48 +01:00
David Horstmann
77074905bb Update generated tls13 testcase script
Signed-off-by: David Horstmann <david.horstmann@arm.com>
2024-07-08 15:36:48 +01:00
David Horstmann
d762d94dfb Move variable into generated bash
Move the DATA_FILES_PATH_VAR variable into the generated bash rather
than only variablising it in the python that generates the test script.

Signed-off-by: David Horstmann <david.horstmann@arm.com>
2024-07-08 15:36:48 +01:00
David Horstmann
316beb349d Simplify path in audit-validity-dates.py
Signed-off-by: David Horstmann <david.horstmann@arm.com>
2024-07-08 15:36:48 +01:00
David Horstmann
72edc66437 Simplify data_files path in compat test generation
Signed-off-by: David Horstmann <david.horstmann@arm.com>
2024-07-08 15:36:48 +01:00
David Horstmann
5ab92be10a Use variable for data_files path in ssl-opt.sh
Signed-off-by: David Horstmann <david.horstmann@arm.com>
2024-07-08 15:36:48 +01:00
David Horstmann
79c8a65be3 Replace data_files path with variable in compat.sh
Signed-off-by: David Horstmann <david.horstmann@arm.com>
2024-07-08 15:36:48 +01:00
David Horstmann
7d0e5d20ab Correct redundant framework/../framework paths
Signed-off-by: David Horstmann <david.horstmann@arm.com>
2024-07-08 15:36:48 +01:00
David Horstmann
3e00faf166 Fix line-too-long in generate_tls13_compat_tests.py
Signed-off-by: David Horstmann <david.horstmann@arm.com>
2024-07-08 15:36:48 +01:00
David Horstmann
5282ecddaa Update directory-climbing path in context-info.sh
A path containing '../../' was defined in relation to a directory in the
tests/data_files directory. Since this has been moved to
framework/data_files, we must update the path to refer correctly to the
same location as before.

Signed-off-by: David Horstmann <david.horstmann@arm.com>
2024-07-08 15:36:48 +01:00
David Horstmann
9c4dd4ee6f Update paths pointing to tests/data_files
These now point to framework/data_files instead.

Signed-off-by: David Horstmann <david.horstmann@arm.com>
2024-07-08 15:36:46 +01:00
David Horstmann
099f49230c Move some files to framework repository
Signed-off-by: David Horstmann <david.horstmann@arm.com>
2024-07-08 15:33:58 +01:00
Gilles Peskine
422a276c5e
Merge pull request #9045 from Troy-Butler/handle-null-args
[Backport 3.6] Fix NULL argument handling in mbedtls_xxx_free() functions
2024-07-04 14:50:59 +00:00