mirror/mbedtls
1
0
Fork 0
mirror of https://github.com/Mbed-TLS/mbedtls.git synced 2025-04-02 07:20:26 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

psa: import: Move registered SE support to the driver wrapper

Browse Source 
Signed-off-by: Ronald Cron <ronald.cron@arm.com>
This commit is contained in:
Ronald Cron 2020-11-30 12:11:01 +01:00
parent bf33c93717
commit fb2ed5bb05
2 changed files with 52 additions and 60 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
library/psa_crypto.c
View File

@ -1800,6 +1800,7 @@ psa_status_t psa_import_key( const psa_key_attributes_t *attributes,
psa_status_t status; psa_status_t status;
psa_key_slot_t *slot = NULL; psa_key_slot_t *slot = NULL;
psa_se_drv_table_entry_t *driver = NULL; psa_se_drv_table_entry_t *driver = NULL;
size_t bits;
*key = MBEDTLS_SVC_KEY_ID_INIT; *key = MBEDTLS_SVC_KEY_ID_INIT;
@ -1814,44 +1815,6 @@ psa_status_t psa_import_key( const psa_key_attributes_t *attributes,
if( status != PSA_SUCCESS ) if( status != PSA_SUCCESS )
goto exit; goto exit;
#if defined(MBEDTLS_PSA_CRYPTO_SE_C)
if( driver != NULL )
{
const psa_drv_se_t *drv = psa_get_se_driver_methods( driver );
/* The driver should set the number of key bits, however in
* case it doesn't, we initialize bits to an invalid value. */
size_t bits = PSA_MAX_KEY_BITS + 1;
if( drv->key_management == NULL ||
drv->key_management->p_import == NULL )
{
status = PSA_ERROR_NOT_SUPPORTED;
goto exit;
}
status = drv->key_management->p_import(
psa_get_se_driver_context( driver ),
psa_key_slot_get_slot_number( slot ),
attributes, data, data_length, &bits );
if( status != PSA_SUCCESS )
goto exit;
if( bits > PSA_MAX_KEY_BITS )
{
status = PSA_ERROR_NOT_SUPPORTED;
goto exit;
}
slot->attr.bits = (psa_key_bits_t) bits;
}
else
#endif /* MBEDTLS_PSA_CRYPTO_SE_C */
if( psa_key_lifetime_is_external( psa_get_key_lifetime( attributes ) ) )
{
/* Importing a key with external lifetime through the driver wrapper
* interface is not yet supported. Return as if this was an invalid
* lifetime. */
status = PSA_ERROR_INVALID_ARGUMENT;
goto exit;
}
else
{
/* In the case of a transparent key or an opaque key stored in local /* In the case of a transparent key or an opaque key stored in local
* storage (thus not in the case of generating a key in a secure element * storage (thus not in the case of generating a key in a secure element
* or cryptoprocessor with storage), we have to allocate a buffer to * or cryptoprocessor with storage), we have to allocate a buffer to
@ -1863,7 +1826,7 @@ psa_status_t psa_import_key( const psa_key_attributes_t *attributes,
goto exit; goto exit;
} }
size_t bits = slot->attr.bits; bits = slot->attr.bits;
status = psa_driver_wrapper_import_key( attributes, status = psa_driver_wrapper_import_key( attributes,
data, data_length, data, data_length,
slot->key.data, slot->key.data,
@ -1879,7 +1842,6 @@ psa_status_t psa_import_key( const psa_key_attributes_t *attributes,
status = PSA_ERROR_INVALID_ARGUMENT; status = PSA_ERROR_INVALID_ARGUMENT;
goto exit; goto exit;
} }
}
status = psa_validate_optional_attributes( slot, attributes ); status = psa_validate_optional_attributes( slot, attributes );
if( status != PSA_SUCCESS ) if( status != PSA_SUCCESS )

34
library/psa_crypto_driver_wrappers.c
View File

@ -422,6 +422,35 @@ psa_status_t psa_driver_wrapper_import_key(
psa_key_location_t location = PSA_KEY_LIFETIME_GET_LOCATION( psa_key_location_t location = PSA_KEY_LIFETIME_GET_LOCATION(
psa_get_key_lifetime( attributes ) ); psa_get_key_lifetime( attributes ) );
/* Try dynamically-registered SE interface first */
#if defined(MBEDTLS_PSA_CRYPTO_SE_C)
const psa_drv_se_t *drv;
psa_drv_se_context_t *drv_context;
if( psa_get_se_driver( attributes->core.lifetime, &drv, &drv_context ) )
{
if( drv->key_management == NULL ||
drv->key_management->p_import == NULL )
return( PSA_ERROR_NOT_SUPPORTED );
/* The driver should set the number of key bits, however in
* case it doesn't, we initialize bits to an invalid value. */
*bits = PSA_MAX_KEY_BITS + 1;
status = drv->key_management->p_import(
drv_context,
*( (psa_key_slot_number_t *)key_buffer ),
attributes, data, data_length, bits );
if( status != PSA_SUCCESS )
return( status );
if( (*bits) > PSA_MAX_KEY_BITS )
return( PSA_ERROR_NOT_SUPPORTED );
return( PSA_SUCCESS );
}
#endif /* PSA_CRYPTO_SE_C */
switch( location ) switch( location )
{ {
case PSA_KEY_LOCATION_LOCAL_STORAGE: case PSA_KEY_LOCATION_LOCAL_STORAGE:
@ -445,9 +474,10 @@ psa_status_t psa_driver_wrapper_import_key(
key_buffer_length, bits ) ); key_buffer_length, bits ) );
default: default:
/* Key is declared with a lifetime not known to us */ /* Importing a key with external storage in not yet supported.
* Return in error indicating that the lifetime is not valid. */
(void)status; (void)status;
return( PSA_ERROR_NOT_SUPPORTED ); return( PSA_ERROR_INVALID_ARGUMENT );
} }
} }