mirror/mbedtls
1
0
Fork 0
mirror of https://github.com/Mbed-TLS/mbedtls.git synced 2025-03-31 01:20:35 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Apply review comments

Browse Source 
Signed-off-by: Tom Cosgrove <tom.cosgrove@arm.com>
This commit is contained in:
Tom Cosgrove 2022-12-05 15:47:40 +00:00
parent 62b20488f1
commit f51f972d67
2 changed files with 10 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
scripts/mbedtls_dev/bignum_mod.py
View File

@ -42,16 +42,11 @@ class BignumModSub(bignum_common.ModOperationCommon, BignumModTarget):
input_style = "fixed" input_style = "fixed"
arity = 2 arity = 2
# To make negative tests easier, append 0 for success to the generated cases
def arguments(self) -> List[str]:
return [bignum_common.quote_str(n) for n in [self.arg_n,
self.arg_a,
self.arg_b]
] + self.result() + ["0"]
def result(self) -> List[str]: def result(self) -> List[str]:
result = (self.int_a - self.int_b) % self.int_n result = (self.int_a - self.int_b) % self.int_n
return [self.format_result(result)] # To make negative tests easier, append 0 for success to the
# generated cases
return [self.format_result(result), "0"]
# END MERGE SLOT 3 # END MERGE SLOT 3

4
tests/suites/test_suite_bignum_mod.function
View File

@ -9,7 +9,7 @@
ASSERT_COMPARE( (a).p, (a).limbs * sizeof(mbedtls_mpi_uint), \ ASSERT_COMPARE( (a).p, (a).limbs * sizeof(mbedtls_mpi_uint), \
(b).p, (b).limbs * sizeof(mbedtls_mpi_uint) ) (b).p, (b).limbs * sizeof(mbedtls_mpi_uint) )
int test_read_modulus( mbedtls_mpi_mod_modulus *m, static int test_read_modulus( mbedtls_mpi_mod_modulus *m,
mbedtls_mpi_mod_rep_selector int_rep, mbedtls_mpi_mod_rep_selector int_rep,
char *input ) char *input )
{ {
@ -23,7 +23,7 @@ int test_read_modulus( mbedtls_mpi_mod_modulus *m,
return( mbedtls_mpi_mod_modulus_setup( m, p, limbs, int_rep ) ); return( mbedtls_mpi_mod_modulus_setup( m, p, limbs, int_rep ) );
} }
int test_read_residue( mbedtls_mpi_mod_residue *r, static int test_read_residue( mbedtls_mpi_mod_residue *r,
const mbedtls_mpi_mod_modulus *m, const mbedtls_mpi_mod_modulus *m,
char *input, char *input,
int skip_limbs_and_value_checks ) int skip_limbs_and_value_checks )