mirror/mbedtls
1
0
Fork 0
mirror of https://github.com/Mbed-TLS/mbedtls.git synced 2024-12-26 18:20:21 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

mbedtls_ssl_check_pending: Add MBEDTLS_ERR_SSL_BAD_INPUT_DATA check

Browse Source 
To be consistent with mbedtls_ssl_read/mbedtls_ssl_write.

Background:
My app is using this within a traditional non-blocking poll-loop.
The same structure is used for both of mbedtls ssl context and a raw
TCP socket. For such an app, it's convenient to be able to represent
an equivalent of file descriptor -1 and EBADF. With mbedtls-2.x,
I was using a zero'ed ssl context and checking it with ssl->conf == NULL
before calling mbedtls_ssl_check_pending. However, the field is marked
private for mbedtls-3.x. A more straightforward "solution" would be
to introduce an accessor to detect such a context. But I feel it's
more consistent to make mbedtls_ssl_check_pending check it by itself
as other funtions including mbedtls_ssl_read/mbedtls_ssl_write do.

Signed-off-by: YAMAMOTO Takashi <yamamoto@midokura.com>
This commit is contained in:
YAMAMOTO Takashi 2022-02-07 09:09:04 +09:00
parent 6f20595b6e
commit ea682b8756
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
library/ssl_msg.c
View File

@ -4798,6 +4798,9 @@ size_t mbedtls_ssl_get_bytes_avail( const mbedtls_ssl_context *ssl )
int mbedtls_ssl_check_pending( const mbedtls_ssl_context *ssl )
{
if( ssl == NULL || ssl->conf == NULL )
return( MBEDTLS_ERR_SSL_BAD_INPUT_DATA );
/*
* Case A: We're currently holding back
* a message for further processing.