Fix a few unchecked value issue

Signed-off-by: Chien Wong <m@xv97.com>
This commit is contained in:
Chien Wong 2023-08-01 21:38:46 +08:00
parent cbc495eb0f
commit e2caf4161b
No known key found for this signature in database
GPG Key ID: 5CA58A39FA4122AD
3 changed files with 5 additions and 5 deletions

View File

@ -1706,7 +1706,7 @@ int mbedtls_mpi_exp_mod(mbedtls_mpi *X, const mbedtls_mpi *A,
*/ */
const size_t x_index = 0; const size_t x_index = 0;
mbedtls_mpi_init(&W[x_index]); mbedtls_mpi_init(&W[x_index]);
mbedtls_mpi_copy(&W[x_index], X); MBEDTLS_MPI_CHK(mbedtls_mpi_copy(&W[x_index], X));
j = N->n + 1; j = N->n + 1;
/* All W[i] and X must have at least N->n limbs for the mpi_montmul() /* All W[i] and X must have at least N->n limbs for the mpi_montmul()
@ -1893,7 +1893,7 @@ int mbedtls_mpi_exp_mod(mbedtls_mpi *X, const mbedtls_mpi *A,
/* /*
* Load the result in the output variable. * Load the result in the output variable.
*/ */
mbedtls_mpi_copy(X, &W[x_index]); MBEDTLS_MPI_CHK(mbedtls_mpi_copy(X, &W[x_index]));
cleanup: cleanup:

View File

@ -373,7 +373,7 @@ modn:
#if defined(MBEDTLS_ECP_RESTARTABLE) #if defined(MBEDTLS_ECP_RESTARTABLE)
if (rs_ctx != NULL && rs_ctx->sig != NULL) { if (rs_ctx != NULL && rs_ctx->sig != NULL) {
mbedtls_mpi_copy(r, pr); MBEDTLS_MPI_CHK(mbedtls_mpi_copy(r, pr));
} }
#endif #endif
@ -447,7 +447,7 @@ int mbedtls_ecdsa_sign_det_restartable(mbedtls_ecp_group *grp,
MBEDTLS_MPI_CHK(mbedtls_mpi_write_binary(d, data, grp_len)); MBEDTLS_MPI_CHK(mbedtls_mpi_write_binary(d, data, grp_len));
MBEDTLS_MPI_CHK(derive_mpi(grp, &h, buf, blen)); MBEDTLS_MPI_CHK(derive_mpi(grp, &h, buf, blen));
MBEDTLS_MPI_CHK(mbedtls_mpi_write_binary(&h, data + grp_len, grp_len)); MBEDTLS_MPI_CHK(mbedtls_mpi_write_binary(&h, data + grp_len, grp_len));
mbedtls_hmac_drbg_seed_buf(p_rng, md_info, data, 2 * grp_len); MBEDTLS_MPI_CHK(mbedtls_hmac_drbg_seed_buf(p_rng, md_info, data, 2 * grp_len));
#if defined(MBEDTLS_ECP_RESTARTABLE) #if defined(MBEDTLS_ECP_RESTARTABLE)
if (rs_ctx != NULL && rs_ctx->det != NULL) { if (rs_ctx != NULL && rs_ctx->det != NULL) {

View File

@ -126,7 +126,7 @@ int mbedtls_rsa_deduce_primes(mbedtls_mpi const *N,
} }
for (; attempt < num_primes; ++attempt) { for (; attempt < num_primes; ++attempt) {
mbedtls_mpi_lset(&K, primes[attempt]); MBEDTLS_MPI_CHK(mbedtls_mpi_lset(&K, primes[attempt]));
/* Check if gcd(K,N) = 1 */ /* Check if gcd(K,N) = 1 */
MBEDTLS_MPI_CHK(mbedtls_mpi_gcd(P, &K, N)); MBEDTLS_MPI_CHK(mbedtls_mpi_gcd(P, &K, N));