From c5874db5b079d491316b298724eff0702d10398c Mon Sep 17 00:00:00 2001
From: Dave Rodgman <dave.rodgman@arm.com>
Date: Thu, 16 Feb 2023 16:14:46 +0000
Subject: [PATCH] Add test-case for signature over zero-length data

Signed-off-by: Dave Rodgman <dave.rodgman@arm.com>
---
 tests/data_files/Makefile                       |   9 +++++++++
 tests/data_files/pkcs7_zerolendata.bin          |   0
 tests/data_files/pkcs7_zerolendata_detached.der | Bin 0 -> 435 bytes
 tests/suites/test_suite_pkcs7.data              |   4 ++++
 tests/suites/test_suite_pkcs7.function          |   3 ++-
 5 files changed, 15 insertions(+), 1 deletion(-)
 create mode 100644 tests/data_files/pkcs7_zerolendata.bin
 create mode 100644 tests/data_files/pkcs7_zerolendata_detached.der

diff --git a/tests/data_files/Makefile b/tests/data_files/Makefile
index 070f538fe8..6680bf944a 100644
--- a/tests/data_files/Makefile
+++ b/tests/data_files/Makefile
@@ -1205,6 +1205,10 @@ $(pkcs7_test_file):
 	echo -e "Hello\xd" > $@
 all_final += $(pkcs7_test_file)
 
+pkcs7_zerolendata.bin:
+	printf '' > $@
+all_final += pkcs7_zerolendata.bin
+
 pkcs7_data_1.bin:
 	echo -e "2\xd" > $@
 all_final += pkcs7_data_1.bin
@@ -1238,6 +1242,11 @@ pkcs7-rsa-sha256-2.der: $(pkcs7_test_cert_2)
 	$(OPENSSL) x509 -in pkcs7-rsa-sha256-2.crt -out $@ -outform DER
 all_final += pkcs7-rsa-sha256-2.der
 
+# pkcs7 signature file over zero-len data
+pkcs7_zerolendata_detached.der: pkcs7_zerolendata.bin pkcs7-rsa-sha256-1.key pkcs7-rsa-sha256-1.crt
+	$(OPENSSL) smime -sign -md sha256 -nocerts -noattr -in pkcs7_zerolendata.bin -inkey pkcs7-rsa-sha256-1.key -outform DER -binary -signer pkcs7-rsa-sha256-1.crt -out pkcs7_zerolendata_detached.der
+all_final += pkcs7_zerolendata_detached.der
+
 # pkcs7 signature file with CERT
 pkcs7_data_cert_signed_sha256.der: $(pkcs7_test_file) $(pkcs7_test_cert_1)
 	$(OPENSSL) smime -sign -binary -in pkcs7_data.bin -out $@ -md sha256 -signer pkcs7-rsa-sha256-1.pem -noattr -outform DER -out $@
diff --git a/tests/data_files/pkcs7_zerolendata.bin b/tests/data_files/pkcs7_zerolendata.bin
new file mode 100644
index 0000000000..e69de29bb2
diff --git a/tests/data_files/pkcs7_zerolendata_detached.der b/tests/data_files/pkcs7_zerolendata_detached.der
new file mode 100644
index 0000000000000000000000000000000000000000..2a389ab484991c53322dc87f998c23666c7f40d8
GIT binary patch
literal 435
zcmXqLVqDM0snzDu_MMlJooPW6;{t;w#yL!kjE4LMylk8aZ61uN%q&cdtPBR+2!)J>
zO^oG0g~dRH20jKRhTI06Y|No7Y{E=_K8Ab-JRlAi4{Lz8bFjIgsDUtu&&<OE<|{a-
z7L_O%GKo~*yL-vS=i=FaF^($)bUL@+*UQ<DZYj_WP}ea6-N4es$PmM6A+5}P=zhA<
zopjF}@8~Dq(eu7Gh@Mk?rr|54cbN5MY%$BUjkCH{7TCX^nlY*O$ikV={@lp1H+Zai
zv4nNb>B(8VOS!kJ#%#A}``N(1;c{&~>lHDkH?uEo%Mn-I)RcHtyiZfMa^p+ZsUNpi
zPgR!4Nqe^XP|J(iZ9iYV4VC)5eD}1>LYA_Ut0%UoTPg6KocZ~>nDc7CFrFCCvQ4f5
z&!6=E=2F~OeeSW~iYJ$z8m>7r$$s(fnJ=H)XRc*m#@BnKV2R)M=?|h<Wi|O)i*=T&
z6tS!73M^Wxu%>k7C)IVU>KY#=_d1=v@T<pwNAJ#`KUuY3V_YwHv07N2X$_n1@IvAY
E04L9;WdHyG

literal 0
HcmV?d00001

diff --git a/tests/suites/test_suite_pkcs7.data b/tests/suites/test_suite_pkcs7.data
index 840a24bb61..70233ded7a 100644
--- a/tests/suites/test_suite_pkcs7.data
+++ b/tests/suites/test_suite_pkcs7.data
@@ -38,6 +38,10 @@ PKCS7 Signed Data Parse Fail Encrypted Content #8
 depends_on:MBEDTLS_SHA256_C
 pkcs7_parse:"data_files/pkcs7_data_cert_encrypted.der":MBEDTLS_ERR_PKCS7_FEATURE_UNAVAILABLE
 
+PKCS7 Signed Data Verification Pass zero-len data
+depends_on:MBEDTLS_SHA1_C:MBEDTLS_SHA256_C
+pkcs7_verify:"data_files/pkcs7_zerolendata_detached.der":"data_files/pkcs7-rsa-sha256-1.der":"data_files/pkcs7_zerolendata.bin":0:0
+
 PKCS7 Signed Data Verification Pass SHA256 #9
 depends_on:MBEDTLS_SHA256_C
 pkcs7_verify:"data_files/pkcs7_data_cert_signed_sha256.der":"data_files/pkcs7-rsa-sha256-1.der":"data_files/pkcs7_data.bin":0:0
diff --git a/tests/suites/test_suite_pkcs7.function b/tests/suites/test_suite_pkcs7.function
index 62f9f66b69..9dce25e04e 100644
--- a/tests/suites/test_suite_pkcs7.function
+++ b/tests/suites/test_suite_pkcs7.function
@@ -125,7 +125,8 @@ void pkcs7_verify(char *pkcs7_file,
     TEST_ASSERT(file != NULL);
 
     datalen = st.st_size;
-    ASSERT_ALLOC(data, datalen);
+    /* Add 1 so that data is non-NULL for zero length input */
+    ASSERT_ALLOC(data, datalen + 1);
     buflen = fread((void *) data, sizeof(unsigned char), datalen, file);
     TEST_EQUAL(buflen, datalen);