mirror/mbedtls
1
0
Fork 0
mirror of https://github.com/Mbed-TLS/mbedtls.git synced 2025-02-06 12:40:02 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

RSA: improve readability

Browse Source 
Signed-off-by: Janos Follath <janos.follath@arm.com>
This commit is contained in:
Janos Follath 2023-12-27 10:44:36 +00:00 committed by Dave Rodgman
parent 47ee770812
commit b4b8f3df3b
1 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
library/rsa.c
View File

@ -974,7 +974,7 @@ cleanup:
* Unblind * Unblind
* T = T * Vf mod N * T = T * Vf mod N
*/ */
static int rsa_unblind(mbedtls_mpi *T, mbedtls_mpi *Vf, mbedtls_mpi *N) static int rsa_unblind(mbedtls_mpi *T, mbedtls_mpi *Vf, const mbedtls_mpi *N)
{ {
int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED; int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
const mbedtls_mpi_uint mm = mbedtls_mpi_core_montmul_init(N->p); const mbedtls_mpi_uint mm = mbedtls_mpi_core_montmul_init(N->p);
@ -1063,7 +1063,7 @@ int mbedtls_rsa_private(mbedtls_rsa_context *ctx,
/* Temporaries holding the initial input and the double /* Temporaries holding the initial input and the double
* checked result; should be the same in the end. */ * checked result; should be the same in the end. */
mbedtls_mpi I, C; mbedtls_mpi input_blinded, check_result_blinded;
if (f_rng == NULL) { if (f_rng == NULL) {
return MBEDTLS_ERR_RSA_BAD_INPUT_DATA; return MBEDTLS_ERR_RSA_BAD_INPUT_DATA;
@ -1098,8 +1098,8 @@ int mbedtls_rsa_private(mbedtls_rsa_context *ctx,
mbedtls_mpi_init(&TP); mbedtls_mpi_init(&TQ); mbedtls_mpi_init(&TP); mbedtls_mpi_init(&TQ);
#endif #endif
mbedtls_mpi_init(&I); mbedtls_mpi_init(&input_blinded);
mbedtls_mpi_init(&C); mbedtls_mpi_init(&check_result_blinded);
/* End of MPI initialization */ /* End of MPI initialization */
@ -1117,7 +1117,7 @@ int mbedtls_rsa_private(mbedtls_rsa_context *ctx,
MBEDTLS_MPI_CHK(mbedtls_mpi_mul_mpi(&T, &T, &ctx->Vi)); MBEDTLS_MPI_CHK(mbedtls_mpi_mul_mpi(&T, &T, &ctx->Vi));
MBEDTLS_MPI_CHK(mbedtls_mpi_mod_mpi(&T, &T, &ctx->N)); MBEDTLS_MPI_CHK(mbedtls_mpi_mod_mpi(&T, &T, &ctx->N));
MBEDTLS_MPI_CHK(mbedtls_mpi_copy(&I, &T)); MBEDTLS_MPI_CHK(mbedtls_mpi_copy(&input_blinded, &T));
/* /*
* Exponent blinding * Exponent blinding
@ -1182,9 +1182,9 @@ int mbedtls_rsa_private(mbedtls_rsa_context *ctx,
#endif /* MBEDTLS_RSA_NO_CRT */ #endif /* MBEDTLS_RSA_NO_CRT */
/* Verify the result to prevent glitching attacks. */ /* Verify the result to prevent glitching attacks. */
MBEDTLS_MPI_CHK(mbedtls_mpi_exp_mod(&C, &T, &ctx->E, MBEDTLS_MPI_CHK(mbedtls_mpi_exp_mod(&check_result_blinded, &T, &ctx->E,
&ctx->N, &ctx->RN)); &ctx->N, &ctx->RN));
if (mbedtls_mpi_cmp_mpi(&C, &I) != 0) { if (mbedtls_mpi_cmp_mpi(&check_result_blinded, &input_blinded) != 0) {
ret = MBEDTLS_ERR_RSA_VERIFY_FAILED; ret = MBEDTLS_ERR_RSA_VERIFY_FAILED;
goto cleanup; goto cleanup;
} }
@ -1222,8 +1222,8 @@ cleanup:
mbedtls_mpi_free(&TP); mbedtls_mpi_free(&TQ); mbedtls_mpi_free(&TP); mbedtls_mpi_free(&TQ);
#endif #endif
mbedtls_mpi_free(&C); mbedtls_mpi_free(&check_result_blinded);
mbedtls_mpi_free(&I); mbedtls_mpi_free(&input_blinded);
if (ret != 0 && ret >= -0x007f) { if (ret != 0 && ret >= -0x007f) {
return MBEDTLS_ERROR_ADD(MBEDTLS_ERR_RSA_PRIVATE_FAILED, ret); return MBEDTLS_ERROR_ADD(MBEDTLS_ERR_RSA_PRIVATE_FAILED, ret);