From b1895899f1d4aea2b25b7981f73b0736d592e0f4 Mon Sep 17 00:00:00 2001 From: Pengyu Lv Date: Thu, 16 Mar 2023 11:38:43 +0800 Subject: [PATCH] ssl_cache: Improve some comments Signed-off-by: Pengyu Lv --- include/mbedtls/ssl_cache.h | 4 ++-- library/ssl_cache.c | 3 ++- programs/ssl/ssl_server2.c | 2 +- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/include/mbedtls/ssl_cache.h b/include/mbedtls/ssl_cache.h index 55dcf77c3b..1eb933cfa5 100644 --- a/include/mbedtls/ssl_cache.h +++ b/include/mbedtls/ssl_cache.h @@ -132,9 +132,9 @@ int mbedtls_ssl_cache_set(void *data, * associated to \p session. * \param session_id_len The length of \p session_id in bytes. * - * \return 0: The cache entry for session with provided ID + * \return \c 0: The cache entry for session with provided ID * is removed or does not exist. - * Otherwise: fail. + * A negative error code on failure. */ int mbedtls_ssl_cache_remove(void *data, unsigned char const *session_id, diff --git a/library/ssl_cache.c b/library/ssl_cache.c index 048c21d4f0..1c649ca254 100644 --- a/library/ssl_cache.c +++ b/library/ssl_cache.c @@ -29,6 +29,7 @@ #include "mbedtls/ssl_cache.h" #include "ssl_misc.h" +#include "mbedtls/error.h" #include @@ -335,7 +336,7 @@ int mbedtls_ssl_cache_remove(void *data, unsigned char const *session_id, size_t session_id_len) { - int ret = 1; + int ret = MBEDTLS_ERR_ERROR_GENERIC_ERROR; mbedtls_ssl_cache_context *cache = (mbedtls_ssl_cache_context *) data; mbedtls_ssl_cache_entry *entry; mbedtls_ssl_cache_entry *prev; diff --git a/programs/ssl/ssl_server2.c b/programs/ssl/ssl_server2.c index 8277ddee1e..d68f00286b 100644 --- a/programs/ssl/ssl_server2.c +++ b/programs/ssl/ssl_server2.c @@ -669,7 +669,7 @@ struct options { #if defined(MBEDTLS_HAVE_TIME) int cache_timeout; /* expiration delay of session cache entries*/ #endif - int cache_remove; /* enable / disable cache removement */ + int cache_remove; /* enable / disable cache entry removal */ char *sni; /* string describing sni information */ const char *curves; /* list of supported elliptic curves */ const char *sig_algs; /* supported TLS 1.3 signature algorithms */