From 6e450c7342de530310ee87fb68fb97f2f36afa51 Mon Sep 17 00:00:00 2001 From: Minos Galanakis Date: Wed, 1 May 2024 17:14:43 +0100 Subject: [PATCH 1/5] Updated the PR template with new checkboxes Signed-off-by: Minos Galanakis --- .github/pull_request_template.md | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 892ed28ce1..506fd00f33 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -6,12 +6,13 @@ Please write a few sentences describing the overall goals of the pull request's ## PR checklist -Please tick as appropriate and edit the reasons (e.g.: "backport: not needed because this is a new feature") +Please remove add/remove strikethrough ~~ as appropriate, and add any relevant link/s to the end of the line. -- [ ] **changelog** provided, or not required -- [ ] **3.6 backport** done, or not required -- [ ] **2.28 backport** done, or not required -- [ ] **tests** provided, or not required +- [ ] **changelog** provided, ~~not required~~, ~~covered~~ . Link --> #XYZ +- [ ] **dev PR** provided, ~~not required~~ Link --> #XYZ +- [ ] **3.6 PR** provided, ~~not required~~ Link --> #XYZ +- [ ] **2.28** PR provided, ~~not required~~ Link --> #XYZ +- **tests** provided, ~~not required~~, ~~covered~~ Link --> #XYZ From 1deadf537e2830a6d65834252b857c573f92c04c Mon Sep 17 00:00:00 2001 From: minosgalanakis <30719586+minosgalanakis@users.noreply.github.com> Date: Fri, 3 May 2024 16:01:54 +0100 Subject: [PATCH 2/5] Update .github/pull_request_template.md Co-authored-by: Janos Follath Signed-off-by: minosgalanakis <30719586+minosgalanakis@users.noreply.github.com> --- .github/pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 506fd00f33..c5dc69a16f 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -6,7 +6,7 @@ Please write a few sentences describing the overall goals of the pull request's ## PR checklist -Please remove add/remove strikethrough ~~ as appropriate, and add any relevant link/s to the end of the line. +Please add/remove strikethrough ~~ as appropriate, and add any relevant link/s to the end of the line. - [ ] **changelog** provided, ~~not required~~, ~~covered~~ . Link --> #XYZ - [ ] **dev PR** provided, ~~not required~~ Link --> #XYZ From ad94717070a6cbce11b9247191371d7c078206ea Mon Sep 17 00:00:00 2001 From: Minos Galanakis Date: Mon, 20 May 2024 16:57:14 +0100 Subject: [PATCH 3/5] Update .github/pull_request_template.md Removed discrete link referencing and updated text entries. Signed-off-by: Minos Galanakis --- .github/pull_request_template.md | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index c5dc69a16f..36d8e1ccab 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -8,11 +8,11 @@ Please write a few sentences describing the overall goals of the pull request's Please add/remove strikethrough ~~ as appropriate, and add any relevant link/s to the end of the line. -- [ ] **changelog** provided, ~~not required~~, ~~covered~~ . Link --> #XYZ -- [ ] **dev PR** provided, ~~not required~~ Link --> #XYZ -- [ ] **3.6 PR** provided, ~~not required~~ Link --> #XYZ -- [ ] **2.28** PR provided, ~~not required~~ Link --> #XYZ -- **tests** provided, ~~not required~~, ~~covered~~ Link --> #XYZ +- [ ] **changelog** provided, ~not required because:~ +- [ ] **dev PR** provided #, ~not required because:~ +- [ ] **3.6 PR** provided #, ~not required because:~ +- [ ] **2.28 PR** provided #, ~not required because:~ +- **tests** provided, ~covered~ #, ~not required because:~ From 797e43b4f59bf4a0a30a50855b8d24644b89328b Mon Sep 17 00:00:00 2001 From: Minos Galanakis Date: Mon, 8 Jul 2024 10:46:10 +0100 Subject: [PATCH 4/5] Update .github/pull_request_template.md * Removed strike-out marks and added | symbols for selection. * Added framework tracking checkbox. Signed-off-by: Minos Galanakis --- .github/pull_request_template.md | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 36d8e1ccab..28c0ee2d9d 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -6,13 +6,15 @@ Please write a few sentences describing the overall goals of the pull request's ## PR checklist -Please add/remove strikethrough ~~ as appropriate, and add any relevant link/s to the end of the line. +Please remove the segment/s on either side of the | symbol as appropriate, and add any relevant link/s to the end of the line. +If the provided content is part of the present PR remove the # symbol. -- [ ] **changelog** provided, ~not required because:~ -- [ ] **dev PR** provided #, ~not required because:~ -- [ ] **3.6 PR** provided #, ~not required because:~ -- [ ] **2.28 PR** provided #, ~not required because:~ -- **tests** provided, ~covered~ #, ~not required because:~ +- [ ] **changelog** provided | not required because: +- [ ] **development PR** provided # | not required because: +- [ ] **framework PR** provided # | not required because: +- [ ] **3.6 PR** provided # | not required because: +- [ ] **2.28 PR** provided # | not required because: +- **tests** provided | covered # | not required because: From d53e889fc0752e8f4c92575ed798f709afe978ee Mon Sep 17 00:00:00 2001 From: Minos Galanakis Date: Thu, 11 Jul 2024 14:20:56 +0100 Subject: [PATCH 5/5] Update .github/pull_request_template.md Adjusted the framework linking line. Signed-off-by: Minos Galanakis --- .github/pull_request_template.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 28c0ee2d9d..155f114bfd 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -11,10 +11,10 @@ If the provided content is part of the present PR remove the # symbol. - [ ] **changelog** provided | not required because: - [ ] **development PR** provided # | not required because: -- [ ] **framework PR** provided # | not required because: +- [ ] **framework PR** provided Mbed-TLS/mbedtls-framework# | not required - [ ] **3.6 PR** provided # | not required because: - [ ] **2.28 PR** provided # | not required because: -- **tests** provided | covered # | not required because: +- **tests** provided | not required because: