mirror/mbedtls
1
0
Fork 0
mirror of https://github.com/Mbed-TLS/mbedtls.git synced 2025-04-16 08:42:50 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Move _public parameters next to their target

Browse Source 
It is easier to read if the parameter controlling constant timeness with
respect to a parameter is next to that parameter.

Signed-off-by: Janos Follath <janos.follath@arm.com>
This commit is contained in:
Janos Follath 2024-08-12 20:11:06 +01:00
parent 0c292b26a5
commit a5fc8f342a
2 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
library/bignum.c
View File

@ -1615,8 +1615,8 @@ int mbedtls_mpi_mod_int(mbedtls_mpi_uint *r, const mbedtls_mpi *A, mbedtls_mpi_s
* this function is not constant time with respect to the exponent (parameter E). * this function is not constant time with respect to the exponent (parameter E).
*/ */
static int mbedtls_mpi_exp_mod_optionally_safe(mbedtls_mpi *X, const mbedtls_mpi *A, static int mbedtls_mpi_exp_mod_optionally_safe(mbedtls_mpi *X, const mbedtls_mpi *A,
const mbedtls_mpi *E, const mbedtls_mpi *N, const mbedtls_mpi *E, int E_public,
mbedtls_mpi *prec_RR, int E_public) const mbedtls_mpi *N, mbedtls_mpi *prec_RR)
{ {
int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED; int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
@ -1732,14 +1732,14 @@ int mbedtls_mpi_exp_mod(mbedtls_mpi *X, const mbedtls_mpi *A,
const mbedtls_mpi *E, const mbedtls_mpi *N, const mbedtls_mpi *E, const mbedtls_mpi *N,
mbedtls_mpi *prec_RR) mbedtls_mpi *prec_RR)
{ {
return mbedtls_mpi_exp_mod_optionally_safe(X, A, E, N, prec_RR, MBEDTLS_MPI_IS_SECRET); return mbedtls_mpi_exp_mod_optionally_safe(X, A, E, MBEDTLS_MPI_IS_SECRET, N, prec_RR);
} }
int mbedtls_mpi_exp_mod_unsafe(mbedtls_mpi *X, const mbedtls_mpi *A, int mbedtls_mpi_exp_mod_unsafe(mbedtls_mpi *X, const mbedtls_mpi *A,
const mbedtls_mpi *E, const mbedtls_mpi *N, const mbedtls_mpi *E, const mbedtls_mpi *N,
mbedtls_mpi *prec_RR) mbedtls_mpi *prec_RR)
{ {
return mbedtls_mpi_exp_mod_optionally_safe(X, A, E, N, prec_RR, MBEDTLS_MPI_IS_PUBLIC); return mbedtls_mpi_exp_mod_optionally_safe(X, A, E, MBEDTLS_MPI_IS_PUBLIC, N, prec_RR);
} }
/* /*

12
library/bignum_core.c
View File

@ -817,9 +817,9 @@ static void mbedtls_mpi_core_exp_mod_optionally_safe(mbedtls_mpi_uint *X,
size_t AN_limbs, size_t AN_limbs,
const mbedtls_mpi_uint *E, const mbedtls_mpi_uint *E,
size_t E_limbs, size_t E_limbs,
int E_public,
const mbedtls_mpi_uint *RR, const mbedtls_mpi_uint *RR,
mbedtls_mpi_uint *T, mbedtls_mpi_uint *T)
int E_public)
{ {
const size_t wsize = exp_mod_get_window_size(E_limbs * biL); const size_t wsize = exp_mod_get_window_size(E_limbs * biL);
const size_t welem = ((size_t) 1) << wsize; const size_t welem = ((size_t) 1) << wsize;
@ -910,9 +910,9 @@ void mbedtls_mpi_core_exp_mod(mbedtls_mpi_uint *X,
AN_limbs, AN_limbs,
E, E,
E_limbs, E_limbs,
MBEDTLS_MPI_IS_SECRET,
RR, RR,
T, T);
MBEDTLS_MPI_IS_SECRET);
} }
void mbedtls_mpi_core_exp_mod_unsafe(mbedtls_mpi_uint *X, void mbedtls_mpi_core_exp_mod_unsafe(mbedtls_mpi_uint *X,
@ -928,9 +928,9 @@ void mbedtls_mpi_core_exp_mod_unsafe(mbedtls_mpi_uint *X,
AN_limbs, AN_limbs,
E, E,
E_limbs, E_limbs,
MBEDTLS_MPI_IS_PUBLIC,
RR, RR,
T, T);
MBEDTLS_MPI_IS_PUBLIC);
} }
mbedtls_mpi_uint mbedtls_mpi_core_sub_int(mbedtls_mpi_uint *X, mbedtls_mpi_uint mbedtls_mpi_core_sub_int(mbedtls_mpi_uint *X,