mirror/mbedtls
1
0
Fork 0
mirror of https://github.com/Mbed-TLS/mbedtls.git synced 2025-03-23 07:20:56 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Refactor mbedtls_psa_generate_key_iop_complete()

Browse Source 
- Move the checks on the size to the start of the
  function to avaoid costly calls to mbedtls_ecp_gen_privkey()
  in case of invalid size.
- Improve the readability of error checking

Signed-off-by: Waleed Elmelegy <waleed.elmelegy@arm.com>
This commit is contained in:
Waleed Elmelegy 2024-11-14 12:51:08 +00:00
parent 8666b0fbc8
commit a3ce631849
1 changed files with 9 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
tf-psa-crypto/drivers/builtin/src/psa_crypto_ecp.c
View File

@ -625,14 +625,6 @@ psa_status_t mbedtls_psa_generate_key_iop_complete(
{
*key_len = 0;
psa_status_t status = PSA_ERROR_CORRUPTION_DETECTED;
status = mbedtls_ecp_gen_privkey(&operation->ecp.grp, &operation->ecp.d,
mbedtls_psa_get_random, MBEDTLS_PSA_RANDOM_STATE);
if (status) {
return mbedtls_to_psa_error(status);
}
operation->num_ops = 1;
*key_len = PSA_BITS_TO_BYTES(operation->ecp.grp.nbits);
@ -640,6 +632,15 @@ psa_status_t mbedtls_psa_generate_key_iop_complete(
return PSA_ERROR_BUFFER_TOO_SMALL;
}
status = mbedtls_ecp_gen_privkey(&operation->ecp.grp, &operation->ecp.d,
mbedtls_psa_get_random, MBEDTLS_PSA_RANDOM_STATE);
if (status != 0) {
return mbedtls_to_psa_error(status);
}
operation->num_ops = 1;
mbedtls_mpi_write_binary(&operation->ecp.d, key_output, key_output_size);
return mbedtls_to_psa_error(status);