From a37398427b05fe7af56ec1fd0314d59aac7b5b39 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Manuel=20P=C3=A9gouri=C3=A9-Gonnard?= Date: Tue, 6 Dec 2022 09:35:54 +0100 Subject: [PATCH] Remove check for tests disabled with USE_PSA MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The previous commit declared that some tests cases in ssl-opt.sh depend on USE_PSA being disabled, which is the right thing to do. We had a check that forbade that - it was mainly meant to prevent accidental re-introduction of such dependencies after we cleaned up a number of cases where it was not warranted, but already at the time that was controversial [1]. Now it's preventing us from doing the right thing, so let's just remove it. [1]: https://github.com/Mbed-TLS/mbedtls/pull/5742#discussion_r855112412 See also https://github.com/Mbed-TLS/mbedtls/pull/5907/ which also removes this for a similar reason. Signed-off-by: Manuel Pégourié-Gonnard --- tests/scripts/all.sh | 6 ------ 1 file changed, 6 deletions(-) diff --git a/tests/scripts/all.sh b/tests/scripts/all.sh index d3eedcf35d..e1717a14b8 100755 --- a/tests/scripts/all.sh +++ b/tests/scripts/all.sh @@ -871,12 +871,6 @@ component_check_test_cases () { fi tests/scripts/check_test_cases.py $opt unset opt - - # Check that no tests are explicitely disabled when USE_PSA_CRYPTO is set - # as a matter of policy to ensure there is no missed testing - msg "Check: explicitely disabled test with USE_PSA_CRYPTO" # < 1s - not grep -n 'depends_on:.*!MBEDTLS_USE_PSA_CRYPTO' tests/suites/*.function tests/suites/*.data - not grep -n '^ *requires_config_disabled.*MBEDTLS_USE_PSA_CRYPTO' tests/ssl-opt.sh tests/opt-testcases/*.sh } component_check_doxygen_warnings () {