mirror/mbedtls
1
0
Fork 0
mirror of https://github.com/Mbed-TLS/mbedtls.git synced 2025-02-09 21:40:43 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

psa: rsa: import: Move key buffer allocation

Browse Source 
Move key buffer allocation from RSA specific
importation function up to psa_import_key_into_slot().

Signed-off-by: Ronald Cron <ronald.cron@arm.com>
This commit is contained in:
Ronald Cron 2020-11-07 18:22:09 +01:00
parent f1057d3589
commit 8f813ee8d8
1 changed files with 21 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

46
library/psa_crypto.c
View File

@ -541,13 +541,19 @@ static psa_status_t validate_unstructured_key_bit_size( psa_key_type_t type,
* \param[in,out] slot The slot where to store the export representation to * \param[in,out] slot The slot where to store the export representation to
* \param[in] data The buffer containing the import representation * \param[in] data The buffer containing the import representation
* \param[in] data_length The amount of bytes in \p data * \param[in] data_length The amount of bytes in \p data
* \param[out] key_buffer The buffer containing the export representation
* \param[in] key_buffer_size The size of \p key_buffer in bytes
* \param[out] key_buffer_length The length of the data written in the key
* buffer in bytes.
*/ */
static psa_status_t psa_import_rsa_key( psa_key_slot_t *slot, static psa_status_t psa_import_rsa_key( psa_key_slot_t *slot,
const uint8_t *data, const uint8_t *data,
size_t data_length ) size_t data_length,
uint8_t *key_buffer,
size_t key_buffer_size,
size_t *key_buffer_length )
{ {
psa_status_t status; psa_status_t status;
uint8_t* output = NULL;
mbedtls_rsa_context *rsa = NULL; mbedtls_rsa_context *rsa = NULL;
/* Parse input */ /* Parse input */
@ -565,35 +571,17 @@ static psa_status_t psa_import_rsa_key( psa_key_slot_t *slot,
* representation in the key slot. Export representation in case of RSA is * representation in the key slot. Export representation in case of RSA is
* the smallest representation that's allowed as input, so a straight-up * the smallest representation that's allowed as input, so a straight-up
* allocation of the same size as the input buffer will be large enough. */ * allocation of the same size as the input buffer will be large enough. */
output = mbedtls_calloc( 1, data_length );
if( output == NULL )
{
status = PSA_ERROR_INSUFFICIENT_MEMORY;
goto exit;
}
status = mbedtls_psa_rsa_export_key( slot->attr.type, status = mbedtls_psa_rsa_export_key( slot->attr.type,
rsa, rsa,
output, key_buffer,
data_length, key_buffer_size,
&data_length); key_buffer_length );
exit: exit:
/* Always free the RSA object */ /* Always free the RSA object */
mbedtls_rsa_free( rsa ); mbedtls_rsa_free( rsa );
mbedtls_free( rsa ); mbedtls_free( rsa );
/* Free the allocated buffer only on error. */ return( status );
if( status != PSA_SUCCESS )
{
mbedtls_free( output );
return( status );
}
/* On success, store the allocated export-formatted key. */
slot->key.data = output;
slot->key.bytes = data_length;
return( PSA_SUCCESS );
} }
#endif /* defined(MBEDTLS_PSA_BUILTIN_KEY_TYPE_RSA_KEY_PAIR) || #endif /* defined(MBEDTLS_PSA_BUILTIN_KEY_TYPE_RSA_KEY_PAIR) ||
@ -827,7 +815,15 @@ static psa_status_t psa_import_key_into_slot( psa_key_slot_t *slot,
defined(MBEDTLS_PSA_BUILTIN_KEY_TYPE_RSA_PUBLIC_KEY) defined(MBEDTLS_PSA_BUILTIN_KEY_TYPE_RSA_PUBLIC_KEY)
if( PSA_KEY_TYPE_IS_RSA( slot->attr.type ) ) if( PSA_KEY_TYPE_IS_RSA( slot->attr.type ) )
{ {
return( psa_import_rsa_key( slot, data, data_length ) ); status = psa_allocate_buffer_to_slot( slot, data_length );
if( status != PSA_SUCCESS )
return( status );
status = psa_import_rsa_key( slot,
data, data_length,
slot->key.data, data_length,
&slot->key.bytes );
return( status );
} }
#endif /* defined(MBEDTLS_PSA_BUILTIN_KEY_TYPE_RSA_KEY_PAIR) || #endif /* defined(MBEDTLS_PSA_BUILTIN_KEY_TYPE_RSA_KEY_PAIR) ||
* defined(MBEDTLS_PSA_BUILTIN_KEY_TYPE_RSA_PUBLIC_KEY) */ * defined(MBEDTLS_PSA_BUILTIN_KEY_TYPE_RSA_PUBLIC_KEY) */