mirror/mbedtls
1
0
Fork 0
mirror of https://github.com/Mbed-TLS/mbedtls.git synced 2025-01-06 07:10:41 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

pkarse: Added pk_group_id_from_specified() documentation.

Browse Source 
Signed-off-by: Minos Galanakis <minos.galanakis@arm.com>
This commit is contained in:
Minos Galanakis 2023-01-20 15:27:32 +00:00
parent c8e381ab1c
commit 8692ec8bc0
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
library/pkparse.c
View File

@ -429,6 +429,13 @@ static int pk_group_id_from_specified(const mbedtls_asn1_buf *params,
ret = pk_group_id_from_group(&grp, grp_id); ret = pk_group_id_from_group(&grp, grp_id);
cleanup: cleanup:
/* The API respecting lifecycle for mbedtls_ecp_group struct is
* _init(), _load() and _free(). In pk_group_id_from_specified() the
* temporary grp breaks that flow and it's members are populated
* by pk_group_id_from_group(). As such mbedtls_ecp_group_free()
* which is assuming a group populated by _setup() may not clean-up
* properly -> Manually free it's members.
*/
mbedtls_mpi_free(&grp.N); mbedtls_mpi_free(&grp.N);
mbedtls_mpi_free(&grp.P); mbedtls_mpi_free(&grp.P);
mbedtls_mpi_free(&grp.A); mbedtls_mpi_free(&grp.A);