mirror/mbedtls
1
0
Fork 0
mirror of https://github.com/Mbed-TLS/mbedtls.git synced 2025-01-26 21:35:35 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

mbedtls_mpi_mod_write: improve readability

Browse Source 
Signed-off-by: Janos Follath <janos.follath@arm.com>
This commit is contained in:
Janos Follath 2022-11-28 10:27:14 +00:00
parent e7190a2960
commit 84bee4c492
1 changed files with 11 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
library/bignum_mod.c
View File

@ -230,7 +230,6 @@ int mbedtls_mpi_mod_write( const mbedtls_mpi_mod_residue *r,
mbedtls_mpi_mod_ext_rep ext_rep ) mbedtls_mpi_mod_ext_rep ext_rep )
{ {
int ret = MBEDTLS_ERR_MPI_BAD_INPUT_DATA; int ret = MBEDTLS_ERR_MPI_BAD_INPUT_DATA;
int conv_ret = 0;
/* Do our best to check if r and m have been set up */ /* Do our best to check if r and m have been set up */
if( r->limbs == 0 || m->limbs == 0 ) if( r->limbs == 0 || m->limbs == 0 )
@ -240,21 +239,26 @@ int mbedtls_mpi_mod_write( const mbedtls_mpi_mod_residue *r,
if( m->int_rep == MBEDTLS_MPI_MOD_REP_MONTGOMERY ) if( m->int_rep == MBEDTLS_MPI_MOD_REP_MONTGOMERY )
{ {
conv_ret = mbedtls_mpi_mod_raw_from_mont_rep( r->p, m ); ret = mbedtls_mpi_mod_raw_from_mont_rep( r->p, m );
if( conv_ret != 0 ) if( ret != 0 )
goto cleanup; goto cleanup;
} }
ret = mbedtls_mpi_mod_raw_write( r->p, m, buf, buflen, ext_rep ); ret = mbedtls_mpi_mod_raw_write( r->p, m, buf, buflen, ext_rep );
if( m->int_rep == MBEDTLS_MPI_MOD_REP_MONTGOMERY ) if( m->int_rep == MBEDTLS_MPI_MOD_REP_MONTGOMERY )
conv_ret = mbedtls_mpi_mod_raw_to_mont_rep( r->p, m ); {
/* If this fails, the value of r is corrupted and we want to return
* this error (as opposed to the error code from the write above) to
* let the caller know. If it succeeds, we want to return the error
* code from write above. */
int conv_ret = mbedtls_mpi_mod_raw_to_mont_rep( r->p, m );
if( ret == 0 )
ret = conv_ret;
}
cleanup: cleanup:
if( ret == 0 )
ret = conv_ret;
return ( ret ); return ( ret );
} }
/* END MERGE SLOT 7 */ /* END MERGE SLOT 7 */