mirror/mbedtls
1
0
Fork 0
mirror of https://github.com/Mbed-TLS/mbedtls.git synced 2025-02-21 15:41:00 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Reallocate X_raw to enforce no overflow

Browse Source 
Signed-off-by: Werner Lewis <werner.lewis@arm.com>
This commit is contained in:
Werner Lewis 2022-12-13 17:19:01 +00:00
parent eed01aabd3
commit 79341a4e7e
1 changed files with 13 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
tests/suites/test_suite_bignum_mod.function
View File

@ -237,30 +237,40 @@ void mpi_mod_add( char * input_N,
size_t limbs = m.limbs;
size_t bytes = limbs * sizeof( *X_raw );
/* One spare limb for negative testing */
ASSERT_ALLOC( X_raw, limbs + 1 );
if( expected_ret == 0 )
{
/* Negative test with too many limbs in output */
ASSERT_ALLOC( X_raw, limbs + 1 );
x.p = X_raw;
x.limbs = limbs + 1;
TEST_EQUAL( MBEDTLS_ERR_MPI_BAD_INPUT_DATA,
mbedtls_mpi_mod_add( &x, &a, &b, &m ) );
mbedtls_free( X_raw );
X_raw = NULL;
/* Negative test with too few limbs in output */
if( limbs > 1 )
{
ASSERT_ALLOC( X_raw, limbs - 1 );
x.p = X_raw;
x.limbs = limbs - 1;
TEST_EQUAL( MBEDTLS_ERR_MPI_BAD_INPUT_DATA,
mbedtls_mpi_mod_add( &x, &a, &b, &m ) );
mbedtls_free( X_raw );
X_raw = NULL;
}
/* Negative testing with too many/too few limbs in a and b is covered by
* manually-written test cases with oret != 0. */
}
/* Allocate correct number of limbs for X_raw */
ASSERT_ALLOC( X_raw, limbs );
TEST_EQUAL( 0, mbedtls_mpi_mod_residue_setup( &x, &m, X_raw, limbs ) );
/* A + B => Correct result or expected error */