mirror/mbedtls
1
0
Fork 0
mirror of https://github.com/Mbed-TLS/mbedtls.git synced 2025-03-28 19:21:08 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #7807 from gilles-peskine-arm/mbedtls_ssl_protocol_version_str-no_array

Browse Source 
Fix very high stack usage in SSL debug code
This commit is contained in:
Gilles Peskine 2023-06-26 09:36:53 +02:00 committed by GitHub
commit 717a83164e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
ChangeLog.d/ssl_debug_helpers-stack_usage.txt Normal file
View File

@ -0,0 +1,3 @@
Bugfix
* Fix very high stack usage in SSL debug code. Reported by Maximilian
Gerhardt in #7804.

16
scripts/generate_ssl_debug_helpers.py
View File

@ -209,24 +209,18 @@ class EnumDefinition:
continue continue
member = field.strip().split()[0] member = field.strip().split()[0]
translation_table.append( translation_table.append(
'{space}[{member}] = "{member}",'.format(member=member, '{space}case {member}:\n{space} return "{member}";'
space=' '*8) .format(member=member, space=' '*8)
) )
body = textwrap.dedent('''\ body = textwrap.dedent('''\
const char *{name}_str( {prototype} in ) const char *{name}_str( {prototype} in )
{{ {{
const char * in_to_str[]= switch (in) {{
{{
{translation_table} {translation_table}
}}; default:
return "UNKNOWN_VALUE";
if( in > ( sizeof( in_to_str )/sizeof( in_to_str[0]) - 1 ) ||
in_to_str[ in ] == NULL )
{{
return "UNKNOWN_VALUE";
}} }}
return in_to_str[ in ];
}} }}
''') ''')
body = body.format(translation_table='\n'.join(translation_table), body = body.format(translation_table='\n'.join(translation_table),