From 6d40e54db0cf3e7e16ea9fe3ca4a03d85e04c4fc Mon Sep 17 00:00:00 2001
From: Gilles Peskine <Gilles.Peskine@arm.com>
Date: Wed, 21 Dec 2022 20:18:23 +0100
Subject: [PATCH] Split the high nesting of
BignumModRawConvertRep.generate_function_tests
Pylint complains about the nesting. It's not wrong.
No behavior change.
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
---
scripts/mbedtls_dev/bignum_mod_raw.py | 25 +++++++++++++++----------
1 file changed, 15 insertions(+), 10 deletions(-)
diff --git a/scripts/mbedtls_dev/bignum_mod_raw.py b/scripts/mbedtls_dev/bignum_mod_raw.py
index 89ae825fc4..352e438ab9 100644
--- a/scripts/mbedtls_dev/bignum_mod_raw.py
+++ b/scripts/mbedtls_dev/bignum_mod_raw.py
@@ -131,22 +131,27 @@ class BignumModRawConvertRep(bignum_common.ModOperationCommon,
mod_with_rep = 'mod({})'.format(self.rep.name)
return base.replace('mod', mod_with_rep, 1)
+ @classmethod
+ def test_cases_for_values(cls, rep: bignum_common.ModulusRepresentation,
+ n: str, a: str) -> Iterator[test_case.TestCase]:
+ for bil in cls.limb_sizes:
+ test_object = cls(n, a, bits_in_limb=bil)
+ test_object.set_representation(rep)
+ #Filters out the duplicate
+ if rep == bignum_common.ModulusRepresentation.OPT_RED:
+ test_object.dependencies= []
+ if bil == 64:
+ continue
+ if test_object.is_valid:
+ yield test_object.create_test_case()
+
@classmethod
def generate_function_tests(cls) -> Iterator[test_case.TestCase]:
for rep in bignum_common.ModulusRepresentation.supported_representations():
for n in cls.moduli:
for a in cls.input_values:
- for bil in cls.limb_sizes:
- test_object = cls(n, a, bits_in_limb=bil)
- test_object.set_representation(rep)
- #Filters out the duplicate
- if rep == bignum_common.ModulusRepresentation.OPT_RED:
- test_object.dependencies= []
- if bil == 64:
- continue
- if test_object.is_valid:
- yield test_object.create_test_case()
+ yield from cls.test_cases_for_values(rep, n, a)
class BignumModRawCanonicalToModulusRep(BignumModRawConvertRep):
"""Test cases for mpi_mod_raw_canonical_to_modulus_rep."""