mirror/mbedtls
1
0
Fork 0
mirror of https://github.com/Mbed-TLS/mbedtls.git synced 2025-04-01 04:20:45 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Tidy up, remove MPI_CORE(), apply the naming convention, and use the new mbedtls_mpi_core_mul()

Browse Source 
Signed-off-by: Tom Cosgrove <tom.cosgrove@arm.com>
Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>
This commit is contained in:
Tom Cosgrove 2022-08-24 16:40:55 +01:00 committed by Gabor Mezei
parent 4ae890bbd0
commit 6af26f3838
No known key found for this signature in database
GPG Key ID: F072ACA227ACD71D
3 changed files with 23 additions and 28 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
library/bignum.c
View File

@ -1136,7 +1136,8 @@ int mbedtls_mpi_mul_mpi(mbedtls_mpi *X, const mbedtls_mpi *A, const mbedtls_mpi
MPI_VALIDATE_RET(A != NULL); MPI_VALIDATE_RET(A != NULL);
MPI_VALIDATE_RET(B != NULL); MPI_VALIDATE_RET(B != NULL);
mbedtls_mpi_init(&TA); mbedtls_mpi_init(&TB); mbedtls_mpi_init(&TA);
mbedtls_mpi_init(&TB);
if (X == A) { if (X == A) {
MBEDTLS_MPI_CHK(mbedtls_mpi_copy(&TA, A)); A = &TA; MBEDTLS_MPI_CHK(mbedtls_mpi_copy(&TA, A)); A = &TA;
@ -1166,13 +1167,7 @@ int mbedtls_mpi_mul_mpi(mbedtls_mpi *X, const mbedtls_mpi *A, const mbedtls_mpi
MBEDTLS_MPI_CHK(mbedtls_mpi_grow(X, i + j)); MBEDTLS_MPI_CHK(mbedtls_mpi_grow(X, i + j));
MBEDTLS_MPI_CHK(mbedtls_mpi_lset(X, 0)); MBEDTLS_MPI_CHK(mbedtls_mpi_lset(X, 0));
for (size_t k = 0; k < j; k++) { mbedtls_mpi_core_mul(X->p, A->p, i, B->p, j);
/* We know that there cannot be any carry-out since we're
* iterating from bottom to top. */
(void) mbedtls_mpi_core_mla(X->p + k, i + 1,
A->p, i,
B->p[k]);
}
/* If the result is 0, we don't shortcut the operation, which reduces /* If the result is 0, we don't shortcut the operation, which reduces
* but does not eliminate side channels leaking the zero-ness. We do * but does not eliminate side channels leaking the zero-ness. We do

14
library/bignum_core.c
View File

@ -448,13 +448,15 @@ mbedtls_mpi_uint mbedtls_mpi_core_mla(mbedtls_mpi_uint *d, size_t d_len,
return c; return c;
} }
void MPI_CORE(mul)( mbedtls_mpi_uint *X, void mbedtls_mpi_core_mul(mbedtls_mpi_uint *X,
const mbedtls_mpi_uint *A, size_t a, const mbedtls_mpi_uint *A, size_t A_limbs,
const mbedtls_mpi_uint *B, size_t b ) const mbedtls_mpi_uint *B, size_t B_limbs)
{ {
memset( X, 0, ( a + b ) * ciL ); memset(X, 0, (A_limbs + B_limbs) * ciL);
for( size_t i=0; i < b; i++ )
(void) mbedtls_mpi_core_mla( X + i, a + 1, A, a, B[i] ); for (size_t i = 0; i < B_limbs; i++) {
(void) mbedtls_mpi_core_mla(X + i, A_limbs + 1, A, A_limbs, B[i]);
}
} }
/* /*

26
library/bignum_core.h
View File

@ -398,24 +398,22 @@ mbedtls_mpi_uint mbedtls_mpi_core_mla(mbedtls_mpi_uint *X, size_t X_limbs,
const mbedtls_mpi_uint *A, size_t A_limbs, const mbedtls_mpi_uint *A, size_t A_limbs,
mbedtls_mpi_uint b); mbedtls_mpi_uint b);
#define MPI_CORE(func) mbedtls_mpi_core_ ## func ## _minimal
/** /**
* \brief Perform a known-size multiplication * \brief Perform a known-size multiplication
* *
* \param[out] X The pointer to the (little-endian) array * \param[out] X The pointer to the (little-endian) array to receive
* representing the product of \p a and \p b. * the product of \p A_limbs and \p B_limbs.
* This must be of length \p a + \p b. * This must be of length \p A_limbs + \p B_limbs.
* \param[in] A The pointer to the (little-endian) array * \param[in] A The pointer to the (little-endian) array
* representing the first factor. * representing the first factor.
* \param a The number of limbs in \p A. * \param A_limbs The number of limbs in \p A.
* \param[in] B The pointer to the (little-endian) array * \param[in] B The pointer to the (little-endian) array
* representing the second factor. * representing the second factor.
* \param b The number of limbs in \p B. * \param B_limbs The number of limbs in \p B.
*/ */
void MPI_CORE(mul)( mbedtls_mpi_uint *X, void mbedtls_mpi_core_mul(mbedtls_mpi_uint *X,
const mbedtls_mpi_uint *A, size_t a, const mbedtls_mpi_uint *A, size_t A_limbs,
const mbedtls_mpi_uint *B, size_t b ); const mbedtls_mpi_uint *B, size_t B_limbs);
/** /**
* \brief Calculate initialisation value for fast Montgomery modular * \brief Calculate initialisation value for fast Montgomery modular