Fix typos and comments

Signed-off-by: Przemek Stekiel <przemyslaw.stekiel@mobica.com>
This commit is contained in:
Przemek Stekiel 2022-11-09 10:50:29 +01:00
parent a380b06c26
commit 6856f4c70d

View File

@ -63,7 +63,7 @@ def analyze_coverage(results, outcomes):
def analyze_driver_vs_reference(outcomes, components, ignored_tests): def analyze_driver_vs_reference(outcomes, components, ignored_tests):
"""Check that all tests executed in the reference component are also """Check that all tests executed in the reference component are also
executed in the corresponding driver component. executed in the corresponding driver component.
Skip test suits provided in ignored_tests list. Skip test suites provided in ignored_tests list.
""" """
driver_component = components[0] driver_component = components[0]
reference_component = components[1] reference_component = components[1]
@ -72,9 +72,9 @@ def analyze_driver_vs_reference(outcomes, components, ignored_tests):
for key in available: for key in available:
# Skip ignored test suites # Skip ignored test suites
test_suit = key.split(';')[0] # retrieve test suit name test_suite = key.split(';')[0] # retrieve test suit name
test_suit = test_suit.split('.')[0] # retrieve main part of test suit name test_suite = test_suite.split('.')[0] # retrieve main part of test suit name
if test_suit in ignored_tests: if test_suite in ignored_tests:
continue continue
# Continue if test was not executed by any component # Continue if test was not executed by any component
hits = outcomes[key].hits() if key in outcomes else 0 hits = outcomes[key].hits() if key in outcomes else 0
@ -88,8 +88,6 @@ def analyze_driver_vs_reference(outcomes, components, ignored_tests):
driver_test_passed = True driver_test_passed = True
if reference_component in entry: if reference_component in entry:
reference_test_passed = True reference_test_passed = True
#if(driver_test_passed is True and reference_test_passed is False):
# print('{}: driver: passed; reference: skipped'.format(key))
if(driver_test_passed is False and reference_test_passed is True): if(driver_test_passed is False and reference_test_passed is True):
print('{}: driver: skipped/failed; reference: passed'.format(key)) print('{}: driver: skipped/failed; reference: passed'.format(key))
result = False result = False
@ -123,7 +121,7 @@ by a semicolon.
return outcomes return outcomes
def do_analyze_coverage(outcome_file, args): def do_analyze_coverage(outcome_file, args):
"""Perform coverage analyze.""" """Perform coverage analysis."""
del args # unused del args # unused
outcomes = read_outcome_file(outcome_file) outcomes = read_outcome_file(outcome_file)
results = analyze_outcomes(outcomes) results = analyze_outcomes(outcomes)
@ -141,7 +139,7 @@ def do_analyze_driver_vs_reference(outcome_file, args):
outcomes = read_outcome_file(outcome_file) outcomes = read_outcome_file(outcome_file)
return analyze_driver_vs_reference(outcomes, components, ignored_tests) return analyze_driver_vs_reference(outcomes, components, ignored_tests)
# List of tasks with function that can handle this task and additional arguments if required # List of tasks with a function that can handle this task and additional arguments if required
# pylint: disable=line-too-long # pylint: disable=line-too-long
TASKS = { TASKS = {
'analyze_coverage': { 'analyze_coverage': {
@ -161,7 +159,7 @@ def main():
parser.add_argument('outcomes', metavar='OUTCOMES.CSV', parser.add_argument('outcomes', metavar='OUTCOMES.CSV',
help='Outcome file to analyze') help='Outcome file to analyze')
parser.add_argument('--task', default='all', parser.add_argument('--task', default='all',
help='Analyze to be done: all or analyze_coverage or ' help='Analysis to be done: all or analyze_coverage or '
'analyze_driver_vs_reference_hash') 'analyze_driver_vs_reference_hash')
options = parser.parse_args() options = parser.parse_args()