mirror/mbedtls
1
0
Fork 0
mirror of https://github.com/Mbed-TLS/mbedtls.git synced 2025-03-16 13:20:51 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Switch error code to more appropriate value

Browse Source 
Since we are internal rather than user-facing,
PSA_ERROR_CORRUPTION_DETECTED makes more sense than
PSA_ERROR_BUFFER_TOO_SMALL. Whilst it really is a buffer that is too
small, this error code is intended to indicate that a user-supplied
buffer is too small, not an internal one.

Signed-off-by: David Horstmann <david.horstmann@arm.com>
This commit is contained in:
David Horstmann 2023-11-03 19:51:40 +00:00
parent 86cdc7646d
commit 49a7276c49
3 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
library/psa_crypto.c
View File

@ -8446,7 +8446,7 @@ psa_status_t psa_crypto_copy_input(const uint8_t *input, size_t input_len,
uint8_t *input_copy, size_t input_copy_len)
{
if (input_len > input_copy_len) {
return PSA_ERROR_BUFFER_TOO_SMALL;
return PSA_ERROR_CORRUPTION_DETECTED;
}
memcpy(input_copy, input, input_len);
@ -8458,7 +8458,7 @@ psa_status_t psa_crypto_copy_output(const uint8_t *output_copy, size_t output_co
uint8_t *output, size_t output_len)
{
if (output_len < output_copy_len) {
return PSA_ERROR_BUFFER_TOO_SMALL;
return PSA_ERROR_CORRUPTION_DETECTED;
}
memcpy(output, output_copy, output_copy_len);
return PSA_SUCCESS;

6
library/psa_crypto_core.h
View File

@ -862,8 +862,8 @@ psa_status_t mbedtls_psa_verify_hash_abort(
* \param[out] input_copy_len Length of the local copy buffer.
* \return #PSA_SUCCESS, if the buffer was successfully
* copied.
* \return #PSA_ERROR_BUFFER_TOO_SMALL, if the local copy
* is too small to hold contents of the
* \return #PSA_ERROR_CORRUPTION_DETECTED, if the local
* copy is too small to hold contents of the
* input buffer.
*/
psa_status_t psa_crypto_copy_input(const uint8_t *input, size_t input_len,
@ -877,7 +877,7 @@ psa_status_t psa_crypto_copy_input(const uint8_t *input, size_t input_len,
* \param[out] output_len Length of the user-supplied output buffer.
* \return #PSA_SUCCESS, if the buffer was successfully
* copied.
* \return #PSA_ERROR_BUFFER_TOO_SMALL, if the
* \return #PSA_ERROR_CORRUPTION_DETECTED, if the
* user-supplied output buffer is too small to
* hold the contents of the local buffer.
*/

4
tests/suites/test_suite_psa_crypto.data
View File

@ -7414,7 +7414,7 @@ PSA input buffer copy: copy buffer larger than required
copy_input:10:20:PSA_SUCCESS
PSA input buffer copy: copy buffer too small
copy_input:20:10:PSA_ERROR_BUFFER_TOO_SMALL
copy_input:20:10:PSA_ERROR_CORRUPTION_DETECTED
PSA input buffer copy: zero-length source buffer
copy_input:0:10:PSA_SUCCESS
@ -7429,7 +7429,7 @@ PSA output buffer copy: output buffer larger than required
copy_output:10:20:PSA_SUCCESS
PSA output buffer copy: output buffer too small
copy_output:20:10:PSA_ERROR_BUFFER_TOO_SMALL
copy_output:20:10:PSA_ERROR_CORRUPTION_DETECTED
PSA output buffer copy: zero-length source buffer
copy_output:0:10:PSA_SUCCESS