From 3e81411122e951793c9d5412a58641f9df49c524 Mon Sep 17 00:00:00 2001 From: Elena Uziunaite Date: Thu, 18 Jul 2024 14:40:43 +0300 Subject: [PATCH] Remove test_valgrind_constant_flow_psa_no_asm + typo fix Signed-off-by: Elena Uziunaite --- include/mbedtls/check_config.h | 2 +- tests/scripts/components-sanitizers.sh | 25 ------------------------- 2 files changed, 1 insertion(+), 26 deletions(-) diff --git a/include/mbedtls/check_config.h b/include/mbedtls/check_config.h index 7b5a702fca..d1e841cb3a 100644 --- a/include/mbedtls/check_config.h +++ b/include/mbedtls/check_config.h @@ -246,7 +246,7 @@ #error "MBEDTLS_TEST_CONSTANT_FLOW_MEMSAN requires building with MemorySanitizer" #endif #if defined(MBEDTLS_HAS_MEMSAN) && defined(MBEDTLS_HAVE_ASM) -#error "MEMSAN does not support assembly implementation" +#error "MemorySanitizer does not support assembly implementation" #endif #undef MBEDTLS_HAS_MEMSAN // temporary macro defined above diff --git a/tests/scripts/components-sanitizers.sh b/tests/scripts/components-sanitizers.sh index 5b55496aa6..a3c150b463 100644 --- a/tests/scripts/components-sanitizers.sh +++ b/tests/scripts/components-sanitizers.sh @@ -158,31 +158,6 @@ component_release_test_valgrind_constant_flow_psa () { make memcheck } -component_release_test_valgrind_constant_flow_psa_no_asm () { - # This tests both (1) everything that valgrind's memcheck usually checks - # (heap buffer overflows, use of uninitialized memory, use-after-free, - # etc.) and (2) branches or memory access depending on secret values, - # which will be reported as uninitialized memory. To distinguish between - # secret and actually uninitialized: - # - unset MBEDTLS_TEST_CONSTANT_FLOW_VALGRIND - does the failure persist? - # - or alternatively, build with debug info and manually run the offending - # test suite with valgrind --track-origins=yes, then check if the origin - # was TEST_CF_SECRET() or something else. - msg "build: cmake release GCC, full config minus MBEDTLS_HAVE_ASM with constant flow testing" - scripts/config.py full - scripts/config.py set MBEDTLS_TEST_CONSTANT_FLOW_VALGRIND - scripts/config.py unset MBEDTLS_AESNI_C - scripts/config.py unset MBEDTLS_HAVE_ASM - skip_suites_without_constant_flow - cmake -D CMAKE_BUILD_TYPE:String=Release . - make - - # this only shows a summary of the results (how many of each type) - # details are left in Testing//DynamicAnalysis.xml - msg "test: some suites (full minus MBEDTLS_HAVE_ASM, valgrind + constant flow)" - make memcheck -} - component_test_tsan () { msg "build: TSan (clang)" scripts/config.py full