From 0fdb4044504b215c44e98321054dc15a049b8735 Mon Sep 17 00:00:00 2001 From: Harry Ramsey Date: Tue, 10 Dec 2024 09:58:23 +0000 Subject: [PATCH 1/2] Fix incorrect submodule error message in Makefile This commit fixes a condition where the incorrect submodule error message was displayed as the check for the directory returns true only if the directory does not exist Signed-off-by: Harry Ramsey --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 4615a44f6a..b0040df8b6 100644 --- a/Makefile +++ b/Makefile @@ -6,7 +6,7 @@ ifneq (,$(filter-out lib library/%,$(or $(MAKECMDGOALS),all))) ifeq (,$(wildcard framework/exported.make)) # Use the define keyword to get a multi-line message. # GNU make appends ". Stop.", so tweak the ending of our message accordingly. - ifeq (,$(wildcard .git)) + ifneq (,$(wildcard .git)) define error_message ${MBEDTLS_PATH}/framework/exported.make not found (and does appear to be a git checkout). Run `git submodule update --init` from the source tree to fetch the submodule contents. This is a fatal error From f0dedbaa47e3975533963724127a5dac4c6c413f Mon Sep 17 00:00:00 2001 From: Harry Ramsey Date: Tue, 10 Dec 2024 15:32:04 +0000 Subject: [PATCH 2/2] Fix incorrect submodule error message in CMake This commit fixes a condition where the incorrect submodule error message was displayed. Signed-off-by: Harry Ramsey --- CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index c6d31dc114..5ab75b10a7 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -315,7 +315,7 @@ if(LIB_INSTALL_DIR) endif() if (NOT EXISTS "${CMAKE_CURRENT_SOURCE_DIR}/framework/CMakeLists.txt") - if (EXISTS "${CMAKE_CURRENT_SOURCE_DIR}/.git/") + if (EXISTS "${CMAKE_CURRENT_SOURCE_DIR}/.git") message(FATAL_ERROR "${CMAKE_CURRENT_SOURCE_DIR}CMakeLists.txt not found (and does appear to be a git checkout). Run `git submodule update --init` from the source tree to fetch the submodule contents.") else () message(FATAL_ERROR "${CMAKE_CURRENT_SOURCE_DIR}/CMakeLists.txt not found (and does not appear to be a git checkout). Please ensure you have downloaded the right archive from the release page on GitHub.")