mirror/mbedtls
1
0
Fork 0
mirror of https://github.com/Mbed-TLS/mbedtls.git synced 2025-02-19 18:39:55 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Remove unnecessary if to save 16 bytes

Browse Source 
Signed-off-by: Dave Rodgman <dave.rodgman@arm.com>
This commit is contained in:
Dave Rodgman 2023-04-25 17:34:59 +01:00
parent 0f16d560aa
commit 2e863ecde9
3 changed files with 12 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
library/bignum_core.c
View File

@ -71,12 +71,10 @@ size_t mbedtls_mpi_core_bitlen(const mbedtls_mpi_uint *A, size_t A_limbs)
int i;
size_t j;
if (A_limbs != 0) {
for (i = (int) A_limbs - 1; i >= 0; i--) {
if (A[i] != 0) {
j = biL - mbedtls_mpi_core_clz(A[i]);
return (i * biL) + j;
}
for (i = ((int) A_limbs) - 1; i >= 0; i--) {
if (A[i] != 0) {
j = biL - mbedtls_mpi_core_clz(A[i]);
return (i * biL) + j;
}
}

6
tests/suites/test_suite_bignum_core.function
View File

@ -301,7 +301,11 @@ void mpi_core_bitlen(char *input_X, int nr_bits)
mbedtls_mpi_uint *X = NULL;
size_t limbs;
TEST_EQUAL(mbedtls_test_read_mpi_core(&X, &limbs, input_X), 0);
if (strlen(input_X) == 0) {
limbs = 0;
} else {
TEST_EQUAL(mbedtls_test_read_mpi_core(&X, &limbs, input_X), 0);
}
TEST_EQUAL(mbedtls_mpi_core_bitlen(X, limbs), nr_bits);
exit:

3
tests/suites/test_suite_bignum_core.misc.data
View File

@ -155,6 +155,9 @@ mpi_core_bitlen:"10":5
Test mbedtls_mpi_core_bitlen 0x0a
mpi_core_bitlen:"a":4
Test mbedtls_mpi_core_bitlen: 0 limbs
mpi_core_bitlen:"":0
Test mbedtls_mpi_core_bitlen: 0 (1 limb)
mpi_core_bitlen:"0":0