From 285f85f962de082084d5ed4c82848a4a7df34959 Mon Sep 17 00:00:00 2001 From: Agathiyan Bragadeesh Date: Wed, 16 Aug 2023 17:15:48 +0100 Subject: [PATCH 1/7] Remove unnecessary const type qualifiers in casts Signed-off-by: Agathiyan Bragadeesh --- library/constant_time_impl.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/library/constant_time_impl.h b/library/constant_time_impl.h index 0c3cde99d1..ea3669b8a6 100644 --- a/library/constant_time_impl.h +++ b/library/constant_time_impl.h @@ -189,8 +189,8 @@ static inline unsigned char mbedtls_ct_uchar_in_range_if(unsigned char low, unsigned char c, unsigned char t) { - const unsigned char co = (const unsigned char) mbedtls_ct_compiler_opaque(c); - const unsigned char to = (const unsigned char) mbedtls_ct_compiler_opaque(t); + const unsigned char co= (unsigned char) mbedtls_ct_compiler_opaque(c); + const unsigned char to= (unsigned char) mbedtls_ct_compiler_opaque(t); /* low_mask is: 0 if low <= c, 0x...ff if low > c */ unsigned low_mask = ((unsigned) co - low) >> 8; From da8c587531132d01e00f500ac9e1ea3cbec059b6 Mon Sep 17 00:00:00 2001 From: Agathiyan Bragadeesh Date: Thu, 17 Aug 2023 09:37:46 +0100 Subject: [PATCH 2/7] Add ChangeLog entry Signed-off-by: Agathiyan Bragadeesh --- ChangeLog.d/fix-iar-compiler-warnings.txt | 2 ++ 1 file changed, 2 insertions(+) create mode 100644 ChangeLog.d/fix-iar-compiler-warnings.txt diff --git a/ChangeLog.d/fix-iar-compiler-warnings.txt b/ChangeLog.d/fix-iar-compiler-warnings.txt new file mode 100644 index 0000000000..b0bd3e1dfa --- /dev/null +++ b/ChangeLog.d/fix-iar-compiler-warnings.txt @@ -0,0 +1,2 @@ +Bugfix + * Improve general IAR support \ No newline at end of file From 9ebfa7f64cf3e8749892676e94ad8060fb94844a Mon Sep 17 00:00:00 2001 From: Agathiyan Bragadeesh Date: Thu, 17 Aug 2023 10:00:01 +0100 Subject: [PATCH 3/7] Fix style Signed-off-by: Agathiyan Bragadeesh --- library/constant_time_impl.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/library/constant_time_impl.h b/library/constant_time_impl.h index ea3669b8a6..b251a664c0 100644 --- a/library/constant_time_impl.h +++ b/library/constant_time_impl.h @@ -189,8 +189,8 @@ static inline unsigned char mbedtls_ct_uchar_in_range_if(unsigned char low, unsigned char c, unsigned char t) { - const unsigned char co= (unsigned char) mbedtls_ct_compiler_opaque(c); - const unsigned char to= (unsigned char) mbedtls_ct_compiler_opaque(t); + const unsigned char co = (unsigned char) mbedtls_ct_compiler_opaque(c); + const unsigned char to = (unsigned char) mbedtls_ct_compiler_opaque(t); /* low_mask is: 0 if low <= c, 0x...ff if low > c */ unsigned low_mask = ((unsigned) co - low) >> 8; From 2c018744e5bc102d9bb2cf74eef5180410832977 Mon Sep 17 00:00:00 2001 From: Agathiyan Bragadeesh Date: Thu, 17 Aug 2023 14:00:10 +0100 Subject: [PATCH 4/7] Add newline at end of changelog Signed-off-by: Agathiyan Bragadeesh --- ChangeLog.d/fix-iar-compiler-warnings.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ChangeLog.d/fix-iar-compiler-warnings.txt b/ChangeLog.d/fix-iar-compiler-warnings.txt index b0bd3e1dfa..6250150f02 100644 --- a/ChangeLog.d/fix-iar-compiler-warnings.txt +++ b/ChangeLog.d/fix-iar-compiler-warnings.txt @@ -1,2 +1,3 @@ Bugfix - * Improve general IAR support \ No newline at end of file + * Improve general IAR support + \ No newline at end of file From 48eae138a5ed14e04d20c73b62154874d84fedeb Mon Sep 17 00:00:00 2001 From: Agathiyan Bragadeesh Date: Thu, 17 Aug 2023 14:07:23 +0100 Subject: [PATCH 5/7] Fix formatting in changelog Signed-off-by: Agathiyan Bragadeesh --- ChangeLog.d/fix-iar-compiler-warnings.txt | 1 - 1 file changed, 1 deletion(-) diff --git a/ChangeLog.d/fix-iar-compiler-warnings.txt b/ChangeLog.d/fix-iar-compiler-warnings.txt index 6250150f02..eefbd127d6 100644 --- a/ChangeLog.d/fix-iar-compiler-warnings.txt +++ b/ChangeLog.d/fix-iar-compiler-warnings.txt @@ -1,3 +1,2 @@ Bugfix * Improve general IAR support - \ No newline at end of file From c5eb13d2a986b04b5329400f72f53a971a21de1c Mon Sep 17 00:00:00 2001 From: Agathiyan Bragadeesh Date: Tue, 22 Aug 2023 15:13:04 +0100 Subject: [PATCH 6/7] Reword IAR changelog for fixing compiler warnings Signed-off-by: Agathiyan Bragadeesh --- ChangeLog.d/fix-iar-compiler-warnings.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ChangeLog.d/fix-iar-compiler-warnings.txt b/ChangeLog.d/fix-iar-compiler-warnings.txt index eefbd127d6..50f1dcaad5 100644 --- a/ChangeLog.d/fix-iar-compiler-warnings.txt +++ b/ChangeLog.d/fix-iar-compiler-warnings.txt @@ -1,2 +1,2 @@ Bugfix - * Improve general IAR support + * Fix IAR compiler warnings. Fixes #7873, #4300. From 1515f351a104807163ce4ef7743b140b27b04b6e Mon Sep 17 00:00:00 2001 From: Agathiyan Bragadeesh Date: Tue, 22 Aug 2023 15:24:38 +0100 Subject: [PATCH 7/7] Remove IAR warning fixes to 2.28 from changelog Signed-off-by: Agathiyan Bragadeesh --- ChangeLog.d/fix-iar-compiler-warnings.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ChangeLog.d/fix-iar-compiler-warnings.txt b/ChangeLog.d/fix-iar-compiler-warnings.txt index 50f1dcaad5..0dc2623f8f 100644 --- a/ChangeLog.d/fix-iar-compiler-warnings.txt +++ b/ChangeLog.d/fix-iar-compiler-warnings.txt @@ -1,2 +1,2 @@ Bugfix - * Fix IAR compiler warnings. Fixes #7873, #4300. + * Fix IAR compiler warnings.