mirror/mbedtls
1
0
Fork 0
mirror of https://github.com/Mbed-TLS/mbedtls.git synced 2025-04-03 19:20:18 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Update comments in mpi_core_add_if() test

Browse Source 
Signed-off-by: Tom Cosgrove <tom.cosgrove@arm.com>
This commit is contained in:
Tom Cosgrove 2022-09-15 15:23:56 +01:00
parent b7438d1f62
commit 17f1fdca0f
1 changed files with 14 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
tests/suites/test_suite_mpi.function
View File

@ -1784,40 +1784,39 @@ void mpi_core_add_if( char * input_A, char * input_B,
memcpy( b, B.p, B.n * sizeof(mbedtls_mpi_uint) ); memcpy( b, B.p, B.n * sizeof(mbedtls_mpi_uint) );
memcpy( sum, X->p, X->n * sizeof(mbedtls_mpi_uint) ); memcpy( sum, X->p, X->n * sizeof(mbedtls_mpi_uint) );
/* 1a) a + b: d = a; d += b, cond = 0 => there should be no carry */ /* The test cases have a <= b to avoid repetition, so we test a + b then b + a */
/* a + b */
/* cond = 0 => d unchanged, no carry */
memcpy( d, a, bytes ); memcpy( d, a, bytes );
TEST_EQUAL( 0, mbedtls_mpi_core_add_if( d, b, limbs, 0 ) ); TEST_EQUAL( 0, mbedtls_mpi_core_add_if( d, b, limbs, 0 ) );
/* 1b) and d should be unchanged */
ASSERT_COMPARE( d, bytes, a, bytes ); ASSERT_COMPARE( d, bytes, a, bytes );
/* 2a) a + b: d = a; d += b, cond = 1 => we should get the correct carry */ /* cond = 1 => correct result and carry */
TEST_EQUAL( carry, mbedtls_mpi_core_add_if( d, b, limbs, 1 ) ); TEST_EQUAL( carry, mbedtls_mpi_core_add_if( d, b, limbs, 1 ) );
/* 2b) and d should have the correct result */
ASSERT_COMPARE( d, bytes, sum, bytes ); ASSERT_COMPARE( d, bytes, sum, bytes );
/* 3a) b + a: d = b; d += a, cond = 0 => there should be no carry */ /* b + a */
/* cond = 0 => d unchanged, no carry */
memcpy( d, b, bytes ); memcpy( d, b, bytes );
TEST_EQUAL( 0, mbedtls_mpi_core_add_if( d, a, limbs, 0 ) ); TEST_EQUAL( 0, mbedtls_mpi_core_add_if( d, a, limbs, 0 ) );
/* 3b) and d should be unchanged */
ASSERT_COMPARE( d, bytes, b, bytes ); ASSERT_COMPARE( d, bytes, b, bytes );
/* 4a) b + a: d = b; d += a, cond = 1 => we should get the correct carry */ /* cond = 1 => correct result and carry */
TEST_EQUAL( carry, mbedtls_mpi_core_add_if( d, a, limbs, 1 ) ); TEST_EQUAL( carry, mbedtls_mpi_core_add_if( d, a, limbs, 1 ) );
/* 4b) and d should have the correct result */
ASSERT_COMPARE( d, bytes, sum, bytes ); ASSERT_COMPARE( d, bytes, sum, bytes );
/* 5) a + b where a and b are aliased - only when a == b */ /* If a == b we can test where a and b are aliased */
if ( A.n == B.n && memcmp( A.p, B.p, bytes ) == 0 ) if ( A.n == B.n && memcmp( A.p, B.p, bytes ) == 0 )
{ {
/* 5a) cond = 0 => no carry, and no change to b */ /* cond = 0 => d unchanged, no carry */
TEST_EQUAL( 0, mbedtls_mpi_core_add_if( b, b, limbs, 0 ) ); TEST_EQUAL( 0, mbedtls_mpi_core_add_if( b, b, limbs, 0 ) );
ASSERT_COMPARE( b, bytes, B.p, bytes ); ASSERT_COMPARE( b, bytes, B.p, bytes );
/* 5b) cond = 1 => correct carry, and correct result in b */ /* cond = 1 => correct result and carry */
TEST_EQUAL( carry, mbedtls_mpi_core_add_if( b, b, limbs, 1 ) ); TEST_EQUAL( carry, mbedtls_mpi_core_add_if( b, b, limbs, 1 ) );
ASSERT_COMPARE( b, bytes, sum, bytes ); ASSERT_COMPARE( b, bytes, sum, bytes );
} }