mirror/mbedtls
1
0
Fork 0
mirror of https://github.com/Mbed-TLS/mbedtls.git synced 2025-04-01 13:20:30 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Use ASSERT_COMPARE in preference to memcmp in PSA tests

Browse Source
This commit is contained in:
Gilles Peskine 2018-12-18 00:40:50 +01:00
parent f812dcf4ae
commit 0dfba2ddf0
1 changed files with 12 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
tests/suites/test_suite_psa_crypto.function
View File

@ -1985,8 +1985,8 @@ void mac_sign( int key_type_arg,
&mac_length ) ); &mac_length ) );
/* Compare with the expected value. */ /* Compare with the expected value. */
TEST_EQUAL( mac_length, expected_mac->len ); ASSERT_COMPARE( expected_mac->x, expected_mac->len,
TEST_EQUAL( memcmp( actual_mac, expected_mac->x, mac_length ), 0 ); actual_mac, mac_length );
/* Verify that the end of the buffer is untouched. */ /* Verify that the end of the buffer is untouched. */
TEST_ASSERT( mem_is_char( actual_mac + mac_length, '+', TEST_ASSERT( mem_is_char( actual_mac + mac_length, '+',
@ -3576,8 +3576,8 @@ void derive_output( int alg_arg,
/* Success. Check the read data. */ /* Success. Check the read data. */
PSA_ASSERT( status ); PSA_ASSERT( status );
if( output_sizes[i] != 0 ) if( output_sizes[i] != 0 )
TEST_EQUAL( memcmp( output_buffer, expected_outputs[i], ASSERT_COMPARE( output_buffer, output_sizes[i],
output_sizes[i] ), 0 ); expected_outputs[i], output_sizes[i] );
/* Check the generator status. */ /* Check the generator status. */
expected_capacity -= output_sizes[i]; expected_capacity -= output_sizes[i];
PSA_ASSERT( psa_get_generator_capacity( &generator, PSA_ASSERT( psa_get_generator_capacity( &generator,
@ -3805,7 +3805,8 @@ void derive_key_export( int alg_arg,
TEST_EQUAL( length, bytes2 ); TEST_EQUAL( length, bytes2 );
/* Compare the outputs from the two runs. */ /* Compare the outputs from the two runs. */
TEST_EQUAL( memcmp( output_buffer, export_buffer, capacity ), 0 ); ASSERT_COMPARE( output_buffer, bytes1 + bytes2,
export_buffer, capacity );
exit: exit:
mbedtls_free( output_buffer ); mbedtls_free( output_buffer );
@ -3948,15 +3949,15 @@ void key_agreement_output( int alg_arg,
PSA_ASSERT( psa_generator_read( &generator, PSA_ASSERT( psa_generator_read( &generator,
actual_output, actual_output,
expected_output1->len ) ); expected_output1->len ) );
TEST_EQUAL( memcmp( actual_output, expected_output1->x, ASSERT_COMPARE( actual_output, expected_output1->len,
expected_output1->len ), 0 ); expected_output1->x, expected_output1->len );
if( expected_output2->len != 0 ) if( expected_output2->len != 0 )
{ {
PSA_ASSERT( psa_generator_read( &generator, PSA_ASSERT( psa_generator_read( &generator,
actual_output, actual_output,
expected_output2->len ) ); expected_output2->len ) );
TEST_EQUAL( memcmp( actual_output, expected_output2->x, ASSERT_COMPARE( actual_output, expected_output2->len,
expected_output2->len ), 0 ); expected_output2->x, expected_output2->len );
} }
exit: exit:
@ -3993,7 +3994,8 @@ void generate_random( int bytes_arg )
PSA_ASSERT( psa_generate_random( output, bytes ) ); PSA_ASSERT( psa_generate_random( output, bytes ) );
/* Check that no more than bytes have been overwritten */ /* Check that no more than bytes have been overwritten */
TEST_EQUAL( memcmp( output + bytes, trail, sizeof( trail ) ), 0 ); ASSERT_COMPARE( output + bytes, sizeof( trail ),
trail, sizeof( trail ) );
for( i = 0; i < bytes; i++ ) for( i = 0; i < bytes; i++ )
{ {