Commit Graph

131 Commits

Author SHA1 Message Date
goldsimon
5d360a6711 Replaced struct ip_addr by typedef ip_addr_t to make changing the actual implementation behind the typedef easier. 2010-02-04 18:47:44 +00:00
goldsimon
a23b446ddf Use macros defined in ip_addr.h (some of them new) to work with IP addresses (preparation for bug #27352 - Change ip_addr from struct to typedef (u32_t) - and better code). 2010-02-04 17:21:32 +00:00
goldsimon
21e3cde95c Added missing casts (bug #28659) 2010-01-28 12:05:14 +00:00
goldsimon
853e33bdb4 snmp_recv: don't peek the UDP header, p->tot_len does the same; no need for the extra checks at the beginning; don't use so many if/else but if/return instead to make the code more readable 2010-01-27 17:36:37 +00:00
goldsimon
606fed8896 Use memp pools for snmp instead of the heap; added 4 new pools. 2010-01-26 20:28:24 +00:00
goldsimon
96338314f1 Partly fixed bug #22070 (MIB_OBJECT_WRITE_ONLY not implemented in SNMP): write-only or not-accessible are still returned by getnext (though not by get) 2010-01-25 17:44:07 +00:00
goldsimon
ef31aa12e2 Renamed the private mib node from 'private' to 'mib_private' to *not* use reserved C/C++ keywords, added comments, added init-define for private MIB 2010-01-24 17:16:37 +00:00
goldsimon
9dd6c28523 bug #26523: Compiler Warnings 2010-01-24 14:35:28 +00:00
goldsimon
dbcce3a4be bug #26523: Compiler Warnings 2010-01-23 17:48:36 +00:00
goldsimon
04f17c4709 Improved includes in snmp 2010-01-14 19:59:03 +00:00
goldsimon
46dc1c9bfb Minor (null-pointer check for not-on-list-netif) 2009-12-01 19:59:36 +00:00
goldsimon
057c51ff6d Use LWIP_UNUSED_ARG() instead of if(){}, fix unused arg warning if LWIP_ARP==0 2009-08-25 17:50:59 +00:00
goldsimon
41eecb67d2 fixed bug #25636: SNMPSET value is ignored for integer fields 2009-05-02 15:45:53 +00:00
goldsimon
14cb4eb735 fixed arguments of socket functions to match the standard; converted size argument of netconn_write to 'size_t' for that; fixed some warnings 2009-02-16 19:33:51 +00:00
goldsimon
edf72a7dfb fixed one small warning (compared u16_t to <= 0) 2008-08-26 19:57:20 +00:00
fbernon
caa1834b70 Minor changes in lwip folder: fix some warnings. 2008-01-05 00:13:33 +00:00
fbernon
8c19f9a57e Fix to be able to build SNMP with LWIP_ARP=0. It's not a perfect solution, but I put some @todo points to review them later. 2007-11-27 19:53:47 +00:00
goldsimon
e1f49d990b Fix some warnings discovered by compiling the unixsim under cygwin (gcc pedantic) 2007-11-25 13:57:05 +00:00
goldsimon
bfe24b138d Patch #6215: added ifAdminStatus write support (if explicitly enabled by defining SNMP_SAFE_REQUESTS to 0); added code to check link status for ifOperStatus if LWIP_NETIF_LINK_CALLBACK is defined. 2007-11-06 20:53:37 +00:00
goldsimon
199648ff37 Changed initialization: many init functions are not needed any more since we now rely on the compiler initializing global and static variables to zero! 2007-10-09 19:59:56 +00:00
goldsimon
b7ef6077df Changed IP_REASSEMBLY to enqueue the received pbufs so that multiple packets can be reassembled simultaneously and no static reassembly buffer is needed. 2007-10-06 15:24:43 +00:00
fbernon
47ae677652 enable to remove SNMP timer (which consumne several cycles even when it's not necessary). snmp_agent.txt tell to call snmp_inc_sysuptime() each 10ms (but, it's intrusive if you use sys_timeout feature). Now, you can decide to call snmp_add_sysuptime(100) each 1000ms (which is bigger "step", but call to a lower frequency). Or, you can decide to not call snmp_inc_sysuptime() or snmp_add_sysuptime(), and to define the SNMP_GET_SYSUPTIME(sysuptime) macro. This one is undefined by default in mib2.c. SNMP_GET_SYSUPTIME is called inside snmp_get_sysuptime(u32_t *value), and enable to change "sysuptime" value only when it's queried (any direct call to "sysuptime" is changed by a call to snmp_get_sysuptime). 2007-09-10 18:50:44 +00:00
fbernon
e3cd1ac1f9 Minor changes (but in lot of files): add #if/#endif for options where they could miss. #if LWIP_xxx if always put after #include "lwip/opt.h" (note this one indirectly include cc.h). Move others includes inside #if/#endif block. 2007-09-07 23:01:59 +00:00
fbernon
ac1149156d several-files: replace some #include "arch/cc.h" by "lwip/arch.h", or simply remove it as long as "lwip/opt.h" is included before (this one include "lwip/debug.h" which already include "lwip/arch.h"). Like that, default defines are provided by "lwip/arch.h" if they are not defined in cc.h, in the same spirit than "lwip/opt.h" for lwipopts.h. 2007-09-06 16:43:43 +00:00
fbernon
c1f89c5640 Move some build time checkings inside init.c for task #7142 "Sanity check user-configurable values". 2007-09-05 13:19:25 +00:00
fbernon
9152d6671c Comments Fix for Doxygen documentation 2007-08-09 22:21:44 +00:00
fbernon
792f5b3f22 Patch from Jared Momose (j.momose@ieee.org) for bug #19699 : "Bug in SNMP ASN1 decode; submitted patch" 2007-06-09 10:36:21 +00:00
fbernon
c899097802 Remove warning in snmp/msg_in.c 2007-05-19 10:19:14 +00:00
goldsimon
e9abfa6602 Removed PBUF_STATS and related code from opt.h & msg_in.c 2007-05-16 14:15:54 +00:00
goldsimon
bd570561e8 Fix for bug #19740: 2 static functions are unused, simply ifdefing them out for now to get rid of warnings 2007-05-13 11:08:04 +00:00
goldsimon
f6bdd2cae4 Introduced #define LWIP_UNUSED_ARG(x) use this for and architecture-independent form to tell the compiler you intentionally are not using this variable. Can be overriden in cc.h. 2007-04-04 19:54:22 +00:00
goldsimon
11a4f5538b Change names of 2 global variables again, as the previous names did not have lwip-style... 2007-04-03 16:33:14 +00:00
goldsimon
34fcccc50b - Changed the names of some variables in SNMP module to avoid them shadowing each other (which produces a lot of warnings and makes the code hard to maintain)
- Added missing defines for 3 snmp-functions if LWIP_SNMP==0
2007-04-02 20:39:24 +00:00
goldsimon
4aee4c1ac7 Free pbuf if pbuf_header() fails 2007-03-26 19:27:11 +00:00
fbernon
e54cd23ecb stats.h, stats.c, msg_in.c: Stats counters can be change to u32_t if necessary with the new option LWIP_STATS_LARGE. If you need this option, define LWIP_STATS_LARGE to 1 in your lwipopts.h. More, unused counters are not defined in the stats structs, and not display by stats_display(). Note that some options (SYS_STATS and RAW_STATS) are defined but never used. Fix msg_in.c with the correct #if test for a stat display. 2007-03-22 16:36:45 +00:00
kieranm
7294cb080b * Fix all uses of pbuf_header to check the return value. In some
cases just assert if it fails as I'm not sure how to fix them, but
    this is no worse than before when they would carry on regardless
    of the failure.
2007-03-21 12:55:00 +00:00
goldsimon
5eabd4591a SNMP UDP ports can be configured at compile time 2007-03-08 10:32:29 +00:00
christiaans
a3d912a801 Fixed uninitalized variable warnings (using gcc 4.1.1) 2006-11-27 15:37:44 +00:00
christiaans
77e0f77850 Added snmp_send_trap() parameter, caller must pass enterprise id for enterprise secific traps. 2006-11-27 08:43:10 +00:00
christiaans
b72677c3ce Added missing NULL return checks for snmp_mib_lrn_alloc() and trimmed whitespace at line ends. 2006-11-17 11:07:25 +00:00
christiaans
5e44122552 Trimmed whitespace at line ends. 2006-11-17 11:05:26 +00:00
christiaans
4e583dab2e Again, fixed decoding of negative integers in snmp_asn1_dec_s32t(), tnx to though testing by Sander. 2006-10-13 13:45:06 +00:00
christiaans
bc182cab7c Removed EXPERIMENTAL status. 2006-10-13 12:00:35 +00:00
christiaans
f6f6f11838 Fixed decoding of negative integers in snmp_asn1_dec_s32t(), removed EXPERIMENTAL status. 2006-10-13 11:59:45 +00:00
christiaans
2539b5cf61 Fixed up mib_external_node support, snmpwalk works for external objects. 2006-10-06 08:41:24 +00:00
christiaans
f7881e58bb Improved message parse robustness. Rejecting 'error requests'. Removed invalid genError return on varbindlist parse error, changed badValue into noSuchName error for non-writeable objects. 2006-10-04 09:15:23 +00:00
christiaans
25ed4e9d16 Fixed clearing of head and tail pointers in snmp_mib_node_delete(). 2006-10-03 10:41:48 +00:00
christiaans
cfb082a20b Added external mibnode panic closure functions, tobe called for error responses. 2006-10-02 10:13:04 +00:00
christiaans
e440590c37 Fixed snmp_mib_node_insert() to return 2, for node present (not inserted). Also solves invalid rootnode count for this case. 2006-09-29 13:34:38 +00:00
christiaans
c851a19ab2 Added en->get_value_a() call for zero size get_value replies, e.g. for closing external transactions. 2006-09-28 11:46:24 +00:00
christiaans
c2f9d7dee0 Fixed encoding of object sub identifiers with trailing zero. 2006-09-28 11:43:49 +00:00
christiaans
473e567047 Added en->set_value_a() call for closing external transactions. 2006-09-27 15:11:30 +00:00
christiaans
64dab92c6b Redesign of snmp_msg_event() fsm, added SNMP SET to fsm. 2006-09-27 07:25:16 +00:00
christiaans
d0f279ece4 Set TODO_SNMP_MSG_EVENT to 1. Moved some more code from snmp_recv() to snmp_event_service(). 2006-09-22 08:05:17 +00:00
christiaans
a5532ffd4d Added one strategic LWIP_DEBUGF to snmp_send_response(). 2006-09-22 08:03:16 +00:00
christiaans
cb412134dd Added newlines to LWIP_DEBUGFs. 2006-09-22 08:00:56 +00:00
christiaans
d079aae0e0 Fixed NULL dereferencing for zero length raw data. 2006-09-22 07:59:44 +00:00
christiaans
eabfb233b8 Moved SNMP_CONCURRENT_REQUESTS to opt.h, babysteps for external MIB nodes. 2006-09-20 13:33:50 +00:00
christiaans
960e724ad3 Improved mib node struct for external object access and moved get_object_def() calls to the message processing bit. 2006-09-14 15:08:54 +00:00
christiaans
82c46f957a Fixed double iterator bug in send_trap(), multiple trap destinations work ok now. 2006-09-12 12:46:36 +00:00
christiaans
320ea29861 Added some lines for SET command. 2006-09-12 10:03:46 +00:00
christiaans
c5e99ada63 Fixed sysObjectID length to copy private IDs with unkown lengths properly. 2006-09-08 09:22:28 +00:00
christiaans
a88d054d05 Improved TRAP interfacing. Varbinds maybe allocated at (external) trap source as wel. Added trap destination settings. 2006-09-07 14:17:03 +00:00
christiaans
41ff80e5d3 First getnext succes, values are returned insead of NULLs, empty tables are skipped. Limitation: a single varbind per request, so 'snmptable' will fail. 2006-09-06 10:14:07 +00:00
christiaans
56c5fdbeaf Added newlines in debug output, small optimalisations, more work on 'getnext', fixed 'get' on udp table. 2006-09-04 09:22:48 +00:00
christiaans
130d39cc03 Changed index structs to mib_list_node structs to place the table index trees directly in the mib tree. 2006-09-01 07:14:50 +00:00
christiaans
1485edf8e1 Added index tree node structs and functions, e.g. to be used for ARP table indexes. 2006-08-29 11:28:28 +00:00
christiaans
514ee867a6 Pacified GCC warnings and elaborated getnext to work on scalars, tables don't work yet. 2006-08-21 11:52:58 +00:00
christiaans
3cc7a406f4 Pacified GCC warnings and fixed double mem_free() while returning nosuchname err. 2006-08-21 11:51:19 +00:00
christiaans
c3f82acf7a Pacified GCC warnings. 2006-08-21 11:50:03 +00:00
christiaans
7d1728f05a Started with getnext and ensure zero length identifiers are accepted. 2006-08-17 14:14:58 +00:00
christiaans
4b5c14470a Fixed htons into htonl for trap desctination ip. 2006-08-17 14:11:45 +00:00
christiaans
f198b11f27 Accepting zero length identifiers e.g. for getnext operation. Uncommon but valid. 2006-08-17 14:09:57 +00:00
christiaans
d734cd986c Moved noleafs_get_object_def() and noleafs_get_value() protos from mib2.c to snmp_structs.h 2006-08-15 07:28:43 +00:00
christiaans
8559f3e583 MIB-2 object values near to completion, just committing for keeping the flame alive. 2006-08-11 14:16:36 +00:00
christiaans
d0b81d3b20 Corrected comment typo. 2006-08-11 14:13:39 +00:00
christiaans
9b11c4670d Corrected returned object id for interfaces.ifTable.ifEntry.ifSpecific to zeroDotZero (0.0). 2006-08-07 11:35:32 +00:00
christiaans
7eeaf8eaa5 Corrected object identifier codec for object ids not starting with .iso.dod (e.g. zeroDotZero (0.0)). 2006-08-07 11:32:44 +00:00
christiaans
d8922d0410 Added minimalistic SNMP GET functionality. 2006-07-14 12:54:38 +00:00
christiaans
7a5cb21056 Fixed (experi)mental typo. 2006-07-07 11:33:36 +00:00
christiaans
333c3f18c0 Initial commit. Expirimental code, please note this is not yet fully functional. 2006-07-07 09:49:31 +00:00