Dirk Ziegelmeier
5079e4552c
Document non-standard functions in sys abstraction layer
2016-10-23 10:34:52 +02:00
David van Moolenbroek
760281207e
mld6: fix conditional checksumming
...
The mld_group structure no longer has a 'netif' field, as such
structures are now linked from the corresponding netif structure.
For conditional checksumming, use the calling function's netif
reference instead.
2016-10-23 10:00:47 +02:00
Axel Lin
20fde0be6c
ip4_frag: Use LWIP_MIN instead of open-coded
...
Signed-off-by: Axel Lin <axel.lin@ingics.com>
2016-10-19 08:37:39 +02:00
Dirk Ziegelmeier
67895e7bdd
Fixup new IPv4 fragmentation code - thanks to Zach Smith
2016-10-19 08:36:43 +02:00
Dirk Ziegelmeier
801f26ee0c
Minor documentation update
2016-10-16 19:07:55 +02:00
Axel Lin
4dffe521a3
api_msg.c: Trivial code cleanup
...
Slightly improve readability by testing apiflags with NETCONN_DONTBLOCK.
Also remove an empty else clause.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
2016-10-14 09:20:10 +02:00
Dirk Ziegelmeier
f5f8ab5acf
Fix bug #49328 : Crash error in ip6_frag due to Assertion Fail
2016-10-13 08:50:47 +02:00
Dirk Ziegelmeier
e3a9f01fe4
Implement task #14180 : IPv6 code should not reuse ip6_current_dest_addr() as temporary storage
2016-10-12 21:41:02 +02:00
Dirk Ziegelmeier
37d5691b19
Fix bug #49321 : error.h missing opening "#ifdef __cplusplus"
...
Reported by Martin Kortmann
2016-10-12 07:37:39 +02:00
Erik Ekman
725feb0d4a
mdns: Use netif_get/set_client_data helpers
2016-10-11 11:34:59 +02:00
goldsimon
6edde498e3
pbuf_copy: try to fix GCC const warning
2016-10-11 09:52:44 +02:00
goldsimon
d5bfec2e52
ip4_frag: restore "lwip_ntohs" after last change
2016-10-11 09:52:20 +02:00
goldsimon
576f49ee2b
Fixed bug #46467 : ip_frag() shouldn't modify pbuf in case of a retransmission
2016-10-11 09:47:03 +02:00
goldsimon
697be5c2c3
Make some pbuf functions take const pbuf pointers
2016-10-11 09:23:45 +02:00
Axel Lin
c9cfbe27c1
tcp_out: Remove misleading comment in tcp_pbuf_prealloc()
...
This comment is incorrect since commit 7d0dab9d7d
"partly fixed bug #25882 : TCP hangs on MSS > pcb->snd_wnd
(by not creating segments bigger than half the window)".
Signed-off-by: Axel Lin <axel.lin@ingics.com>
2016-10-11 09:11:47 +02:00
sg
0a343948d9
Fix netconn/socket race condition when receiving RST while waiting on recvmbox
2016-10-10 21:35:07 +02:00
Dirk Ziegelmeier
ed239c4e71
Apply patch #9139 : Invalid format string in dhcp.c
...
by Thomas Mueller
2016-10-10 09:57:07 +02:00
Dirk Ziegelmeier
695c81762c
Minor: Fix comment in etharp.c
2016-10-09 12:28:34 +02:00
Dirk Ziegelmeier
f6e27940bd
Make lwIP compile with clang -Wdocumentation -> several documentation fixes
2016-10-09 12:21:39 +02:00
Dirk Ziegelmeier
9cd555c51a
Minor: documentation typo fix
2016-10-09 10:24:26 +02:00
Dirk Ziegelmeier
4e74ae4bc9
Minor: documentation updates
2016-10-09 10:23:36 +02:00
Dirk Ziegelmeier
5477aa5a42
Minor: Documentation update
2016-10-09 09:41:26 +02:00
Ari Suutari
70ccea9207
Make sys_restart_timeouts public also for !NO_SYS targets
2016-10-07 20:31:15 +02:00
goldsimon
69be49fdc3
Try to fix !defined(LWIP_PROVIDE_ERRNO)
2016-10-07 16:22:33 +02:00
Axel Lin
740182de3c
err: Fixup error code range checking in err_to_errno
...
This also fixes build error in non-debug build because err_strerr is
guarded by LWIP_DEBUG.
Fixes: a1c0a0185b
("bug #48823 : posix errors should be removed from arch.h (to new file 'lwip/errno.h'))"
Signed-off-by: Axel Lin <axel.lin@ingics.com>
2016-10-07 07:41:21 +02:00
Dirk Ziegelmeier
ad3530ee10
One more compile fix in err.c
2016-10-06 20:20:07 +02:00
Dirk Ziegelmeier
86a92543de
Try to fix unix build after Simon's errno changes (need sys_arch.h)
2016-10-06 16:01:32 +02:00
goldsimon
2afc2a52d5
Fix comment on sys_mbox_new() (bug #49279 )
2016-10-06 13:25:11 +02:00
goldsimon
a1c0a0185b
bug #48823 : posix errors should be removed from arch.h (to new file 'lwip/errno.h')
2016-10-06 13:21:00 +02:00
Dirk Ziegelmeier
05419912e0
def.h: Provide hton* / ntoh* functions to users by default for compatibility (can be turned off)
...
Add note to UPGRADING document
2016-10-06 13:13:10 +02:00
Dirk Ziegelmeier
13fb616bb2
Cleanup hton*/ntoh* function handling and platform abstraction
...
Let lwip use functions/macros prefixed by lwip_ internally to avoid naming clashes with external #includes.
Remove over-complicated #define handling in def.h
Make functions easier to override in cc.h. The following is sufficient now (no more LWIP_PLATFORM_BYTESWAP):
#define lwip_htons(x) <your_htons>
#define lwip_htonl(x) <your_htonl>
2016-10-06 12:55:57 +02:00
Dirk Ziegelmeier
0c06073819
Avoid code duplication in def.c
2016-10-06 09:26:59 +02:00
Dirk Ziegelmeier
fa211096c2
Fix macro name clash with windows headers in TFTP server
...
Reported by Gisle Vanem
2016-10-05 21:02:46 +02:00
Axel Lin
87172d6d35
mdns: Use NETIF_TO_HOST at appropriate places
...
Trivial cleanup, use NETIF_TO_HOST macro to get mdns_host from netif.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
2016-10-05 11:23:08 +02:00
Elias Reichart
60a507f88b
ETHARP_TABLE_MATCH_NETIF is also used in the etharp_output shortcut
2016-10-04 22:15:59 +02:00
David van Moolenbroek
0d7805a86a
tcp: fix FIN ACK handling with unsent data
...
TCP's snd_nxt represents the next sequence number after sent data, and
as such does not cover any unsent data queued on the connection. The
current implementation does not take the latter point into account
when processing FIN acknowledgments, mistakenly assuming that an
outgoing FIN is ACK'ed when the acknowledgment covers up to snd_nxt
while there is still unsent data. This patch adds a check for unsent
data to correct this, effectively preventing that TCP connections are
closed prematurely.
2016-10-04 22:12:13 +02:00
David van Moolenbroek
9ba9dee2aa
tcp: advance next seq nr for zero window probes
...
It is possible that the byte sent as a zero window probe is accepted
and acknowledged by the receiver side without the window being opened.
In that case, the stream has effectively advanced by one byte, and
since lwIP did not take this into account on the sender side, the
result was a desynchronization between the sender and the receiver.
That situation could occur even on a lwIP loopback device, after
filling up the receiver side's receive buffer, and resulted in an ACK
storm. This patch corrects the problem by advancing the sender's next
sequence number by one as needed when sending a zero window probe.
2016-10-04 22:06:05 +02:00
Dirk Ziegelmeier
95754ba95a
Another try to fix bug #49264 : Crash Error when LWIP_SOCKET_OFFSET is in use
2016-10-04 14:05:56 +02:00
Dirk Ziegelmeier
bef7873042
ND6: Always set neighbor_cache.state together with counter value to avoid inconsistency
2016-10-04 13:59:05 +02:00
Dirk Ziegelmeier
ec236da972
Add comment for my last changes
2016-10-04 13:36:30 +02:00
Dirk Ziegelmeier
ee27daffc4
Fix bug #48876 : nd6: timers should be in ticks, not ms
...
delay_time and stale_time are ticks now.
reachable_time and invalidation_timer are untouched since they may originate from telegram values -> not converting them to ticks avoids an integer division
2016-10-04 13:30:23 +02:00
goldsimon
cdc97d2779
Correctly fix bug #49209 : netconn_drain() fails to handle 'netconn_aborted' pointer
2016-10-04 12:35:51 +02:00
goldsimon
d9c6badc55
Revert "Fixed bug #49209 : netconn_drain() fails to handle 'netconn_aborted' pointer"
...
This reverts commit 0e2354e658
.
2016-10-04 12:35:50 +02:00
Dirk Ziegelmeier
30251b1404
Fix bug #49264 : Crash Error when LWIP_SOCKET_OFFSET is in use
...
Handle LWIP_SOCKET_OFFSET in lwip_socket_drop_registered_memberships, lwip_socket_unregister_membership and lwip_socket_register_membership.
2016-10-04 12:34:53 +02:00
Dirk Ziegelmeier
d1ed89b2e4
Fix accidental TAB in tftp_server.h
2016-10-04 10:31:43 +02:00
Dirk Ziegelmeier
81549578bf
Fix compile of TFTP with MSVC
2016-10-04 08:54:52 +02:00
Dirk Ziegelmeier
f8683499a6
TFTP: Add missing newline at end of file
2016-10-03 14:33:57 +02:00
Dirk Ziegelmeier
1e5efee7cb
TFTP server depends on UDP
2016-10-03 09:50:34 +02:00
Dirk Ziegelmeier
b040544628
task #14150 : Add TFTP server from Logan Gunthorpe
...
Originally written by Logan Gunthorpe, modifications/fixes/IPv6 by Dirk Ziegelmeier
2016-10-03 09:47:41 +02:00
Dirk Ziegelmeier
eb77c839fc
Minor: comment in pbuf.c
2016-10-03 09:45:59 +02:00
Axel Lin
5e15125b3d
igmp: Fix optimized code by always skipping the first entry in the linked groups list
...
commit 8c52afb6ca
("igmp: Optimize code by always skipping the first entry in the linked groups list - it is always the "allsystems" entry")
accidently changes the code logic. it should check groupref rather than group.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
2016-10-02 19:36:59 +02:00
Dirk Ziegelmeier
8f8f56914b
Fix bug #47731 : IGMP state transition missing
...
Set state variable according to RFC 2236 on timeout in delaying member state
2016-10-01 21:27:00 +02:00
Dirk Ziegelmeier
b33070e0cf
Add documentation for bug #49139 : IGMP "All Systems" vs MLD "All Nodes" inconsistency
2016-10-01 21:13:05 +02:00
Dirk Ziegelmeier
8c52afb6ca
igmp: Optimize code by always skipping the first entry in the linked groups list - it is always the "allsystems" entry
2016-10-01 17:28:36 +02:00
Dirk Ziegelmeier
df5a79966d
Fix bug #48886 : raw pcbs are not handled on netif address change
2016-10-01 17:13:33 +02:00
Dirk Ziegelmeier
149701b347
Fix bug #49218 : pbuf_clen() overflow as a result of tcp_write concatenation
...
Let pbuf_clen() return u16_t
2016-09-30 09:04:36 +02:00
Dirk Ziegelmeier
682b82aad8
Improve documentation: Some words about multiple execution contexts in lwIP
2016-09-29 12:51:45 +02:00
Dirk Ziegelmeier
65796cd827
"Fix" bug #49078 : lwip cannot establish ipv6 connection, because of failed to fill ipv6 source address in Neighbor Solicitation Message by adding a note to netif_add not to forget to create a link-local IPv6 address
2016-09-29 12:02:50 +02:00
Dirk Ziegelmeier
40846260b5
Add comment about possible definitions for non-standard functions
2016-09-29 10:44:53 +02:00
Dirk Ziegelmeier
af04864094
Remove non-standard strnlen() call in snmp_msg.c
2016-09-29 08:30:33 +02:00
Dirk Ziegelmeier
5ddd2aef4b
Substitute custom itoa implementation mdns by lwip_itoa() and strlen() call
2016-09-29 08:25:57 +02:00
Dirk Ziegelmeier
17e6c9dd02
Add #include <string.h> in def.c since lwip_strnstr uses strlen and strcmp
2016-09-29 08:08:26 +02:00
Dirk Ziegelmeier
0e7f48d81c
Fix compile of new functions in def.c - I accidentally put them in a #ifdef section
...
Thanks to Daniel Elstner
2016-09-28 22:26:55 +02:00
Dirk Ziegelmeier
461b3531c7
httpd.c: add missing default in case statement
2016-09-28 22:05:52 +02:00
Dirk Ziegelmeier
4144d54642
Fix implementation of lwip_itoa to take more parameters
2016-09-28 22:05:18 +02:00
Dirk Ziegelmeier
837b7b3f98
Fix comment in my last commit
2016-09-28 21:55:29 +02:00
Dirk Ziegelmeier
1f68b32485
Cleanup handling of non-standard functions in lwIP
...
- itoa
- strnicmp, stricmp/strcasecmp
- strnstr
Related to patch #9115 : httpd.c: strcasecmp for GCC and stricmp for Windows
2016-09-28 21:52:11 +02:00
Dirk Ziegelmeier
f8d19e28de
Minor: Documentation updates
2016-09-28 20:58:02 +02:00
Erik Ekman
f3cec74bd6
mdns: Use macro to get mdns_host from netif v2
...
Add missing )
2016-09-28 18:15:11 +02:00
Erik Ekman
87e815030c
mdns: Use macro to get mdns_host from netif
2016-09-28 18:00:48 +02:00
Erik Ekman
78498981e2
mdns: Update error message after argument type changed
...
Method argument is no longer netif, but a mdns_host
2016-09-28 18:00:44 +02:00
Dirk Ziegelmeier
633696c153
Implement consistent IPx_ADDR_ANYx macro naming between IPv4 and IPv6
...
- rename IP4_ADDR_ANY to IP4_ADDR_ANY4
- IP4_ADDR_ANY (= IP_ADDR_ANY) is now IPv4 any address in ip_addr_t format
2016-09-28 12:56:57 +02:00
goldsimon
0e2354e658
Fixed bug #49209 : netconn_drain() fails to handle 'netconn_aborted' pointer
2016-09-28 12:53:07 +02:00
Dirk Ziegelmeier
5d811d799c
Minor: Documentation updates
2016-09-27 21:18:03 +02:00
Dirk Ziegelmeier
6abcd00f71
Convert IP address type numbers to an enum to improve documentation
2016-09-27 09:46:51 +02:00
Dirk Ziegelmeier
97b774ceb9
Minor: Documentation updates
2016-09-26 21:45:29 +02:00
Daniel Elstner
2f085aa441
ND6: Join/leave groups directly on the netif
2016-09-26 11:44:00 +02:00
Daniel Elstner
354e385453
Fix infinite loop in new MLD6 code
2016-09-26 11:43:59 +02:00
Dirk Ziegelmeier
c7c6b7ce93
Rework IGMP and MLD6 code to store group info per-netif.
...
Reasoning:
- Makes code in single-netif case perform better and smaller
- IGMP / MLD6 code is a little bit easier to read and understand
- Easier to get multicast groups per netif when implementing drivers
Downside: In multi-netif mode, there are two more pointers on each netif, even if IGMP/MLD6 is not used on it. But these systems should not be so memory-constrained that this will matter.
2016-09-21 13:33:33 +02:00
Dirk Ziegelmeier
c25de8f317
Update comment in MDNS and pbuf.c
2016-09-21 12:37:31 +02:00
Daniel Elstner
c9bae5ea9b
Fix bug #49134 : Do not announce invalid IPv4 address via mDNS
...
In a dual stack configuration it is not really feasible to wait
until the IPv4 address is valid before starting the mDNS responder.
If there is no DHCPv4 server in the network, the IPv4 address may
never become valid, which should however not preclude IPv6 mDNS
from working.
2016-09-21 12:31:13 +02:00
Dirk Ziegelmeier
dbd847b70c
Fix bugfix for bug #49136 : No SNMPv2 SetRequest response when OID does not exist
...
Last commit broke SNMPv1 answers
2016-09-20 14:28:40 +02:00
Dirk Ziegelmeier
19e2780656
Fix bug #49136 : No SNMPv2 SetRequest response when OID does not exist
2016-09-20 14:06:20 +02:00
Dirk Ziegelmeier
eb3a08308d
Improve my last docs
2016-09-20 09:14:32 +02:00
Dirk Ziegelmeier
470dae613e
Documentation: Add example for zero-copy RX using custom PBUF
2016-09-20 09:03:49 +02:00
Daniel Elstner
22907c7b27
bug #74921 : check prefix_length, not length
2016-09-19 18:38:05 +02:00
Dirk Ziegelmeier
623f9ce046
Remove one debug message from Daniel's patch
2016-09-19 12:32:43 +02:00
Daniel Elstner
4d4710dadf
Bug #49125 addendum: Remove group from list before callback
...
When leaving a multicast group, remove the group from the list
before invoking the MAC filter callback. This avoids the need
for the callee to skip over the group that is about to be deleted.
2016-09-19 12:26:51 +02:00
Dirk Ziegelmeier
2facd2d64d
Apply modified patch from Daniel Elstner to fix bug #49124 : mDNS should not use snprintf()
2016-09-19 12:20:20 +02:00
Dirk Ziegelmeier
ee4cd45c98
Fix bug #49125 : Need a way to iterate multicast groups for MAC filtering
...
-> let list heads be a public symbol
2016-09-19 08:45:57 +02:00
Dirk Ziegelmeier
58c8e0f8ca
Implement request by Marco Veeneman: Make snmp_send_trap() public
2016-09-15 10:41:05 +02:00
Dirk Ziegelmeier
8dbd1abdc4
Minor coding style fixes while reading SNMP code
2016-09-12 12:55:24 +02:00
Dirk Ziegelmeier
ef0dc65515
Fix GCC warning "invalid suffix on literal; C++11 requires a space between literal and string macro" in arch.h. Pointed out by Thomas Nittel.
2016-09-12 07:38:06 +02:00
Dirk Ziegelmeier
8cd43a3dd9
Documentation: Add one more note PCB is already freed in tcp_err callback.
2016-09-09 17:36:49 +02:00
Erik Ekman
4a73bcbc65
mdns: Revert answer count patch
...
Answers written to outpackets can be additional answers
or normal answers to questions.
2016-09-09 17:04:12 +02:00
Axel Lin
f38705c38c
mdns: Update answers counter in mdns_add_answer rather than each caller
...
This simplifies the code and less error prone.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
2016-09-09 16:42:49 +02:00
Joel Cunningham
b7c2553b46
bug #48964 : Make PBUF_POOL sanity checks contingent on PBUF_POOL_SIZE
...
This commit adds support to the sanity checks in init.c to ensure that
PBUF_POOL is in use
In ports with drivers/netifs that use PBUF_REF for the RX pathway, there
is no need for the PBUF_POOL memory pool. This allows the port to define
PBUF_POOL_SIZE to 0
2016-09-07 09:11:19 -05:00
Axel Lin
f8a95aa27f
dns: Drop unnecessary txid variable in dns_check_entry
...
Signed-off-by: Axel Lin <axel.lin@ingics.com>
2016-09-07 14:56:01 +02:00
Dirk Ziegelmeier
d66442ba91
Fix compile when TCP, UDP and RAW are disabled
2016-09-07 08:11:30 +02:00
Dirk Ziegelmeier
aeae4e91db
Fix compile when UDP is disabled
2016-09-06 12:30:15 +02:00
sg
34682facd1
Remove ip4_frag IP_FRAG_USES_STATIC_BUF code: nearly the same as the other code, but IP_FRAG_USES_STATIC_BUF doesn't work when queuing pbufs
2016-08-31 21:00:10 +02:00
Dirk Ziegelmeier
ac6b64cf66
Implement a more readable fix for pbuf_memcmp than my last fix
2016-08-31 20:24:37 +02:00
Dirk Ziegelmeier
b944ceb89d
Fix compile when LWIP_NUM_NETIF_CLIENT_DATA == 0 and AUTOIP or DHCP are enabled
2016-08-31 20:17:04 +02:00
Axel Lin
ab8a1a0430
netbuf: Fixup a copule LWIP_ERROR messages
...
Fix trivial copy-n-paste mistake.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Dirk Ziegelmeier <dirk@ziegelmeier.net>
2016-08-31 12:23:12 +02:00
Dirk Ziegelmeier
4325aca0f7
Fix pbuf_memcmp() implementation by using pbuf_try_get_at() instead of pbuf_get_at(). Payload out-of-bounds access was not handled correctly.
2016-08-31 10:35:42 +02:00
sg
23147b0e21
added more out of range checks to dns_recv() (see bug #48924 )
2016-08-30 22:18:10 +02:00
Dirk Ziegelmeier
9078f31544
Minor: memcpy -> MEMCPY / SMEMCPY
2016-08-30 21:56:09 +02:00
sg
a08ed9148d
added pbuf_try_get_at() (much like pbuf_get_at() but can return out-of-pbuf error)
2016-08-30 21:35:37 +02:00
Dirk Ziegelmeier
8d45162a59
Fix usage of uninitialized data in dhcp.c by checking pbuf_copy_partial() return value
2016-08-30 21:33:43 +02:00
Dirk Ziegelmeier
f5135b05d9
Minor coding style fixes in mdns.c
2016-08-30 21:21:32 +02:00
Dirk Ziegelmeier
2137f49d32
Fix usage of uninitialized data in nd6.c because of unchecked pbuf_copy_partial() return value
2016-08-30 21:20:58 +02:00
Dirk Ziegelmeier
aef3d2cb87
Minor coding style fix in pbuf.c
2016-08-30 21:09:24 +02:00
Dirk Ziegelmeier
840d1e60fa
Fix bug #48924 : Potential out of bound reads in DNS codes of lwip project by adding checks for pbuf_copy_partial() return values.
...
Add some comments to clarify handling of untrusted network data handling.
2016-08-30 21:09:24 +02:00
Axel Lin
198fa5dbfa
Remove duplicated include for lwip/inet_chksum.h
...
Include it once is enough.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Dirk Ziegelmeier <dirk@ziegelmeier.net>
2016-08-30 09:47:43 +02:00
Axel Lin
ef827e85b8
apps/mdns: Fixup LWIP_ERROR message in mdns_build_host_domain
...
Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Dirk Ziegelmeier <dirk@ziegelmeier.net>
2016-08-30 08:35:40 +02:00
Dirk Ziegelmeier
e545262d98
Remove superfluous parameter from mdns_domain_debug_print()
2016-08-29 19:32:39 +02:00
Dirk Ziegelmeier
fb62e9350f
Fix wrong sizeof() and remove superfluous NULL pointer check in MDNS
2016-08-29 19:15:22 +02:00
Axel Lin
db6aa82a10
memp: Fix comment for memp_overflow_check_element_overflow/underflow
...
These functions now take desc rather than memp_type as second parameter.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
2016-08-28 20:33:57 +02:00
Joel Cunningham
c9dff6b5aa
Correct TCP_OOSEQ_MAX_* opt.h documentation
...
This corrects documentation on TCP_OOSEQ_MAX_BYTES and _PBUFS to list
their dependency on TCP_QUEUE_OOSEQ==1 (out of order sequence queueing
enabled) rather than ==0 (disabled)
2016-08-26 09:33:14 -05:00
Dirk Ziegelmeier
4b45baee10
Add some dual-stack notes to documentation
2016-08-26 15:58:18 +02:00
Dirk Ziegelmeier
05a6d82fa1
Let comment in pbuf.h be consistent with provided example function
2016-08-26 15:39:15 +02:00
Dirk Ziegelmeier
0d510dd66d
Add API macros for netif client data handling and update documentation accordingly
2016-08-26 11:21:49 +02:00
Dirk Ziegelmeier
537bd836c9
Minor: More documentation updates
2016-08-25 22:23:11 +02:00
Dirk Ziegelmeier
57468b8a30
Minor: Several documentation updates
2016-08-25 22:04:04 +02:00
sg
452f5d6296
fix tcpip.c for LWIP_TIMERS==0
2016-08-25 21:15:26 +02:00
Dirk Ziegelmeier
2980a12373
Fix ntohs -> htons in ethernet.c
2016-08-25 14:25:16 +02:00
goldsimon
89aa4e7d79
fixed bug #47921 : link-local prefix in router advertisement must not be processes for SLAAC (patch by abhishek ambure)
2016-08-25 14:21:30 +02:00
goldsimon
3e23eb764b
fixed compiling TCP_OOSEQ_MAX_BYTES || TCP_OOSEQ_MAX_PBUFS (local variable 'p' was hidden)
2016-08-25 14:21:29 +02:00
Dirk Ziegelmeier
aeb3834219
Add debug assert to my last commit and improve comment in opt.h
2016-08-25 14:12:49 +02:00
Dirk Ziegelmeier
475d49440c
Fix handling of LWIP_HOOK_VLAN_SET(). Previous implementation supplied uninitialized arguments to the macro (struct eth_hdr).
...
Change macro signature to be universal: netif, pbuf, src, dst, eth_type - whatever the user needs to decide about VLAN header.
Return value <0 means "no VLAN header", 0 <= return_value <= 0xFFFF -> value is prio_vid of header.
Clean up ethernet_output function to be more readable.
2016-08-25 14:07:35 +02:00
Axel Lin
a2ca85a260
tcp: Make tcp_state_str/tcp_backoff/tcp_persist_backoff static
...
They are only referenced in tcp.c, so make them static.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: goldsimon <goldsimon@gmx.de>
2016-08-25 11:20:10 +02:00
sg
4c390ad39c
update netif address change triggers to tpc & udp to work with IPv6, too
2016-08-24 20:51:05 +02:00
Erik Ekman
a1db05c11e
Fix const argument warning in netif_ip6_addr_set
...
../../../../../lwip/src/netif/ppp/ppp.c:1276:37: error: passing
'const ip6_addr_t *' (aka 'const struct ip6_addr *') to parameter of type
'ip6_addr_t *' (aka 'struct ip6_addr *') discards qualifiers
[-Werror,-Wincompatible-pointer-types-discards-qualifiers]
netif_ip6_addr_set(pcb->netif, 0, IP6_ADDR_ANY6);
^~~~~~~~~~~~~
../../../../../lwip/src/include/lwip/ip_addr.h:340:24: note: expanded from macro
'IP6_ADDR_ANY6'
^~~~~~~~~~~~~~~~~~~~~~~~~
../../../../../lwip/src/include/lwip/netif.h:436:73: note: passing argument to
parameter 'addr6' here
void netif_ip6_addr_set(struct netif *netif, s8_t addr_idx, ip6_addr_t *addr6);
2016-08-24 14:41:48 +02:00
Axel Lin
bf5866b27d
tcp: Prevents a 0 sized (invalid) backlog
...
commit 44e1a2d8e2
accidently includes below changes in tcp_listen_with_backlog
- tcp_backlog_set(lpcb, backlog);
+ lpcb->backlog = backlog;
Thus pass 0 to the backlog parameter of netconn_listen_with_backlog() fails.
Fixes: 44e1a2d8e2
("define tcp_backlog_set() as dummy-define when backlog feature is disable")
Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: goldsimon <goldsimon@gmx.de>
2016-08-24 12:20:28 +02:00
goldsimon
298ec340e5
set netif IPv6 address & state via function to implement change triggers (task #13517 )
2016-08-24 09:19:53 +02:00
goldsimon
1ba0e17157
ip6_addr: a valid address is either preferred or deprecated, no need to reserve 3 bits for that
2016-08-24 09:06:48 +02:00
Dirk Ziegelmeier
43ddf6eee6
Fix debug strings in ethernet_output
2016-08-24 08:46:32 +02:00
Dirk Ziegelmeier
8426dfa14d
Remove misleading comments from udp_send() and raw_send(). A pbuf may be added automatically in front of the chain to be able to send PBUF_REFs
2016-08-24 08:45:37 +02:00
Dirk Ziegelmeier
6fc7f84497
Minor: documentation updates
2016-08-24 08:19:51 +02:00
Dirk Ziegelmeier
831b7fc7d3
Add note to pbuf_type about correct TX/RX type selection
2016-08-24 08:09:03 +02:00
Dirk Ziegelmeier
d9b0236525
Fix MDNS did not allocate TX packets from RAM but from POOL
2016-08-24 08:04:04 +02:00
Dirk Ziegelmeier
e78bc41116
Document ethernet level functions
2016-08-24 08:01:36 +02:00
Dirk Ziegelmeier
c719c466b3
Remove SIZEOF_ETHARP_PACKET_TX #define, it is not needed any more after my last cleanups
2016-08-23 20:41:37 +02:00
Dirk Ziegelmeier
31778193da
Work on bug #48868 : Cleanup etharp.c not to use struct eth_hdr: Cleanup etharp_input() to use ethernet_output()
2016-08-23 17:23:21 +02:00
Dirk Ziegelmeier
6caa7b9927
Cleanup etharp_arp_input() signature to match the sig of other input functions (pbuf, netif). Rename to etharp_input()
2016-08-23 17:03:51 +02:00
Dirk Ziegelmeier
979bee386c
Work on bug #48868 : Cleanup etharp.c not to use struct eth_hdr: Cleanup etharp_raw() to use ethernet_output()
2016-08-23 16:58:17 +02:00
Dirk Ziegelmeier
d2f52e19d5
Fix doxygen comment in ethernet.c
2016-08-23 16:09:32 +02:00
Dirk Ziegelmeier
56dc574bed
Fix comment in pbuf layer description
2016-08-23 16:07:48 +02:00
goldsimon
e4c74109cd
fixed bug #47652 : there is always a delay to send the first Neighbor Solicitation for the new add INCOMPLETE state neighbor entry
2016-08-23 15:50:48 +02:00
goldsimon
fd5b34ae43
ip4_forward(): fixed compiling IP_FORWARD_ALLOW_TX_ON_RX_NETIF==1
2016-08-23 15:26:05 +02:00
goldsimon
306171c93b
DHCP: fixed compiling LWIP_DHCP_BOOTP_FILE==1
2016-08-23 15:25:39 +02:00
goldsimon
d99d91dae9
removed ETHARP_TRUST_IP_MAC since it is insecure and we don't need it any more after implementing unicast ARP renewal towards arp entry timeout
2016-08-23 13:00:15 +02:00
Dirk Ziegelmeier
fc54556d80
Code beautification in LWIP_HOOK_UNKNOWN_ETH_PROTOCOL usage
2016-08-23 12:55:21 +02:00
Dirk Ziegelmeier
0d5eea288c
Clarify LWIP_HOOK_UNKNOWN_ETH_PROTOCOL in opt.h
2016-08-23 12:54:29 +02:00
Dirk Ziegelmeier
4456c7d230
Fix regression in etharp.c: Allocate correct pbuf layer
2016-08-23 12:32:57 +02:00
Dirk Ziegelmeier
f170dde1c6
Work on bug #48824 : ethernet.c extensions: Implement hook for unknown ethernet protocols
2016-08-23 10:48:38 +02:00
Dirk Ziegelmeier
bae4d6398c
Fix some comments to reference ethernet_output now
2016-08-23 10:23:59 +02:00
Dirk Ziegelmeier
18136c047b
Work on bug #48824 : ethernet.c extensions: Implement ethernet_output();
...
Fixes bug #48862 : ethip6 does not support setting vlan
2016-08-23 10:15:03 +02:00
Axel Lin
42c193821c
netbuf: Use memset to zero the allocated memory for netbuf_new
...
Use memset to zero the allocated memory rather than explicitly init each field.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: goldsimon <goldsimon@gmx.de>
2016-08-23 08:59:11 +02:00
Axel Lin
1c5c96a50a
pbuf: Use SYS_ARCH_INC in pbuf_ref()
...
Use SYS_ARCH_INC to simplify the code.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: goldsimon <goldsimon@gmx.de>
2016-08-23 08:59:10 +02:00
Axel Lin
40f2bed5c4
mem: Simplify the code for try bigger pool in mem_malloc
...
Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: sg <goldsimon@gmx.de>
2016-08-20 11:29:57 +02:00
Axel Lin
a032ccafe7
mem: Fix trivial comment typo about using custom pools
...
Signed-off-by: Axel Lin <axel.lin@ingics.com>
2016-08-20 09:17:37 +02:00
goldsimon
4f4d16260f
minor: fixed typo
2016-08-19 15:40:36 +02:00
goldsimon
6b1e1af3d1
combine MAC filter actions for IGMP and MLD6 (IGMP has compatibility defines for old code, MLD6 filter functions must be adapted)
2016-08-19 13:54:14 +02:00
Axel Lin
b3bae1b44c
memp: Fix unused variable build error when MEMP_SANITY_REGION_BEFORE/AFTER is 0
...
MEMP_SANITY_REGION_BEFORE and MEMP_SANITY_REGION_AFTER can be overridden in
lwipopts.h, if one of it is set to 0 we got build error due to unused variable.
Fix unused variable build error when MEMP_OVERFLOW_CHECK >= 1 &&
(MEMP_SANITY_REGION_BEFORE == 0 || MEMP_SANITY_REGION_AFTER == 0).
Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: goldsimon <goldsimon@gmx.de>
2016-08-19 13:47:37 +02:00
Dirk Ziegelmeier
730080f20e
Fix doxygen comment in lwip/prot/igmp.h
2016-08-19 13:15:23 +02:00
goldsimon
a189941da6
make igmp/mld6 filter actions an enum and define them in netif.h where the callback function prototypes are defined
2016-08-19 13:10:57 +02:00
Dirk Ziegelmeier
f93a6e3310
Rename lwip/prot/arp.h to lwip/prot/etharp.h for consistence
2016-08-19 13:09:58 +02:00
Dirk Ziegelmeier
5e36815867
init.c: Implement check for correct implementation of struct packing in lwip port
2016-08-19 13:05:51 +02:00
Dirk Ziegelmeier
01d8e5013f
Add missing include in prot/igmp.h
2016-08-19 13:02:17 +02:00
Dirk Ziegelmeier
6688033bc4
Move IGMP protocol struct to prot/igmp.h
2016-08-19 12:50:41 +02:00
goldsimon
ed566cceaa
minor cleaup in (eth)arp
2016-08-19 12:49:02 +02:00
goldsimon
55d05092ef
simplify memp.c code a bit
2016-08-19 12:25:48 +02:00
Axel Lin
0e9ef19cfb
memp: Remove memp_overflow_init() function
...
There is only one caller using memp_overflow_init(), and at that context
calling memp_overflow_init_element() actually simplifes the code.
Thus remove memp_overflow_init() function.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: goldsimon <goldsimon@gmx.de>
2016-08-19 12:25:47 +02:00
Dirk Ziegelmeier
fefb782bfe
Apply fix by Marco Veeneman in SNMPv3: The outbound_padding is calculated wrong in snmp_complete_outbound_frame()
2016-08-19 12:22:59 +02:00
Dirk Ziegelmeier
12609c951c
Fix compile of SNMPv3 code with MSVC
2016-08-19 12:22:58 +02:00
Axel Lin
64f79e7ffc
PPP, PPPoE: Include netif/ethernet.h to fix build error
...
Fix below build errors:
In file included from ../../../../../lwip/src/include/netif/ppp/ppp_opts.h:31:0,
from ../../../../../lwip/src/netif/ppp/pppoe.c:71:
../../../../../lwip/src/netif/ppp/pppoe.c: In function ‘pppoe_timeout’:
../../../../../lwip/src/netif/ppp/pppoe.c:861:30: error: ‘ethbroadcast’ undeclared (first use in this function)
MEMCPY(&sc->sc_dest, ethbroadcast.addr, sizeof(sc->sc_dest));
^
../../../../../lwip/src/include/lwip/opt.h:137:52: note: in definition of macro ‘MEMCPY’
#define MEMCPY(dst,src,len) memcpy(dst,src,len)
^
../../../../../lwip/src/netif/ppp/pppoe.c:861:30: note: each undeclared identifier is reported only once for each function it appears in
MEMCPY(&sc->sc_dest, ethbroadcast.addr, sizeof(sc->sc_dest));
^
../../../../../lwip/src/include/lwip/opt.h:137:52: note: in definition of macro ‘MEMCPY’
#define MEMCPY(dst,src,len) memcpy(dst,src,len)
^
../../../../../lwip/src/netif/ppp/pppoe.c: In function ‘pppoe_connect’:
../../../../../lwip/src/netif/ppp/pppoe.c:899:24: error: ‘ethbroadcast’ undeclared (first use in this function)
MEMCPY(&sc->sc_dest, ethbroadcast.addr, sizeof(sc->sc_dest));
^
../../../../../lwip/src/include/lwip/opt.h:137:52: note: in definition of macro ‘MEMCPY’
#define MEMCPY(dst,src,len) memcpy(dst,src,len)
^
../../Common.mk:94: recipe for target 'pppoe.o' failed
make: *** [pppoe.o] Error 1
Fixes: 8eb9db18a2
("Reduce usage of netif/ethernet.h header, mostly lwip/prot/ethernet.h is sufficient")
Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: goldsimon <goldsimon@gmx.de>
2016-08-19 12:12:57 +02:00
goldsimon
ebd1bf8a49
fixed typo :-(
2016-08-19 11:03:09 +02:00
goldsimon
4a7dafc6a6
fixed compiling mdns.c after moving things to mdns_priv.h
2016-08-19 11:02:37 +02:00
goldsimon
1e6f33d44b
tcp: move tcp header flags definitions to 'prot'
2016-08-19 10:41:01 +02:00
goldsimon
96c3c48ba7
mdns: moved private things into mdns_priv.h
2016-08-19 09:52:30 +02:00
goldsimon
14fb48cd7a
minor: whitespace cleanups
2016-08-19 09:41:34 +02:00
goldsimon
9725a496b5
moved 2 enums from 'prot' headers to where they belong (dns, dhcp)
2016-08-19 09:41:33 +02:00
Dirk Ziegelmeier
967516aa40
Add #include to netif/ethernet.h to netif/etharp.h to maintian compatibility
2016-08-19 09:15:35 +02:00
Dirk Ziegelmeier
8eb9db18a2
Reduce usage of netif/ethernet.h header, mostly lwip/prot/ethernet.h is sufficient
2016-08-19 08:36:00 +02:00
sg
43d6812b3e
IPv6 addr: clarify tentative count/LWIP_IPV6_DUP_DETECT_ATTEMPTS
2016-08-18 22:02:57 +02:00
Dirk Ziegelmeier
c4e3be814f
Work on bug #48728 : headers should cleanly separate API vs. implementation
...
ARP
2016-08-18 20:58:51 +02:00
Dirk Ziegelmeier
ad357a4c89
Work on bug #48728 : headers should cleanly separate API vs. implementation
...
ICMP
2016-08-18 20:55:09 +02:00
Dirk Ziegelmeier
2d503f4433
Work on bug #48728 : headers should cleanly separate API vs. implementation
...
ICMP6
2016-08-18 20:52:00 +02:00
Dirk Ziegelmeier
458211c2af
Comment fixes in my last commits
2016-08-18 20:41:39 +02:00
Dirk Ziegelmeier
84e139f20c
Work on bug #48728 : headers should cleanly separate API vs. implementation
...
IP6
2016-08-18 20:40:15 +02:00
Dirk Ziegelmeier
81c68f529b
Work on bug #48728 : headers should cleanly separate API vs. implementation
...
MLD6
2016-08-18 20:36:44 +02:00
Dirk Ziegelmeier
f299b4b7cf
Work on bug #48728 : headers should cleanly separate API vs. implementation
...
Ethernet
2016-08-18 20:33:38 +02:00
Dirk Ziegelmeier
8d68400387
Work on bug #48728 : headers should cleanly separate API vs. implementation
...
ND6
2016-08-18 20:28:03 +02:00
Dirk Ziegelmeier
d89fa2dcbc
Work on bug #48728 : headers should cleanly separate API vs. implementation
...
UDP
2016-08-18 20:22:35 +02:00
Dirk Ziegelmeier
16293125a6
Work on bug #48728 : headers should cleanly separate API vs. implementation
...
TCP
2016-08-18 20:22:14 +02:00
Axel Lin
e24fde05db
memp: Fix memp_overflow_check_element_overflow assertion
...
Use LWIP_MEM_ALIGN() in memp_overflow_init() to get alignment address for memp.
This fixes assertion in memp_overflow_check_element_overflow when
MEMP_OVERFLOW_CHECK is set.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
2016-08-18 19:24:34 +02:00
Axel Lin
ef31afb921
memp: Fix build error when LWIP_HOOK_MEMP_AVAILABLE is defined
...
Fix below build error.
../../../../../lwip/src/core/memp.c: In function ‘memp_free’:
../../../../../lwip/src/core/memp.c:490:31: error: request for member ‘tab’ in something not a structure or union
old_first = memp_pools[type].tab;
^
../../Common.mk:94: recipe for target 'memp.o' failed
make: *** [memp.o] Error 1
Fixes: de9054cb7a
("memp: cleaned up MEMP_MEM_MALLOC")
Signed-off-by: Axel Lin <axel.lin@ingics.com>
2016-08-18 19:20:26 +02:00
Dirk Ziegelmeier
97fae7e41b
Code cleanup in autoip.c and dhcp.c
2016-08-18 12:49:59 +02:00
Dirk Ziegelmeier
7f60cb3889
Improve netif client data API for lwIP internal clients - these can use a compile-time constant to access their data now
2016-08-18 12:37:21 +02:00
Dirk Ziegelmeier
ebf7959880
Coding style fixes in netif.c
2016-08-18 11:44:19 +02:00
Dirk Ziegelmeier
0c7a59b5db
Minor: Documentation fixes
2016-08-18 11:06:50 +02:00
Dirk Ziegelmeier
c9ad58308a
Minor documentation fixes
2016-08-18 10:59:18 +02:00
Dirk Ziegelmeier
a262a2f252
MDNS: Add callback to be called manually when IP has changed to announce new IP
2016-08-18 10:59:08 +02:00
Dirk Ziegelmeier
fa6a2d48cc
Fix DHCP unit test after my last changes
2016-08-18 06:09:02 +02:00
Dirk Ziegelmeier
c62bfd8146
Port AUTOIP to new netif client data API
2016-08-17 21:26:08 +02:00
Dirk Ziegelmeier
1db9631e7d
Port DHCP to new netif client data API
2016-08-17 21:04:44 +02:00
Dirk Ziegelmeier
c8c804140d
Fix possible NULL pointer dereference in mdns.c introduced in my last commit
2016-08-17 21:00:59 +02:00
Dirk Ziegelmeier
ee815e4e7a
Finish porting MDNS to new netif client data API
2016-08-17 20:09:28 +02:00
Dirk Ziegelmeier
c28fb298b7
Introduce an API to store arbitrary data pointers in struct netif
...
Let MDNS to use the new API
TODO: AutoIP, DHCP
2016-08-17 16:37:15 +02:00
Dirk Ziegelmeier
2a90f33757
MDNS responder: two functions can take struct mdns_host instead of netif as argument
2016-08-17 12:32:33 +02:00
Dirk Ziegelmeier
efb7b3d5f8
Rename LWIP_MDNS to LWIP_MDNS_RESPONDER
2016-08-17 12:07:38 +02:00
Dirk Ziegelmeier
02d51e3ac5
Add missing file doxygen header in two mdns files
2016-08-16 09:46:19 +02:00
Dirk Ziegelmeier
fec657bb38
MDNS: Substitute a few strlens by sizeof()
2016-08-16 09:33:53 +02:00
Dirk Ziegelmeier
858287fc3a
MDNS: Fix several MSVC warnings
2016-08-16 08:33:16 +02:00
Dirk Ziegelmeier
af6b707e9a
mdns_opts.h: Add missing include lwip/opt.h
2016-08-16 08:28:59 +02:00
Dirk Ziegelmeier
ab72ed8517
Fix options #include in mdns code
2016-08-16 08:22:41 +02:00
Dirk Ziegelmeier
482a4d2ce9
MDNS: Correct setting TTL when IGMP is not enabled
2016-08-16 08:09:19 +02:00
Dirk Ziegelmeier
c61c8f3766
Use udp_get_multicast_ttl/udp_set_multicast_ttl accessors where applicable
2016-08-16 08:08:06 +02:00
Dirk Ziegelmeier
39ac8e2c57
Remove some MDNS functions from documentation, they are only visible for unit tests
2016-08-14 17:08:39 +02:00
Dirk Ziegelmeier
52449e12c0
Forgot to save before committing...
2016-08-14 16:56:34 +02:00
Dirk Ziegelmeier
2335c1a73c
Port MDNS to new dual-stack API
2016-08-14 16:47:45 +02:00
Dirk Ziegelmeier
ebe0e6f98d
Some documentation cosmetics in mdns.c
2016-08-14 15:42:22 +02:00
Dirk Ziegelmeier
b472648e40
Fix wrong copyright header in mdns_opts.h
2016-08-14 15:36:41 +02:00
Dirk Ziegelmeier
a2894ede1c
MDNS: make a few arguments const where suitable
2016-08-14 15:31:49 +02:00
Dirk Ziegelmeier
306113c8c3
Add MDNS to doxygen docs
2016-08-14 15:22:05 +02:00
Erik Ekman
4919932c49
Apply patch #8755 : Multicast DNS responder support from Erik Ekman
2016-08-14 15:07:45 +02:00
Sylvain Rochet
4af297fc20
PPP: fix don't print valid LCP echo request/reply packets if the link is up
...
The check for link up was missing, meaning valid LCP echo request/reply
packets are filtered whatever the PPP state is, despite what the comment
says.
Fix it by checking the PPP state as we would like to have done when it
was written.
2016-08-13 16:02:38 +02:00
Sylvain Rochet
4e1f8effaf
PPP: fix ppp_write internal documentation
...
This function returns an err_t, not a number of characters written.
2016-08-13 16:02:38 +02:00
Dirk Ziegelmeier
5493220c93
Move DNS protocol structs to separate header. Needed for Erik Ekman's MDNS implementation.
2016-08-13 09:05:28 +02:00
Dirk Ziegelmeier
ce6ea0df15
Convert SNMP snmp_vb_enumerator_err_t to a typedef and fix resulting compile error
2016-08-12 22:59:21 +02:00
Dirk Ziegelmeier
6dcb2b2415
Work on bug #48730 : Enums should be used instead of multiple defines (where applicable)
2016-08-12 22:51:43 +02:00
Dirk Ziegelmeier
b34baff546
Convert state #defines in autoip.h and dhcp.h to enums. May be useful in *_state structs to simplify debugging in the future.
2016-08-11 21:04:39 +02:00
goldsimon
6f62fe5998
ensure the 'prot' headers are as small & portable as possible
2016-08-11 15:11:34 +02:00
goldsimon
dc7340bbd5
started with bug #48728 : move protocol definitions to 'include/prot/*.h' files (started with some IPv4 protocols)
2016-08-11 14:36:09 +02:00
Ajay Bhargav
d95ab511d0
netif:ppp: fix mempool build issues when PPP is enabled
...
During documentation updated LWIP_MEMPOOL_PROTOTYPE was moved inside
"#if MEMP_MEM_MALLOC" which cause ppp build to break. This patch fix that
issue.
ref commit-id: 2f950a7dcc
Signed-off-by: Ajay Bhargav <contact@rickeyworld.info>
2016-08-11 12:54:55 +02:00
goldsimon
bf3e8e6a48
minor coding style fixes in IPv6 code
2016-08-11 09:23:43 +02:00
Sylvain Rochet
3194c9c4cf
PPP: filter more packets in ppp_dump_packet
...
VJ packets, Compressed packets, IPv4 and IPv6 packets are useless in
the PPP packet dump. We properly filtered IPv4 and IPv6 packets but
we forgot filtering VJ and Compressed packets.
Improve the filtering rule to filter packets which are not auth
protocol (< 0xC000) and which are not control protocol (0x8000 bit
not set).
2016-08-10 23:39:28 +02:00
Axel Lin
18fcc1d504
[PATCH] debug: Add braces around empty body in an 'if' statement
...
I have below code in my cc.h:
#ifdef MYSDK_LWIP_DEBUG
#define LWIP_PLATFORM_ASSERT(x) MYSDK_ASSERTION_FAIL_ACTION()
#else
#define LWIP_PLATFORM_ASSERT(x)
#endif /* ifdef MYSDK_LWIP_DEBUG */
I got below error when in non-debug build:
src/include/lwip/debug.h:76:32: error: suggest braces around empty body in an 'if' statement [-Werror=empty-body]
LWIP_PLATFORM_ASSERT(message); } while(0)
^
Fix the build error by adding braces around empty body in an 'if' statement.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: sg <goldsimon@gmx.de>
2016-08-09 21:52:13 +02:00
Dirk Ziegelmeier
5c0944e01a
Don't document tcp_send_empty_ack and tcp_keepalive - users should never need them
2016-08-09 10:17:16 +02:00
Dirk Ziegelmeier
5a09fd3e35
Don't document ip4_route and ip6_route, users should use ip_route instead
2016-08-09 10:16:40 +02:00
Dirk Ziegelmeier
0005b7c2d0
Revert my last change in sntp.c - allow usage of custom error values in err_t
2016-08-09 08:20:28 +02:00
Dirk Ziegelmeier
61dae47a71
Relete SNMP README and incorporate it's text in doxygen docs
2016-08-08 22:40:57 +02:00
Dirk Ziegelmeier
85ab39985a
Fix a few incorrect uses of err_t. Found by converting lwip error codes to an enum, but I'm not sure wether I want to commit the actual enum conversion.
2016-08-08 22:15:01 +02:00
Dirk Ziegelmeier
e5284ec616
Minor: documentation cosmetics
2016-08-08 22:01:38 +02:00
sg
a2fd68098e
minor: macros should not end with underscore(s)
2016-08-08 21:47:53 +02:00
Dirk Ziegelmeier
1631307bb3
tcp.c: Partly undo Simon's changes from today (repairs doxygen docs)
2016-08-08 21:42:27 +02:00
Sylvain Rochet
282b8a2b6c
PPP: set disconnect state before closing link protocol in ppp_close
...
If LCP is not started yet, we are only closing the link protocol, in
this case we have to set the disconnect state ourself because PPP
is not actually started yet.
2016-08-08 11:55:31 +02:00
Dirk Ziegelmeier
b1dfd00f92
Minor netif documentation update
2016-08-08 09:16:15 +02:00
goldsimon
eba6ae0122
minor: add a comment about where to define LWIP_RAND()
2016-08-08 09:14:50 +02:00