Erik Ekman
4a73bcbc65
mdns: Revert answer count patch
...
Answers written to outpackets can be additional answers
or normal answers to questions.
2016-09-09 17:04:12 +02:00
Axel Lin
f38705c38c
mdns: Update answers counter in mdns_add_answer rather than each caller
...
This simplifies the code and less error prone.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
2016-09-09 16:42:49 +02:00
Joel Cunningham
b7c2553b46
bug #48964 : Make PBUF_POOL sanity checks contingent on PBUF_POOL_SIZE
...
This commit adds support to the sanity checks in init.c to ensure that
PBUF_POOL is in use
In ports with drivers/netifs that use PBUF_REF for the RX pathway, there
is no need for the PBUF_POOL memory pool. This allows the port to define
PBUF_POOL_SIZE to 0
2016-09-07 09:11:19 -05:00
Axel Lin
f8a95aa27f
dns: Drop unnecessary txid variable in dns_check_entry
...
Signed-off-by: Axel Lin <axel.lin@ingics.com>
2016-09-07 14:56:01 +02:00
Dirk Ziegelmeier
d66442ba91
Fix compile when TCP, UDP and RAW are disabled
2016-09-07 08:11:30 +02:00
Dirk Ziegelmeier
aeae4e91db
Fix compile when UDP is disabled
2016-09-06 12:30:15 +02:00
sg
34682facd1
Remove ip4_frag IP_FRAG_USES_STATIC_BUF code: nearly the same as the other code, but IP_FRAG_USES_STATIC_BUF doesn't work when queuing pbufs
2016-08-31 21:00:10 +02:00
Dirk Ziegelmeier
ac6b64cf66
Implement a more readable fix for pbuf_memcmp than my last fix
2016-08-31 20:24:37 +02:00
Dirk Ziegelmeier
b944ceb89d
Fix compile when LWIP_NUM_NETIF_CLIENT_DATA == 0 and AUTOIP or DHCP are enabled
2016-08-31 20:17:04 +02:00
Axel Lin
ab8a1a0430
netbuf: Fixup a copule LWIP_ERROR messages
...
Fix trivial copy-n-paste mistake.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Dirk Ziegelmeier <dirk@ziegelmeier.net>
2016-08-31 12:23:12 +02:00
Dirk Ziegelmeier
4325aca0f7
Fix pbuf_memcmp() implementation by using pbuf_try_get_at() instead of pbuf_get_at(). Payload out-of-bounds access was not handled correctly.
2016-08-31 10:35:42 +02:00
sg
23147b0e21
added more out of range checks to dns_recv() (see bug #48924 )
2016-08-30 22:18:10 +02:00
Dirk Ziegelmeier
9078f31544
Minor: memcpy -> MEMCPY / SMEMCPY
2016-08-30 21:56:09 +02:00
sg
a08ed9148d
added pbuf_try_get_at() (much like pbuf_get_at() but can return out-of-pbuf error)
2016-08-30 21:35:37 +02:00
Dirk Ziegelmeier
8d45162a59
Fix usage of uninitialized data in dhcp.c by checking pbuf_copy_partial() return value
2016-08-30 21:33:43 +02:00
Dirk Ziegelmeier
f5135b05d9
Minor coding style fixes in mdns.c
2016-08-30 21:21:32 +02:00
Dirk Ziegelmeier
2137f49d32
Fix usage of uninitialized data in nd6.c because of unchecked pbuf_copy_partial() return value
2016-08-30 21:20:58 +02:00
Dirk Ziegelmeier
aef3d2cb87
Minor coding style fix in pbuf.c
2016-08-30 21:09:24 +02:00
Dirk Ziegelmeier
840d1e60fa
Fix bug #48924 : Potential out of bound reads in DNS codes of lwip project by adding checks for pbuf_copy_partial() return values.
...
Add some comments to clarify handling of untrusted network data handling.
2016-08-30 21:09:24 +02:00
Axel Lin
198fa5dbfa
Remove duplicated include for lwip/inet_chksum.h
...
Include it once is enough.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Dirk Ziegelmeier <dirk@ziegelmeier.net>
2016-08-30 09:47:43 +02:00
Axel Lin
ef827e85b8
apps/mdns: Fixup LWIP_ERROR message in mdns_build_host_domain
...
Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Dirk Ziegelmeier <dirk@ziegelmeier.net>
2016-08-30 08:35:40 +02:00
Dirk Ziegelmeier
e545262d98
Remove superfluous parameter from mdns_domain_debug_print()
2016-08-29 19:32:39 +02:00
Dirk Ziegelmeier
fb62e9350f
Fix wrong sizeof() and remove superfluous NULL pointer check in MDNS
2016-08-29 19:15:22 +02:00
Axel Lin
db6aa82a10
memp: Fix comment for memp_overflow_check_element_overflow/underflow
...
These functions now take desc rather than memp_type as second parameter.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
2016-08-28 20:33:57 +02:00
Joel Cunningham
c9dff6b5aa
Correct TCP_OOSEQ_MAX_* opt.h documentation
...
This corrects documentation on TCP_OOSEQ_MAX_BYTES and _PBUFS to list
their dependency on TCP_QUEUE_OOSEQ==1 (out of order sequence queueing
enabled) rather than ==0 (disabled)
2016-08-26 09:33:14 -05:00
Dirk Ziegelmeier
4b45baee10
Add some dual-stack notes to documentation
2016-08-26 15:58:18 +02:00
Dirk Ziegelmeier
05a6d82fa1
Let comment in pbuf.h be consistent with provided example function
2016-08-26 15:39:15 +02:00
Dirk Ziegelmeier
0d510dd66d
Add API macros for netif client data handling and update documentation accordingly
2016-08-26 11:21:49 +02:00
Dirk Ziegelmeier
537bd836c9
Minor: More documentation updates
2016-08-25 22:23:11 +02:00
Dirk Ziegelmeier
57468b8a30
Minor: Several documentation updates
2016-08-25 22:04:04 +02:00
sg
452f5d6296
fix tcpip.c for LWIP_TIMERS==0
2016-08-25 21:15:26 +02:00
Dirk Ziegelmeier
2980a12373
Fix ntohs -> htons in ethernet.c
2016-08-25 14:25:16 +02:00
goldsimon
89aa4e7d79
fixed bug #47921 : link-local prefix in router advertisement must not be processes for SLAAC (patch by abhishek ambure)
2016-08-25 14:21:30 +02:00
goldsimon
3e23eb764b
fixed compiling TCP_OOSEQ_MAX_BYTES || TCP_OOSEQ_MAX_PBUFS (local variable 'p' was hidden)
2016-08-25 14:21:29 +02:00
Dirk Ziegelmeier
aeb3834219
Add debug assert to my last commit and improve comment in opt.h
2016-08-25 14:12:49 +02:00
Dirk Ziegelmeier
475d49440c
Fix handling of LWIP_HOOK_VLAN_SET(). Previous implementation supplied uninitialized arguments to the macro (struct eth_hdr).
...
Change macro signature to be universal: netif, pbuf, src, dst, eth_type - whatever the user needs to decide about VLAN header.
Return value <0 means "no VLAN header", 0 <= return_value <= 0xFFFF -> value is prio_vid of header.
Clean up ethernet_output function to be more readable.
2016-08-25 14:07:35 +02:00
Axel Lin
a2ca85a260
tcp: Make tcp_state_str/tcp_backoff/tcp_persist_backoff static
...
They are only referenced in tcp.c, so make them static.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: goldsimon <goldsimon@gmx.de>
2016-08-25 11:20:10 +02:00
sg
4c390ad39c
update netif address change triggers to tpc & udp to work with IPv6, too
2016-08-24 20:51:05 +02:00
Erik Ekman
a1db05c11e
Fix const argument warning in netif_ip6_addr_set
...
../../../../../lwip/src/netif/ppp/ppp.c:1276:37: error: passing
'const ip6_addr_t *' (aka 'const struct ip6_addr *') to parameter of type
'ip6_addr_t *' (aka 'struct ip6_addr *') discards qualifiers
[-Werror,-Wincompatible-pointer-types-discards-qualifiers]
netif_ip6_addr_set(pcb->netif, 0, IP6_ADDR_ANY6);
^~~~~~~~~~~~~
../../../../../lwip/src/include/lwip/ip_addr.h:340:24: note: expanded from macro
'IP6_ADDR_ANY6'
^~~~~~~~~~~~~~~~~~~~~~~~~
../../../../../lwip/src/include/lwip/netif.h:436:73: note: passing argument to
parameter 'addr6' here
void netif_ip6_addr_set(struct netif *netif, s8_t addr_idx, ip6_addr_t *addr6);
2016-08-24 14:41:48 +02:00
Axel Lin
bf5866b27d
tcp: Prevents a 0 sized (invalid) backlog
...
commit 44e1a2d8e2
accidently includes below changes in tcp_listen_with_backlog
- tcp_backlog_set(lpcb, backlog);
+ lpcb->backlog = backlog;
Thus pass 0 to the backlog parameter of netconn_listen_with_backlog() fails.
Fixes: 44e1a2d8e2
("define tcp_backlog_set() as dummy-define when backlog feature is disable")
Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: goldsimon <goldsimon@gmx.de>
2016-08-24 12:20:28 +02:00
goldsimon
298ec340e5
set netif IPv6 address & state via function to implement change triggers (task #13517 )
2016-08-24 09:19:53 +02:00
goldsimon
1ba0e17157
ip6_addr: a valid address is either preferred or deprecated, no need to reserve 3 bits for that
2016-08-24 09:06:48 +02:00
Dirk Ziegelmeier
43ddf6eee6
Fix debug strings in ethernet_output
2016-08-24 08:46:32 +02:00
Dirk Ziegelmeier
8426dfa14d
Remove misleading comments from udp_send() and raw_send(). A pbuf may be added automatically in front of the chain to be able to send PBUF_REFs
2016-08-24 08:45:37 +02:00
Dirk Ziegelmeier
6fc7f84497
Minor: documentation updates
2016-08-24 08:19:51 +02:00
Dirk Ziegelmeier
831b7fc7d3
Add note to pbuf_type about correct TX/RX type selection
2016-08-24 08:09:03 +02:00
Dirk Ziegelmeier
d9b0236525
Fix MDNS did not allocate TX packets from RAM but from POOL
2016-08-24 08:04:04 +02:00
Dirk Ziegelmeier
e78bc41116
Document ethernet level functions
2016-08-24 08:01:36 +02:00
Dirk Ziegelmeier
c719c466b3
Remove SIZEOF_ETHARP_PACKET_TX #define, it is not needed any more after my last cleanups
2016-08-23 20:41:37 +02:00
Dirk Ziegelmeier
31778193da
Work on bug #48868 : Cleanup etharp.c not to use struct eth_hdr: Cleanup etharp_input() to use ethernet_output()
2016-08-23 17:23:21 +02:00