mirror/lwip
1
0
Fork 0
mirror of https://github.com/lwip-tcpip/lwip.git synced 2024-12-27 15:16:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

netifapi: Do not pass NULL pointers for IP addresses to subsequent functions

Browse Source 
Same as in my last commits - this avoids errors in lwIP code where ip addresses are dereferenced (e.g. for IP type checking) without handling thinking about NULL pointers.
This commit is contained in:
Dirk Ziegelmeier 2016-03-05 00:03:13 +01:00
parent e0ab8c581d
commit f4fbc90217
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/api/netifapi.c
View File

@ -114,7 +114,7 @@ netifapi_netif_add(struct netif *netif,
err_t err; err_t err;
NETIFAPI_VAR_DECLARE(msg); NETIFAPI_VAR_DECLARE(msg);
NETIFAPI_VAR_ALLOC(msg); NETIFAPI_VAR_ALLOC(msg);
#if LWIP_MPU_COMPATIBLE
if (ipaddr == NULL) { if (ipaddr == NULL) {
ipaddr = IP4_ADDR_ANY; ipaddr = IP4_ADDR_ANY;
} }
@ -124,7 +124,7 @@ netifapi_netif_add(struct netif *netif,
if (gw == NULL) { if (gw == NULL) {
gw = IP4_ADDR_ANY; gw = IP4_ADDR_ANY;
} }
#endif /* LWIP_MPU_COMPATIBLE */
NETIFAPI_VAR_REF(msg).function = netifapi_do_netif_add; NETIFAPI_VAR_REF(msg).function = netifapi_do_netif_add;
NETIFAPI_VAR_REF(msg).msg.netif = netif; NETIFAPI_VAR_REF(msg).msg.netif = netif;
#if LWIP_IPV4 #if LWIP_IPV4
@ -158,7 +158,7 @@ netifapi_netif_set_addr(struct netif *netif,
err_t err; err_t err;
NETIFAPI_VAR_DECLARE(msg); NETIFAPI_VAR_DECLARE(msg);
NETIFAPI_VAR_ALLOC(msg); NETIFAPI_VAR_ALLOC(msg);
#if LWIP_MPU_COMPATIBLE
if (ipaddr == NULL) { if (ipaddr == NULL) {
ipaddr = IP4_ADDR_ANY; ipaddr = IP4_ADDR_ANY;
} }
@ -168,7 +168,7 @@ netifapi_netif_set_addr(struct netif *netif,
if (gw == NULL) { if (gw == NULL) {
gw = IP4_ADDR_ANY; gw = IP4_ADDR_ANY;
} }
#endif /* LWIP_MPU_COMPATIBLE */
NETIFAPI_VAR_REF(msg).function = netifapi_do_netif_set_addr; NETIFAPI_VAR_REF(msg).function = netifapi_do_netif_set_addr;
NETIFAPI_VAR_REF(msg).msg.netif = netif; NETIFAPI_VAR_REF(msg).msg.netif = netif;
NETIFAPI_VAR_REF(msg).msg.msg.add.ipaddr = NETIFAPI_VAR_REF(ipaddr); NETIFAPI_VAR_REF(msg).msg.msg.add.ipaddr = NETIFAPI_VAR_REF(ipaddr);