From f1bd63046e0157769f1fa78140ea6028dcfa3d3c Mon Sep 17 00:00:00 2001 From: Simon Goldschmidt Date: Wed, 10 Jul 2019 21:55:28 +0200 Subject: [PATCH] api_lib: fix duplicate NULL check with sys_sem_valid() --- src/api/api_lib.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/api/api_lib.c b/src/api/api_lib.c index acf6736a..ffa14d65 100644 --- a/src/api/api_lib.c +++ b/src/api/api_lib.c @@ -1346,7 +1346,7 @@ void netconn_thread_init(void) { sys_sem_t *sem = LWIP_NETCONN_THREAD_SEM_GET(); - if ((sem == NULL) || !sys_sem_valid(sem)) { + if (!sys_sem_valid(sem)) { /* call alloc only once */ LWIP_NETCONN_THREAD_SEM_ALLOC(); LWIP_ASSERT("LWIP_NETCONN_THREAD_SEM_ALLOC() failed", sys_sem_valid(LWIP_NETCONN_THREAD_SEM_GET())); @@ -1357,7 +1357,7 @@ void netconn_thread_cleanup(void) { sys_sem_t *sem = LWIP_NETCONN_THREAD_SEM_GET(); - if ((sem != NULL) && sys_sem_valid(sem)) { + if (sys_sem_valid(sem)) { /* call free only once */ LWIP_NETCONN_THREAD_SEM_FREE(); }