mirror/lwip
1
0
Fork 0
mirror of https://github.com/lwip-tcpip/lwip.git synced 2025-01-16 16:13:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

minor: udp_input/local_match: coding style, added comments

Browse Source
This commit is contained in:
sg 2016-02-24 22:04:59 +01:00
parent 68590c2b27
commit ec49b68b38
1 changed files with 13 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/core/udp.c
View File

@ -138,12 +138,20 @@ again:
#endif #endif
} }
/** Common code to see if the current input packet matches the pcb
* (current input packet is accessed via ip(4/6)_current_* macros)
*
* @param pcb pcb to check
* @param inp network interface on which the datagram was received (only used for IPv4)
* @param broadcast 1 if his is an IPv4 broadcast (global or subnet-only), 0 otherwise (only used for IPv4)
* @return 1 on match, 0 otherwise
*/
static u8_t static u8_t
pcb_local_match(struct udp_pcb *pcb, struct netif *netif, u8_t broadcast) udp_input_local_match(struct udp_pcb *pcb, struct netif *inp, u8_t broadcast)
{ {
LWIP_UNUSED_ARG(broadcast); /* in IPv6 only case */ LWIP_UNUSED_ARG(broadcast); /* in IPv6 only case */
/* TODO: Add special dualstack case here */ /* @todo: Add special dualstack case here */
/* Only need to check PCB if incoming IP version matches PCB IP version */ /* Only need to check PCB if incoming IP version matches PCB IP version */
if(ip_current_is_v6() == IP_IS_V6_VAL(pcb->local_ip)) { if(ip_current_is_v6() == IP_IS_V6_VAL(pcb->local_ip)) {
@ -158,7 +166,7 @@ pcb_local_match(struct udp_pcb *pcb, struct netif *netif, u8_t broadcast)
#endif /* IP_SOF_BROADCAST_RECV */ #endif /* IP_SOF_BROADCAST_RECV */
{ {
if(ip4_addr_isany(ip_2_ip4(&pcb->local_ip)) || if(ip4_addr_isany(ip_2_ip4(&pcb->local_ip)) ||
ip4_addr_netcmp(ip_2_ip4(&pcb->local_ip), ip4_current_dest_addr(), netif_ip4_netmask(netif))) { ip4_addr_netcmp(ip_2_ip4(&pcb->local_ip), ip4_current_dest_addr(), netif_ip4_netmask(inp))) {
return 1; return 1;
} }
} }
@ -279,7 +287,7 @@ udp_input(struct pbuf *p, struct netif *inp)
/* compare PCB local addr+port to UDP destination addr+port */ /* compare PCB local addr+port to UDP destination addr+port */
if ((pcb->local_port == dest) && if ((pcb->local_port == dest) &&
(pcb_local_match(pcb, inp, broadcast) != 0)) { (udp_input_local_match(pcb, inp, broadcast) != 0)) {
if ((uncon_pcb == NULL) && if ((uncon_pcb == NULL) &&
((pcb->flags & UDP_FLAGS_CONNECTED) == 0)) { ((pcb->flags & UDP_FLAGS_CONNECTED) == 0)) {
/* the first unconnected matching PCB */ /* the first unconnected matching PCB */
@ -388,7 +396,7 @@ udp_input(struct pbuf *p, struct netif *inp)
if (mpcb != pcb) { if (mpcb != pcb) {
/* compare PCB local addr+port to UDP destination addr+port */ /* compare PCB local addr+port to UDP destination addr+port */
if ((mpcb->local_port == dest) && if ((mpcb->local_port == dest) &&
(pcb_local_match(mpcb, inp, broadcast) != 0)) { (udp_input_local_match(mpcb, inp, broadcast) != 0)) {
/* pass a copy of the packet to all local matches */ /* pass a copy of the packet to all local matches */
if (mpcb->recv != NULL) { if (mpcb->recv != NULL) {
struct pbuf *q; struct pbuf *q;