From e3e3200f953644f8d4aecc835e9c2cc0004c30e3 Mon Sep 17 00:00:00 2001 From: sg Date: Fri, 13 Feb 2015 21:12:23 +0100 Subject: [PATCH] fixed bug #22070 "MIB_OBJECT_WRITE_ONLY not implemented in SNMP" --- CHANGELOG | 4 ++++ src/core/snmp/msg_in.c | 6 ++---- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/CHANGELOG b/CHANGELOG index 16e9e9de..eb2e09a9 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -171,6 +171,10 @@ HISTORY ++ Bugfixes: + 2015-02-13: Simon Goldschmidt + * msg_in.c: fixed bug #22070 "MIB_OBJECT_WRITE_ONLY not implemented in SNMP" + + 2015-02-12: Simon Goldschmidt * ip.h, ip4.c, ip6.c: fixed bug #36403 "ip4_input() and ip6_input() always pass inp to higher layers": now the accepting netif is passed up, but the input netif is available through ip_current_input_netif() if required. diff --git a/src/core/snmp/msg_in.c b/src/core/snmp/msg_in.c index da9b78c1..275c84ce 100644 --- a/src/core/snmp/msg_in.c +++ b/src/core/snmp/msg_in.c @@ -178,8 +178,7 @@ snmp_msg_get_event(u8_t request_id, struct snmp_msg_pstat *msg_ps) /* translate answer into a known lifeform */ en->get_object_def_a(request_id, np.ident_len, np.ident, &msg_ps->ext_object_def); - if ((msg_ps->ext_object_def.instance != MIB_OBJECT_NONE) && - (msg_ps->ext_object_def.access & MIB_ACCESS_READ)) + if (msg_ps->ext_object_def.instance != MIB_OBJECT_NONE) { msg_ps->state = SNMP_MSG_EXTERNAL_GET_VALUE; en->get_value_q(request_id, &msg_ps->ext_object_def); @@ -297,8 +296,7 @@ snmp_msg_get_event(u8_t request_id, struct snmp_msg_pstat *msg_ps) msg_ps->state = SNMP_MSG_INTERNAL_GET_OBJDEF; mn->get_object_def(np.ident_len, np.ident, &object_def); - if ((object_def.instance != MIB_OBJECT_NONE) && - (object_def.access & MIB_ACCESS_READ)) + if (object_def.instance != MIB_OBJECT_NONE) { mn = mn; }