mirror/lwip
1
0
Fork 0
mirror of https://github.com/lwip-tcpip/lwip.git synced 2025-01-30 03:32:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

mdns.c: Fix accessing potentially uninitialized variable

Browse Source 
myprobe_inpkt.pbuf may not be set to NULL in mdns_handle_probe_tiebreaking()
This commit is contained in:
Dirk Ziegelmeier 2018-11-22 13:36:20 +01:00
parent 45a055840d
commit e31f1b918c
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/apps/mdns/mdns.c
View File

@ -834,6 +834,7 @@ mdns_handle_probe_tiebreaking(struct netif *netif, struct mdns_packet *pkt)
*/ */
mdns_define_probe_rrs_to_send(netif, &myprobe_msg); mdns_define_probe_rrs_to_send(netif, &myprobe_msg);
memset(&myprobe_outpkt, 0, sizeof(myprobe_outpkt)); memset(&myprobe_outpkt, 0, sizeof(myprobe_outpkt));
memset(&myprobe_inpkt, 0, sizeof(myprobe_inpkt));
res = mdns_create_outpacket(netif, &myprobe_msg, &myprobe_outpkt); res = mdns_create_outpacket(netif, &myprobe_msg, &myprobe_outpkt);
if (res != ERR_OK) { if (res != ERR_OK) {
goto cleanup; goto cleanup;
@ -1017,9 +1018,8 @@ mdns_handle_probe_tiebreaking(struct netif *netif, struct mdns_packet *pkt)
} }
cleanup: cleanup:
if (myprobe_inpkt.pbuf) { if (myprobe_inpkt.pbuf != NULL) {
pbuf_free(myprobe_inpkt.pbuf); pbuf_free(myprobe_inpkt.pbuf);
myprobe_inpkt.pbuf = NULL;
} }
} }