From e312ebcb573c3d002d16d694c3000f2799f56e14 Mon Sep 17 00:00:00 2001 From: Ivan Delamer Date: Thu, 19 Feb 2015 16:19:29 -0700 Subject: [PATCH] Removed unused netif flag for point to point connections --- CHANGELOG | 3 +++ src/include/lwip/netif.h | 3 --- src/netif/ppp/ppp.c | 2 +- src/netif/slipif.c | 1 - 4 files changed, 4 insertions(+), 5 deletions(-) diff --git a/CHANGELOG b/CHANGELOG index f5317891..9cef025a 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -6,6 +6,9 @@ HISTORY ++ New features: + 2015-02-19: Ivan Delamer + * netif.h, slipif.c, ppp.c: Removed unused netif flag for point to point connections + 2015-02-18: Simon Goldschmidt * api_lib.c: fixed bug #37958 "netconn API doesn't handle correctly connections half-closed by peer" diff --git a/src/include/lwip/netif.h b/src/include/lwip/netif.h index 5c7bf164..abd8af9e 100644 --- a/src/include/lwip/netif.h +++ b/src/include/lwip/netif.h @@ -77,9 +77,6 @@ extern "C" { /** If set, the netif has broadcast capability. * Set by the netif driver in its init function. */ #define NETIF_FLAG_BROADCAST 0x02U -/** If set, the netif is one end of a point-to-point connection. - * Set by the netif driver in its init function. */ -#define NETIF_FLAG_POINTTOPOINT 0x04U /** If set, the interface is configured using DHCP. * Set by the DHCP code when starting or stopping DHCP. */ #define NETIF_FLAG_DHCP 0x08U diff --git a/src/netif/ppp/ppp.c b/src/netif/ppp/ppp.c index 1328d416..587a8dd2 100644 --- a/src/netif/ppp/ppp.c +++ b/src/netif/ppp/ppp.c @@ -438,7 +438,7 @@ static err_t ppp_netif_init_cb(struct netif *netif) { #if PPP_IPV6_SUPPORT netif->output_ip6 = ppp_netif_output_ip6; #endif /* PPP_IPV6_SUPPORT */ - netif->flags = NETIF_FLAG_POINTTOPOINT | NETIF_FLAG_LINK_UP; + netif->flags = NETIF_FLAG_LINK_UP; #if LWIP_NETIF_HOSTNAME /* @todo: Initialize interface hostname */ /* netif_set_hostname(netif, "lwip"); */ diff --git a/src/netif/slipif.c b/src/netif/slipif.c index ca9f0b97..2a1277e4 100644 --- a/src/netif/slipif.c +++ b/src/netif/slipif.c @@ -368,7 +368,6 @@ slipif_init(struct netif *netif) netif->output_ip6 = slipif_output_v6; #endif /* LWIP_IPV6 */ netif->mtu = SLIP_MAX_SIZE; - netif->flags |= NETIF_FLAG_POINTTOPOINT; /* netif->state or netif->num contain the port number */ if (netif->state != NULL) {