mirror/lwip
1
0
Fork 0
mirror of https://github.com/lwip-tcpip/lwip.git synced 2025-01-14 09:39:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixed bug #28877 (Duplicate ARP gratuitous packet with LWIP_NETIF_LINK_CALLBACK set on) by only sending if both link- and admin-status of a netif are up

Browse Source
This commit is contained in:
goldsimon 2010-02-14 20:20:28 +00:00
parent e983865ad5
commit e04e0cb98e
2 changed files with 15 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
CHANGELOG
View File

@ -131,6 +131,11 @@ HISTORY
++ Bugfixes: ++ Bugfixes:
2010-02-14: Simon Goldschmidt
* netif.c: Fixed bug #28877 (Duplicate ARP gratuitous packet with
LWIP_NETIF_LINK_CALLBACK set on) by only sending if both link- and
admin-status of a netif are up
2010-02-14: Simon Goldschmidt 2010-02-14: Simon Goldschmidt
* opt.h: Disable ETHARP_TRUST_IP_MAC by default since it slows down packet * opt.h: Disable ETHARP_TRUST_IP_MAC by default since it slows down packet
reception and is not really necessary reception and is not really necessary

18
src/core/netif.c
View File

@ -452,19 +452,21 @@ void netif_set_up(struct netif *netif)
NETIF_STATUS_CALLBACK(netif); NETIF_STATUS_CALLBACK(netif);
if (netif->flags & NETIF_FLAG_LINK_UP) {
#if LWIP_ARP #if LWIP_ARP
/* For Ethernet network interfaces, we would like to send a "gratuitous ARP" */ /* For Ethernet network interfaces, we would like to send a "gratuitous ARP" */
if (netif->flags & NETIF_FLAG_ETHARP) { if (netif->flags & (NETIF_FLAG_ETHARP)) {
etharp_gratuitous(netif); etharp_gratuitous(netif);
} }
#endif /* LWIP_ARP */ #endif /* LWIP_ARP */
#if LWIP_IGMP #if LWIP_IGMP
/* resend IGMP memberships */ /* resend IGMP memberships */
if (netif->flags & NETIF_FLAG_IGMP) { if (netif->flags & NETIF_FLAG_IGMP) {
igmp_report_groups( netif); igmp_report_groups( netif);
} }
#endif /* LWIP_IGMP */ #endif /* LWIP_IGMP */
}
} }
} }